Re: [rox-devel] ROX-Filer: thumbnail scaling is "wrong"

[Ken H. <ke...@ha...>]

Thomas Leonard wrote:
> On 12/7/06, Barry Kauler <bk...@go...> wrote:
>> Hi, I'm the lead developer of Puppy Linux. Puppy has used ROX-Filer
>> version 1.2.2 for the last couple of years, but I finally decided to
>> upgrade, to v2.5.
> [...]
>> ROX 1.2.2 leaves smaller images as-is. But there doesn't seem to be any
>> setting in 2.5 for this, so I was wondering, is there something that I
>> can easily change in the source code to achieve this?
> 
> It seems the behaviour changed here:
> 
> r3716 | tal197 | 2004-11-11 14:04:24 +0000 (Thu, 11 Nov 2004) | 2 lines
> 
> Much faster thumbnail generation (Ken Hayber, reported by Anthony DiSante).

Oh sure, go ahead and blame me. ;)

> I suspect this was unintentional, and we should never scale up when
> writing thumbnails (whether we choose to scale them up for display or
> not).

I seem to remember some discussion about size, but don't remember the 
conclusion.

> In fact, the spec says:
> 
> "If a program needs a thumbnail for an image file which is smaller
> than 128x128 pixel it doesn't need to save it at all."

Makes sense to me.