Re: [rox-devel] Re: Volume for Alsa

[Ken H. <ke...@ha...>]

Peter Prohaska wrote:
> Ken Hayber wrote:
> 
>>My big question now is: Do I keep calling this something other than
>>'Volume', or do I deprecate the OSS version (keep it around at the
>>current version but unsupported)?
>>
>>I'm leaning towards the latter.
> 
> 
> I'd also prefere the latter.
> 
> Bug: Strange try/except construct in AppRun.
> ---- >8 ----
> try:
> 	import findrox; findrox.version(2,0,0)
> 	import rox, os, sys
> 
> 	...
> except:
> 	rox.report_exception()
> ---- 8< -----
> 
> Summary:
> If (as i experienced) findrox is unable to detect the rox module, your
> except block will still try to use it.  Renders the construct useless in
> this case.
> 
> Fix:
> 1. Use findrox.report_error() in except block instead.
> 2. import findrox outside the try block and let findrox handle the
>    error.
> 
> The second approach is probably the way intended by findrox.  Correct me
> if i'm wrong.
> 
> regards, peter.

That's too funny.  Nice catch.