Re: [rox-devel] OroboROX-0.9.6-13

[Jonatan L. <th...@ho...>]

On Tue, 19 Apr 2005 18:22:50 +0200
Guido Schimmels <__g...@we...> wrote:

> > > On Tue, 19 Apr 2005 13:07:55 -0300
> > > Jonatan Liljedahl <th...@ho...> wrote:
> > > 
> > >   hint - what else?)
> > > > 
> > > > I have noticed that on Mac (OSX), click to focus&raise doesn't
> > > > pass the mouseclick to the app if it wasn't already focused. I
> > > > think it's quite nice, since maybe the only visible area of a
> > > > window that you want to focus and raise is a button that you
> > > > don't actually want to click. =) Maybe we should put a checkbox
> > > > under the Focus section in the window settings for this
> > > > behaviour?
> > > 
> > > I tried what happens when you click "maximize" on a non-focused
> > > window- somehow I've never done this before. Interestingly,
> > > OroboROX maximizes without focusing - I wasn't aware. Some might
> > > even like that, but I consider it a bug.
> > 
> > Ok, what should happen, focus and don't maximize, or focus and
> > maximize?
> 
> Focus only, consistent with clicking inside the app-window.

Should it always behave as if clicking inside the app-window, or as if
clicking on the frame? On the frame, I hope?

In that case, we should just check "if title button pressed AND client
is focused". And only if focus_policy is not RISC OS, where clicking on
the frame should not focus but I assume that the titlebar buttons should
respond anyways? (Hey RISC OS girls, tell me if this is right... ;)

In that case, in events.c:handleButtonPress():

if (c->type & WINDOW_DESKTOP)
   ...
else if (win_type == WIN_BUTTON && ev->button <= Button3
        && (c == clientGetFocus() || c->non_focusing //<-- This one
           || (focus_policy & FOCUS_RISCOS)))        //<-- And this
   clientButtonPress(c, win, ev);
else
   ...

Note: I check for c->non_focusing as I want unfocusable apps to recieve
titlebar buttonpresses even though they are not focused. But this
doesn't seem to work! tested with xload and xclock, which for some
reason are designed non-focusable... Isn't c->non_focusing set for
those?? If not, we have a bug!

/Jonatan    -=( http://kymatica.com )=-