Re: [rox-devel] OroboROX Xinerama patch

[Jonatan L. <th...@ho...>]

On Mon, 14 Jun 2004 19:38:56 +0100
Tony Houghton <h...@re...> wrote:

> In <200...@ho...>, Jonatan Liljedahl wrote:
> 
> > On Sun, 13 Jun 2004 23:08:25 +0100
> > Tony Houghton <h...@re...> wrote:
> > 
> > > My patch for Xinerama support in OroboROX didn't get through
> > > because it's too big for the list. Here's my description again
> > > without the patch attached. Instead you can download it from
> > > <http://www.realh.co.uk/unix/oroborox-0.8.7.1-xinerama-1.0.diff>.
> > > 
> > > I think the patch is definitely releasable, although there are
> > > still some problems. They don't really matter for ROX, but it
> > > would be nice to have it working 100% correctly, and there are
> > > implications for ROX-Filer's application of struts to its panels.
> > 
> > It crashes if you don't have xinerama!
> 
> I seem to have missed out a return from
> xineramaGetMonitorLimitsUnderPoint() in xinerama.c. Does it help if
> you change:
> 
>     if (!n_screens)
>     {
>         xineramaGetScreenLimits(min_x, min_y, max_x, max_y);
>     }
> 
> to:
> 
>     if (!n_screens)
>     {
>         xineramaGetScreenLimits(min_x, min_y, max_x, max_y);
>         return;
>     }
>   
> That reminds me, I forgot to make it cache the screen info and only
> reread it when the screen size changes.

Yep, now it doesn't crash. But I can't test it right now, I have an old
graphics card that I'll put in and see if it works... For some reason I
can't get Xnest to simulate xinerama. When I run xdpyinfo the XINERAMA
extension is loaded but it only reports one screen, and Xnest shows two
screens (windows) with exactly the same contents...

/Jonatan - [ http://kymatica.com ]