From: Chris C. <ca...@al...> - 2001-12-31 11:38:49
|
Guillaume Laurent wrote: > Do you guys have other pending changes you wish to get in before > doing so ? I'm in the middle of some pretty big changes to Composition, and I would actually quite like to see a release fixed _before_ I commit them, as they should be the starting point for a few other sets of big changes (like the real-time timestamps in mapped events stuff, which actually I think I may end up encouraging Rich to work on instead of me...). This does mean I'm unlikely to be of much help fixing any obvious bugs before the release though. (And there are some obvious problems, like the fact that StaffRuler doesn't always work properly and I don't intend to fix it until I do the work of moving it to the lined staff. Maybe we should do some basic sanity testing on editing and playback too...) btw, while I'm here, is there any very compelling reason why we use Composition::swap() after loading a composition from a MIDI or RG21 file? Surely we could just add a setComposition method to the document and then have a Composition assignment operator, or else make the document's m_composition a pointer. Would either of those not work? -- although in fact I suspect what we really _should_ be doing is creating a new document object, not just putting a new composition object into the existing one. Chris |