From: Guillaume L. <gla...@te...> - 2005-05-14 11:45:44
|
On Saturday 14 May 2005 11:54, Chris Cannam wrote: > > See what others have to say on that now, but I'm sure we can happily > take the C++ fixes (I particularly like the one to > rosegardencanvasview). I'm fine with most of it, and at this point I'm not sure keeping compatibility with 3.1 is worth the hassle. The only thing I don't like is completely removing names of unused variables in prototypes like this : -Composition::dump(std::ostream& out, bool full) const +Composition::dump(std::ostream& out, bool) const the name of the variable does convey useful information, so to avoid the warning you should just comment it out. -- Guillaume. http://www.telegraph-road.org |