Re: [Rosegarden-devel] [Proposed Patch] Another couple of dangerous static initializers

[Silvan <dmm...@us...>]

On Wednesday 15 September 2004 05:55 am, Chris Cannam wrote:
> On Wednesday 15 Sep 2004 07:30, Guillaume Laurent wrote:
> > On Wednesday 15 September 2004 05:05, Matthias Neeracher wrote:
> > > - My patch replaces references to Qt::whatever with the hardcoded
> > > color values. This is not all that pretty, but the probability of
> > > Qt::red being changed to a different RGB value are pretty low :-)
> >
> > Silvan, I see you applied this patch : please revert it. There's a
> > better way to fix this without resorting to ugly magic numbers (no
> > matter how unlikely they are to change).
>
> Unless it's a very trivial better way, I suggest we leave the numbers.
> This file (colours.cpp) is full of magic numbers already, in the
> shape of several dozen RGB and HSV colour specifications.

That's why I didn't contemplate it too long before committing the patch.  Just 
by way of explanation.

But if this warrants an ass chewing, by all means give me the ass chewing and 
I will put it back.

-- 
Michael McIntyre  ----   Silvan <dmm...@us...>
Linux fanatic, and certified Geek;  registered Linux user #243621
http://www.geocities.com/Paris/Rue/5407/
http://rosegarden.sourceforge.net/tutorial/