From: Guillaume L. <gla...@te...> - 2003-05-17 13:59:59
|
On Friday 16 May 2003 19:54, Mark Hymers wrote: > > > btw, the ColourMap::m_map_iterator bit of the API is pretty > > weird. Why not just provide begin() and end() methods which > > return iterators, as in any STL container? > > OK. That makes a lot more sense. I've done it. I've only provided a > const_iterator method though because I don't think we want people > playing with the data directly, they should be using the accessor > functions. Makes sense, though I'm not too keen on the "dual" way to access the data, either through interators or through index-based methods. Are you using the iterator somewhere else ? If not, it might be better to simply do away with it. > Good point. I couldn't remember if break worked from within an if > inside a for statement and to tell you the truth couldn't be arsed to > look it up at that moment in time. Fixed now. Please don't take this too bad, but I think we would appreciate if you would take the time to look up such things in the future :-). Saves us reviewing time :-). > Does whoever is responsible for this want a replacement patch or an > incremental one? (replacement is easier for me to generate). Given that your patch is already committed, incremental would be better. It should be easier for you to generate as well, provided you're working against the cvs tree. Otherwise, just check it out through anon-cvs and diff against it. -- Guillaume. http://www.telegraph-road.org |