#1696 Turn repeats into copies misses last segment

[musewhirl]

Turning repeats into copies misses the last segment, for every repeating copy on a track. It's been around as long as I remember, since v18.12 at least, but is minor except when there's a long track with many repeating segments, in which case a segment is missing for every one of them.

Main bug:

1. Fresh RG install
2. Create a segment at measure 10
3. Create a repeating segment at measure 1
4. Select menu option: Segment/Turn Repeats into Copies
5. A segment appears for measures 2-8, but measure 9 is left without a segment

Secondary bug:

The order of segment creation above was adjusted due to what appears to be another minor bug which might as well be mentioned here:

1. Create a repeating segment at measure 1
2. Now there is no way to create a segment anywhere down stream from that segment

Both middle mouse click and the Draw tool do not work. However, a segment can be created on another track and placed on this track to achieve the required result. It seems to be related to the fact that one cannot create a segment at the same track and measure as another segment. On the other hand, CTRL-click of that segment and a slight movement, left or right but in the same measure, will allow the resulting copy to be placed at the same location i.e. if it can be achieved so easily anyway, why would it be prevented for the Draw tool? Finally, note that even in the latter case, the copy does not look like a repeating segment, even though it has the property...it also will not play back as repeating either.

[Philip Leishman]

I beleive this is < / <= issue
going to <= seems to fix it
Please merge

[Ted Felix]

Pushed fix as [2f2c01]. Please test latest git.

[musewhirl]

Tested and working perfectly.