Menu

#1648 Retrograde and Retrograde Invert commands broken

None
closed
None
5
2023-06-07
2023-02-06
No

Commits [0c975c367f] and [ac2658f839], respectively, broke RetrogradeCommand and RetrogradeInvertCommand (the Notation and Matrix editors' "Adjust -> Convert -> Retrograde" and "Retrograde Invert" menu items). Both commands now delete the current selection instead of performing the desired modifications.

The fixes are easy: Restore the segment.insert(toInsert[j]); calls in each .cpp file. The local jtr variable that was commented out in the commits is unused and unneeded. I can't submit a merge request because my codebase has diverged too far from master.

A future enhancement (option) to keep the notes diatonically in-key while inverting would be nice, but the current chromatic implementations are useful as-is and should be restored to their previous working condition.

Discussion

  • Philip Leishman

    Philip Leishman - 2023-02-07

    Thanks for finding that !
    I seem to have been a little overzealous with removing the unused variable.
    See merge request.

     

    Last edit: Ted Felix 2023-02-18
  • Philip Leishman

    Philip Leishman - 2023-02-07
    • assigned_to: Philip Leishman
     
  • Ted Felix

    Ted Felix - 2023-02-18

    Merged as [84faef]. Please test latest git.

     

    Related

    Commit: [84faef]

  • Ted Felix

    Ted Felix - 2023-02-18
    • status: open --> feedback
     
  • Ted Felix

    Ted Felix - 2023-06-07
    • status: feedback --> closed
     

Log in to post a comment.