#3 Fixed lame encoder call for V2.1

[Christian Vogelgsang]

In File config_window_handler.c, line 390:

The correct line should be:

{ NULL, "lame", "ripperX_plugin-lame", "Lame MP3
Encoder", "-b", "-v", "-q", "-p", "" },

The correct option for quality is -q and NOT -h.
And the empty "" at the end that was missing.
The last one is true for other encoders as well and
causes problems there, too.

[Nobody/Anonymous]

Logged In: NO

For lame 3.70 the option _is_ -h

[Jake Janovetz]

Logged In: YES
user_id=32081

Actually, the correct line is not given above.
The "-p" option turns on CRC, so that should be
last. The proper line is:

{ NULL, "lame", "ripperX_plugin-lame", "Lame MP3 Encoder",
"-b", "-v", "-V 4", "-h", "-p"},

since -V n determines quality for VBR and -h turns on
high-quality mode.

[Christian Vogelgsang]

Logged In: YES
user_id=208105

Ok. You are right.
I mixed up the acustic quality (-q n) with
the VBR one (-V n) and misplaced the CRC flag.

To sum up the options in Lame (3.88):

char *bitrate_op; -> -b
char *varbitrate_op; -> -v
char *vbr_qual_op; -> -V n
char *high_qual_op; -> -h
char *crc_op; -> -p

so we need: ...,"-b","-v","-V","-h","-p" }

Please note, that the "vbr_qual_op" always gets a
number appended (Line 633). So the flag we pass
in the config struct must not have one.

[Dave Peverley]

Logged In: YES
user_id=265915

This is nearly true but not quite :-)

Firstly, the flag : "-q" will not work as it requires an integer extension i.e. "-q0" to "-q9". In fact the original "-h" is correct as it maps to "-q2" if you read the lame usage file.

You are correct about the missing field, but looking at the struct definition, the element varbitrate_op is the one that is missing (insert a "", after the 6th field for each structure in the array) The "-p" SHOULD be the final field.

[Jos Dehaes]

Logged In: YES
user_id=36027

obsolete, fixed in CVS