|
From: Mark R. D. <mdi...@la...> - 2002-12-27 23:19:28
|
I've also encountered some conceptual issue with GUI'ness and Batchi'ness in the BaseController that might be good to toss your way. 1.) A model may have GUI's and DataRecorders that are sensitive to whether the model is being run as GUI and/or Batch. 2.) "Run with GUI" and "run as batch" are related but separate concepts and appear out of different needs I.E. a batch controller could include some GUI activity within it (independent of the main controller gui that is). With this in mind it might be good to include setters/getters for GUI'ness and Batchi'ness into IController and BaseConroller. public boolean isGui(); public boolean isBatch(); public void setGui(); public void setBatch(); This because, (1) public boolean isGUI(); public boolean isBatch(); are present in AbstractGUIController (2) public boolean isGUI(); is present in ThinController (3) public boolean isBatch(); is present in BatchController and BaseController Maybe having these be standard methods defined in IController and Implemented by default in BaseController will allow models to use them when running reguardless of the Controller implementation. It would still be the case that an Implementation could overide the methods in their code. Other Notes: There also seems to be a variable "isGui" in both ThinController and BaseController, that could be confusing. It might be clear for bean property introspection if isGUI() was actually isGui. Then the property name would be "gui" instead of "gUI". Cheers, Mark |