[Relfs-devel] =?iso-8859-1?Q?=22LOCAL=22?= #define in Common.h

[Guido V. <gu...@vi...>]

I'm giving a quick look at the source code... 

Why not write: 

#define LOCAL(path) (path +1) 

instead of: 

#define LOCAL(path) (string(".")+string(path)) 

? 

You wouldn't need to use the string class everywhere, which would be better 
(performance-wise), because you do not need all those memory allocations.
I think that the core of the filesystem implementation should be as fast as 
possible, and then still a bit more: for example, I would suggest using C 
instead of C++.
Filesystem calls are very very frequent, so they should be very small and 
very optimised. 

I like the plugin proxy idea, because plugin calls (which could be slow) can 
be moved out of sync from the main process. 

Just my two cents. 

Regards,
Guido