Menu

#34 Refactor N::I::Component::new_from_ical

normal
closed
Net-ICal (57)
5
2012-05-22
2001-05-15
No

the new_from_ical method in Net::ICal::Component needs
to be able to return undef if its parsing of some
iCalendar text fails. This will enable us to validate
incoming text that we didn't generate. More
importantly, it will enable us to make tests to ensure
that we don't accept badly-formatted iCalendar.

Discussion

  • Kirrily Robert

    Kirrily Robert - 2001-06-28

    Logged In: YES
    user_id=9786

    Renamed this bug. The real problem, as I see it, is that
    new_from_ical is a big crufty mess. Let's factor it out
    into some smaller, more manageable subroutines, and then we
    have plenty of places where we can check and return undef if
    things are invalid.

     
  • Kirrily Robert

    Kirrily Robert - 2001-07-03

    Logged In: YES
    user_id=9786

    I think I've factored out as much as I can for now. The
    callback routine is still a bit messy, but I don't grok it
    so I'm not going to go digging aorund in it for now.

     
  • Tim Mooney

    Tim Mooney - 2001-09-07

    Logged In: YES
    user_id=36222

    This is a question, not a statement:

    Should new_from_ical handle MIME streams
    seamlessly? I'm asking because at least one
    calendar package I know (the one we're using,
    CorporateTime from www.steltor.com) exports the
    calendar as a MIME component, i.e. the
    text/calendar part of a multi-part MIME message.

     
  • Martijn van Beers

    Logged In: YES
    user_id=1366

    no, enchanter, that's Net::ITIP's task.

     

Log in to post a comment.

MongoDB Logo MongoDB