reactos-kernel

[ros-kernel] CVS commit

[Steven E. <ste...@ya...>]

Sync of wine_unicode.dll

unicode/*.c
unicode/makefile.ros
unicode/wine_unicode.def
include/basetsd.h
include/wine/unicode.h

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] CVS commit

[Steven E. <ste...@ya...>]

Sync with main WINE tree. Import of libwine.dll. This
dll contains all of the portablity functions and misc
glue for using the wine dlls.

library/*.c
library/libwine.def
library/makefile.ros
include/windef.h
include/wine/port.h
include/wine/debug.h
include/wine/library.h

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] CVS Commit

[Steven E. <ste...@ya...>]

Bringing WINE trees in to sync.

Everything is this is commit is stuff we are not using
in ReactOS. These file may still have useful
information for us so I will keep them up 2 date as
well.

console
controls
debugger
documentation
documentation/samples
documentation/status
files
if1632


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] Can I help?

[Steven E. <ste...@ya...>]

> I' ve been watching Reactos project for quite some
> time.

Cool. Nice to hear from another of the silent
majority.

> I developed the create_nls tool a few months ago and
> I would
> like to help you as much as I can. Can anyone tell
> me if I
> could help somebody?

Pick something and dig in. =)

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] research

[Steven E. <ste...@ya...>]

> functions? Is it safe to read documentation on
> msdn.microsoft.com in order
> to gain info on how to implement a function?
> 
> Royce3

Most documentation falls under Fair Use. As a rule you
shouldnt copy code but "most" of the API information
is public domain so it is safe.

Steven

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] research

[Royce M. I. <ro...@ev...>]

I'm curious what's allowed in order to come up with code for various
functions? Is it safe to read documentation on msdn.microsoft.com in order
to gain info on how to implement a function?

Royce3

Re: [ros-kernel] bugfix

[Royce M. I. <ro...@ev...>]

Well..

If cmd.exe properly expands under NT, but not under ReactOS, then where's
the bug? I'll be glad to apply the fix where it needs to be.

Royce3

----- Original Message -----
From: "KJK::Hyperion" <no...@li...>
To: <rea...@li...>
Sent: Friday, July 05, 2002 6:52 PM
Subject: Re: [ros-kernel] bugfix


> At 00.25 06/07/2002, you wrote:
> > > Sorry, but I think the bug is in the ReactOS shell. It should
> > > ExpandEnvironmentStrings() the command line
> >The ReactOS shell (shell.exe) doesn't support environment variables at
all.
> >The problem was that the expansion of environment variables works on
> >Windows when cmd is used. Although cmd doesn't call
> >ExpandEnvironmentStrings(). SetEnvironmentVariable() expands environment
> >variables but ReactOS didn't implement that.
>
> has this been verified? because here (Windows 2000 Professional) I'm able
> to set a variable to "%PATH%" without it being expanded:
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::set DOH=^%PATH^%
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::echo %DOH%
> %PATH%
>
> I've written a proof-of-concept in Delphi:
>
> (************************************************************)
> program envtest;
>    {$APPTYPE CONSOLE}
>
>    uses
>        Windows
>      ;
>
>    var
>      env: PChar;
>
> begin
>    (* set a variable to a value containing a reference to another
>       variable *)
>    SetEnvironmentVariable('DOH', '%PATH%');
>
>    (* get a pointer to the environment *)
>    env:= GetEnvironmentStrings();
>
>    (* repeat until the environment is empty *)
>    while env^ <> #0 do begin
>      (* print the current variable *)
>      WriteLn(String(env));
>
>      (* skip until the null terminator *)
>      repeat Inc(env); until env^ = #0;
>
>      (* skip the null terminator *)
>      Inc(env);
>    end;
>
> end.
> (************************************************************)
>
> It outputs:
>
> =::=::\
> ALLUSERSPROFILE=D:\home\shared
> APPDATA=D:\home\Hyperion\Dati applicazioni
> BASEDIR=D:\devtools\ntddk
> BCCDIR=D:\devtools\bcc
>
CLASSPATH=D:\programmi\sviluppo\sdk\Java\jre\lib;D:\programmi\sviluppo\sdk\J
ava\lib;.;"D:\Programmi\JavaSoft\JRE\1.3\lib\ext\QTJava.zip"
> CommonProgramFiles=D:\Programmi\File comuni
> COMPUTERNAME=ALDEBARAN
> ComSpec=D:\WINNT\system32\cmd.exe
> DDKDRIVE=D:
> DOH=%PATH% [<--- ]
> [and more]
>
> It looks like SetEnvironmentVariable doesn't parse the variable's value in
> any way (except scanning for the null terminator, of course). Maybe
> RtlSetEnvironmentVariable does? Let's see:
>
> (************************************************************)
> program envtest2;
>    {$APPTYPE CONSOLE}
>
>    type
>      NTSTATUS = Cardinal;
>      BOOLEAN = LongBool;
>      PWSTR = PWideChar;
>      USHORT = Word;
>
>      UNICODE_STRING = record
>        Length, MaximumLength: USHORT;
>        Buffer: PWSTR;
>      end;
>
>    procedure RtlInitUnicodeString(
>      var DestinationString: UNICODE_STRING;
>      const SourceString: PWSTR
>    ); stdcall; external 'ntdll.dll';
>
>    function RtlCreateEnvironment(
>      Inherit: BOOLEAN;
>      var Environment: PWSTR
>    ): NTSTATUS; stdcall; external 'ntdll.dll';
>
>    procedure RtlDestroyEnvironment(
>          Environment: PWSTR
>          ); stdcall; external 'ntdll.dll';
>
>    function RtlSetEnvironmentVariable (
>            var Environment: PWSTR;
>      var Name, Value: UNICODE_STRING
>          ): NTSTATUS; stdcall; external 'ntdll.dll';
>
>    var
>      environ, envtail: PWSTR;
>      dohName, dohValue: UNICODE_STRING;
>
> begin
>    (* copy the environment *)
>    RtlCreateEnvironment(True, environ);
>
>    RtlInitUnicodeString(dohName, 'DOH');
>    RtlInitUnicodeString(dohValue, '%PATH%');
>
>    (* set DOH="%PATH%" *)
>    RtlSetEnvironmentVariable(environ, dohName, dohValue);
>
>    envtail:= environ;
>
>    (* repeat until the environment is empty *)
>    while envtail^ <> #0 do begin
>      (* write the current variable *)
>      WriteLn(String(envtail));
>
>      (* skip until the null terminator *)
>      repeat Inc(envtail) until envtail^ = #0;
>
>      (* skip the null terminator *)
>      Inc(envtail);
>    end;
>
>    (* destroy the copy of the environment *)
>    RtlDestroyEnvironment(environ);
>
> end.
> (************************************************************)
>
> and here's the output:
>
> =::=::\
> ALLUSERSPROFILE=D:\home\shared
> APPDATA=D:\home\Hyperion\Dati applicazioni
> BASEDIR=D:\devtools\ntddk
> BCCDIR=D:\devtools\bcc
>
CLASSPATH=D:\programmi\sviluppo\sdk\Java\jre\lib;D:\programmi\sviluppo\sdk\J
ava\lib;.;"D:\Programmi\JavaSoft\JRE\1.3\lib\ext\QTJava.zip"
> CommonProgramFiles=D:\Programmi\File comuni
> COMPUTERNAME=ALDEBARAN
> ComSpec=D:\WINNT\system32\cmd.exe
> DDKDRIVE=D:
> DOH=%PATH% [<--- ]
> [and more]
>
> Nope. Windows doesn't expand variable references, unless explicitely asked
> for. ReactOS shouldn't either
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Bringing you mounds of caffeinated joy.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

Re: [ros-kernel] compiling

[Casper H. <ch...@us...>]

fre, 2002-07-05 kl. 16:45 skrev Eric Kohl:
> 
> "Steven Edwards" <ste...@ya...> wrote:
...
> - perhaps no or bad lazy write support in the cache manager (I don't know
> about this one)
> 
> Eric

Currently, no lazy writing is done.

Casper

Re: [ros-kernel] bugfix

[KJK::Hyperion <no...@li...>]

At 00.25 06/07/2002, you wrote:
> > Sorry, but I think the bug is in the ReactOS shell. It should
> > ExpandEnvironmentStrings() the command line
>The ReactOS shell (shell.exe) doesn't support environment variables at all.
>The problem was that the expansion of environment variables works on 
>Windows when cmd is used. Although cmd doesn't call 
>ExpandEnvironmentStrings(). SetEnvironmentVariable() expands environment 
>variables but ReactOS didn't implement that.

has this been verified? because here (Windows 2000 Professional) I'm able 
to set a variable to "%PATH%" without it being expanded:

ALDEBARAN\Hyperion [D:\home\Hyperion]
::set DOH=^%PATH^%

ALDEBARAN\Hyperion [D:\home\Hyperion]
::echo %DOH%
%PATH%

I've written a proof-of-concept in Delphi:

(************************************************************)
program envtest;
   {$APPTYPE CONSOLE}

   uses
       Windows
     ;

   var
     env: PChar;

begin
   (* set a variable to a value containing a reference to another
      variable *)
   SetEnvironmentVariable('DOH', '%PATH%');

   (* get a pointer to the environment *)
   env:= GetEnvironmentStrings();

   (* repeat until the environment is empty *)
   while env^ <> #0 do begin
     (* print the current variable *)
     WriteLn(String(env));

     (* skip until the null terminator *)
     repeat Inc(env); until env^ = #0;

     (* skip the null terminator *)
     Inc(env);
   end;

end.
(************************************************************)

It outputs:

=::=::\
ALLUSERSPROFILE=D:\home\shared
APPDATA=D:\home\Hyperion\Dati applicazioni
BASEDIR=D:\devtools\ntddk
BCCDIR=D:\devtools\bcc
CLASSPATH=D:\programmi\sviluppo\sdk\Java\jre\lib;D:\programmi\sviluppo\sdk\Java\lib;.;"D:\Programmi\JavaSoft\JRE\1.3\lib\ext\QTJava.zip"
CommonProgramFiles=D:\Programmi\File comuni
COMPUTERNAME=ALDEBARAN
ComSpec=D:\WINNT\system32\cmd.exe
DDKDRIVE=D:
DOH=%PATH% [<--- ]
[and more]

It looks like SetEnvironmentVariable doesn't parse the variable's value in 
any way (except scanning for the null terminator, of course). Maybe 
RtlSetEnvironmentVariable does? Let's see:

(************************************************************)
program envtest2;
   {$APPTYPE CONSOLE}

   type
     NTSTATUS = Cardinal;
     BOOLEAN = LongBool;
     PWSTR = PWideChar;
     USHORT = Word;

     UNICODE_STRING = record
       Length, MaximumLength: USHORT;
       Buffer: PWSTR;
     end;

   procedure RtlInitUnicodeString(
     var DestinationString: UNICODE_STRING;
     const SourceString: PWSTR
   ); stdcall; external 'ntdll.dll';

   function RtlCreateEnvironment(
     Inherit: BOOLEAN;
     var Environment: PWSTR
   ): NTSTATUS; stdcall; external 'ntdll.dll';

   procedure RtlDestroyEnvironment(
         Environment: PWSTR
         ); stdcall; external 'ntdll.dll';

   function RtlSetEnvironmentVariable (
           var Environment: PWSTR;
     var Name, Value: UNICODE_STRING
         ): NTSTATUS; stdcall; external 'ntdll.dll';

   var
     environ, envtail: PWSTR;
     dohName, dohValue: UNICODE_STRING;

begin
   (* copy the environment *)
   RtlCreateEnvironment(True, environ);

   RtlInitUnicodeString(dohName, 'DOH');
   RtlInitUnicodeString(dohValue, '%PATH%');

   (* set DOH="%PATH%" *)
   RtlSetEnvironmentVariable(environ, dohName, dohValue);

   envtail:= environ;

   (* repeat until the environment is empty *)
   while envtail^ <> #0 do begin
     (* write the current variable *)
     WriteLn(String(envtail));

     (* skip until the null terminator *)
     repeat Inc(envtail) until envtail^ = #0;

     (* skip the null terminator *)
     Inc(envtail);
   end;

   (* destroy the copy of the environment *)
   RtlDestroyEnvironment(environ);

end.
(************************************************************)

and here's the output:

=::=::\
ALLUSERSPROFILE=D:\home\shared
APPDATA=D:\home\Hyperion\Dati applicazioni
BASEDIR=D:\devtools\ntddk
BCCDIR=D:\devtools\bcc
CLASSPATH=D:\programmi\sviluppo\sdk\Java\jre\lib;D:\programmi\sviluppo\sdk\Java\lib;.;"D:\Programmi\JavaSoft\JRE\1.3\lib\ext\QTJava.zip"
CommonProgramFiles=D:\Programmi\File comuni
COMPUTERNAME=ALDEBARAN
ComSpec=D:\WINNT\system32\cmd.exe
DDKDRIVE=D:
DOH=%PATH% [<--- ]
[and more]

Nope. Windows doesn't expand variable references, unless explicitely asked 
for. ReactOS shouldn't either

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"KJK::Hyperion" <no...@li...> wrote:


> Sorry, but I think the bug is in the ReactOS shell. It should
> ExpandEnvironmentStrings() the command line

The ReactOS shell (shell.exe) doesn't support environment variables at all.

The problem was that the expansion of environment variables works on Windows
when cmd is used. Although cmd doesn't call ExpandEnvironmentStrings().
SetEnvironmentVariable() expands environment variables but ReactOS didn't
implement that.

Eric

Re: [ros-kernel] bugfix

[KJK::Hyperion <no...@li...>]

At 02.06 05/07/2002, you wrote:
[...]
>Now, statements like SET PATH=C:\Blah;%PATH% will work.

Sorry, but I think the bug is in the ReactOS shell. It should 
ExpandEnvironmentStrings() the command line

[ros-kernel] Can I help?

[Alexandru M. <ale...@go...>]

I' ve been watching Reactos project for quite some time.

I developed the create_nls tool a few months ago and I would
like to help you as much as I can. Can anyone tell me if I
could help somebody?

I'm a very skilled programmer very interested in OS
programming.


----

Home, no matter how far...
http://www.home.ro

Re: [ros-kernel] enc.c diff

[James M. <jid...@sa...>]

Thanks for that information on making diff the right way for ReactOS.

James Marjie
GnuPG KeyID:    0x7C837497

"Take your life in your own hands, and what happens? A terrible thing: no
one to blame." -Erica Jong

[ros-kernel] CVS Commit: reactos

[Eric K. <ek...@rz...>]

lib/ntdll/rtl/env.c
Added the ability to expand embedded environment variables to
RtlExpandEnvironmentVariable().

Patch by Royce Mitchell III.


Eric

Re: [ros-kernel] enc.c diff

[Eric K. <ek...@rz...>]

"Royce Mitchell III" <ro...@ev...> wrote:

> Finally found a diff.exe! ( It was hiding in my WinCVS directory ).
>
> I got dynamic buffer allocation working, and I also fixed some indentation
> inconsistency.

You can use diff directly from the WinCVS console. The console supports
several unix-like command, like cd and pwd. You can use them to navigate the
cvs tree, but make sure you use the slash instead of the backslash. To
create a patch against the current cvs version you have to change to the
desired directory and type 'cvs -z3 diff -u env.c >env.diff'.

I'll test your attached patch and commit it.

Thanks,
Eric

Re: [ros-kernel] compiling

[Eric K. <ek...@rz...>]

"Steven Edwards" <ste...@ya...> wrote:


> > 1) What is the recommended compiler for recompiling
> > the OS? ( Can I recompile
> > from within the OS, yet? )
>
> You can use mingw/gcc in ReactOS however it is VERY
> slow due to IO issues in the filesystem drivers.
> Hartmut has been working on this

There are some reasons for the low I/O performance:
- no fast io support in ntoskrnl and fsd's
- adapi.sys supports PIO mode but no busmaster dma yet
- perhaps no or bad lazy write support in the cache manager (I don't know
about this one)

Eric

Re: [ros-kernel] compiling

[James T. <jim...@ad...>]

Hi!

> Royce Mitchell III wrote:
> 
> Hi,
> 
> 3) I know you've approached Calmira about using their explorer replacement.
> Unfortunately it is a 16-bit delphi app. Is anybody working on a 32-bit one,
> and if not, do you think you're ready for me to start developing one for you?
> 
> Royce3
> 

Yeah, that was me. I've been waiting for FPC and Lazarus to stabilize enough
to finish porting Calmira to a Windows 32 bit environment.
FYI,
James

Re: [ros-kernel] compiling

[James M. <jid...@sa...>]

I thought so. Guess I was wrong. 8^)


James Marjie
GnuPG KeyID:    0x7C837497

"Take your life in your own hands, and what happens? A terrible thing: no
one to blame." -Erica Jong

[ros-kernel] enc.c diff

[Royce M. I. <ro...@ev...>]

Finally found a diff.exe! ( It was hiding in my WinCVS directory ).

I got dynamic buffer allocation working, and I also fixed some indentation
inconsistency.

Re: [ros-kernel] compiling

[Royce M. I. <ro...@ev...>]

I get a bad command on diff.

Is it supposed to come with mingw?

----- Original Message -----
From: "James Marjie" <jid...@sa...>
To: <rea...@li...>
Sent: Thursday, July 04, 2002 8:06 PM
Subject: Re: [ros-kernel] compiling


> If you have mingw installed is to copy the old file(s) with some prefix
> added or house all modified file in a different directory. Then just issue
> "diff -u <path to original> <path to new>".
> This is how I do it. Someone my have a better way.
>
> James Marjie
> GnuPG KeyID:    0x7C837497
>
> "Take your life in your own hands, and what happens? A terrible thing: no
> one to blame." -Erica Jong
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Caffeinated soap. No kidding.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

Re: [ros-kernel] compiling

[James M. <jid...@sa...>]

If you have mingw installed is to copy the old file(s) with some prefix
added or house all modified file in a different directory. Then just issue
"diff -u <path to original> <path to new>".
This is how I do it. Someone my have a better way.

James Marjie
GnuPG KeyID:    0x7C837497

"Take your life in your own hands, and what happens? A terrible thing: no
one to blame." -Erica Jong

Re: [ros-kernel] compiling

[Royce M. I. <ro...@ev...>]

I'll look into that in a little bit.

How do I make a diff? I've never done it before.

----- Original Message -----
From: "Eric Kohl" <ek...@rz...>
To: "ReactOS Kernel" <rea...@li...>
Sent: Thursday, July 04, 2002 7:05 PM
Subject: Re: [ros-kernel] compiling


>
> "Royce Mitchell III" <ro...@ev...> wrote:
>
> Hello Royce!
>
> > So, I'm thinking I could start by adding support for that. I've already
> > found the function I need to change in NTDLL.DLL
> > (RtlSetEnvironmentVariable), and I've pasted it into a test app so I can
> > modify, and test it without rebooting frequently.
>
> Did you test RtlSetEnvironmentVariable() for the ability to expand a
> variable?
> Im not sure whether the expansion is done by RtlSetEnvironmentVariable()
or
> by SetEnvironmentVariable[A/W] (in lib/kernel32/misc/env.c).
>
>
> > Unless somebody's already working on that, I'll do it.
>
> I remember this bug was reported about a year ago. Please, go ahead and
fix
> it!
>
> > Then, as you suggested, I'm going to start "hacking". I can't run Norton
> > Commander, yet, and I'd like to get that working. I also noticed that
EDIT
> > and MC don't work, either. Personally I feel it would be critical that
the
> > command prompt work well :)
>
> Sure!
>
>
> Regards,
> Eric Kohl
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Caffeinated soap. No kidding.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

Re: [ros-kernel] bugfix

[Royce M. I. <ro...@ev...>]

Okay,

I couldn't get dynamic allocation to work, so I'm not sure how I'm supposed
to do that. In the mean time, here's a fix using a static buffer. This file
goes in reactos/lib/ntdll/rtl.

Now, statements like SET PATH=C:\Blah;%PATH% will work.

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"Royce Mitchell III" <ro...@ev...> wrote:


> I've fixed RtlSetEnvironmentVariable, but at the moment the fix is using a
> static buffer. Can I safely call palloc from that function? Once I get
that
> straightened out, I'll pass it on.

You should use RtlAllocateHeap(RtlGetProcessHeap(), 0, <BufferSize>) to
allocate a buffer in ntdll.dll. C-runtime heap functions like malloc(),
calloc(), free(), etc. are *not* available in ntdll.dll.

> I have also discovered a bug in RtlExpandEnvironmentStrings_U in the
> process.

Great! Can you send me the patch (unified diff format preferred)? I'll apply
it to the cvs tree.

Thanks,
Eric Kohl

Re: [ros-kernel] compiling

[Eric K. <ek...@rz...>]

"Royce Mitchell III" <ro...@ev...> wrote:

Hello Royce!

> So, I'm thinking I could start by adding support for that. I've already
> found the function I need to change in NTDLL.DLL
> (RtlSetEnvironmentVariable), and I've pasted it into a test app so I can
> modify, and test it without rebooting frequently.

Did you test RtlSetEnvironmentVariable() for the ability to expand a
variable?
Im not sure whether the expansion is done by RtlSetEnvironmentVariable() or
by SetEnvironmentVariable[A/W] (in lib/kernel32/misc/env.c).


> Unless somebody's already working on that, I'll do it.

I remember this bug was reported about a year ago. Please, go ahead and fix
it!

> Then, as you suggested, I'm going to start "hacking". I can't run Norton
> Commander, yet, and I'd like to get that working. I also noticed that EDIT
> and MC don't work, either. Personally I feel it would be critical that the
> command prompt work well :)

Sure!


Regards,
Eric Kohl