reactos-kernel

[ros-kernel] implementation question

[Royce M. I. <ro...@ev...>]

I was reading about shell32.DoEnvironmentSubst(), and I came across an
interesting comment in MS documentation:

Parameters must contain valid values that are not NULL. You are responsibile
for validating these values. If you do not validate it, you will experience
unexpected results.

Here's the link where that comment can be found:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pla
tform/shell/reference/functions/doenvironmentsubst.asp

Now, my question is this: what is the harm in checking for invalid params,
and returning failure instead of just letting the OS do it's "unexpected"
thing?

Royce3

Re: [ros-kernel] CVS Commit

[Steven E. <ste...@ya...>]

I guess it depends on if your wanting to suppport a
Ring0 interface. WINE doesnt even do this. If was the
case then no that wouldnt work. In any case the proper
way is going to be to fix WINE/ReWind/WineX to use NT
style HAL interfacing.

Steven


--- Royce Mitchell III <ro...@ev...> wrote:
> Just out of curiousity, is it impossible to support
> the win9x native
> interface in addition to winnt?


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] CVS Commit

[Steven E. <ste...@ya...>]

Started syncing the dlls we are not building for
ReactOS. add 2 directorys for the Regression test
Suite.

dlls/advapi
dlls/kernel
dlls/kernel/messages
dlls/kernel/nls
dlls/ntdll
dlls/ttydrv
dlls/winsock
dlls/wsock32
dlls/x11drv

dlls/winsock/test (Part of the Regression Test Suite)
dlls/kernel/test (Part of the Regression Test Suite)


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] CVS Commit

[Royce M. I. <ro...@ev...>]

Just out of curiousity, is it impossible to support the win9x native
interface in addition to winnt?

----- Original Message -----
From: "Steven Edwards" <ste...@ya...>
To: <rea...@li...>
Sent: Saturday, July 06, 2002 5:11 PM
Subject: [ros-kernel] CVS Commit


> We can now build WINEs dsound.dll. This wont do us
> much good as we have no sound support and WINE uses
> Win9x HAL interfaces for DirectX (FIXME)
>
> dlls/dsound/*
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Sign up for SBC Yahoo! Dial - First Month Free
> http://sbc.yahoo.com
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Got root? We do.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

[ros-kernel] CVS Commit

[Steven E. <ste...@ya...>]

We can now build WINEs dsound.dll. This wont do us
much good as we have no sound support and WINE uses
Win9x HAL interfaces for DirectX (FIXME)

dlls/dsound/*



__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] bugfix

[Steven E. <ste...@ya...>]

I would like it if it didnt do a GUI boot by default
and you just had to type "win" or something but thats
just me.


--- Royce Mitchell III <ro...@ev...> wrote:
> If I can make a request. I realize the goal is a
> windows NT
> clone, but is there no reason to add benefitial
> features?
> 
> I'd really like to be able to at least turn on the
> option to
> not boot the GUI...


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] What am I doing wrong? ( was Re: bugfix )

[Royce M. I. <ro...@ev...>]

Okay, I checked, and I have 0.0.0.19, which as far as I can tell is the
latest kernel.

CMD.EXE is compiled with __REACTOS__.

Immediately upon booting ReactOS, here are the commands I issue:

C:\ReactOS> bin\cmd
[snip - cmd startup info]
C:\ReactOS> c:\bat\mingwenv.bat
C:\ReactOS> set
dircmd=/ogne
include=c:\mingw\include;%include%
lib=c:\mingw\lib;%lib%
OS=ReactOS
PATH=c:\mingw\bin;%path%
SystemDrive=C:
reactos
SystemRoot=C:\reactos
windir=C:\reactos
C:\ReactOS>

I have attached the relevant batch files.

Either there's a bug, or I'm going something wrong.

Royce3

P.S. Why does "reactos" appear below "SystemDrive" in the "Set" list?

Re: [ros-kernel] bugfix

[Royce M. I. <ro...@ev...>]

If I can make a request. I realize the goal is a windows NT
clone, but is there no reason to add benefitial features?

I'd really like to be able to at least turn on the option to
not boot the GUI...

Royce3

----- Original Message ----- 
From: "Steven Edwards" <ste...@ya...>
To: <rea...@li...>
Sent: Saturday, July 06, 2002 4:54 PM
Subject: Re: [ros-kernel] bugfix


> Can we make cmd.exe a defualt option? I was thinking
> about adding a check in winlogon so that if it found
> %SystemRoot%\system32\cmd.exe it used it and if not
> then would load shell.exe. I guess it doesnt much
> matter as everything will change anyway, once we have
> windowing. 
> 
> Steven
> 
> 
> > Cmd runs on ReactOS. But you have to make sure you
> > build the
> > ReactOS-compatible version, which doesn't use
> > unimplemented features. ;-)
> > You'll have to uncomment the line '#define
> > __REACTOS__' in the config.h
> > file. This version of cmd runs on ReactOS and
> > expands environment varables,
> > in most cases, properly.
> 
> __________________________________________________
> Do You Yahoo!?
> Sign up for SBC Yahoo! Dial - First Month Free
> http://sbc.yahoo.com
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Got root? We do.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
> 

Re: [ros-kernel] bugfix

[Steven E. <ste...@ya...>]

Can we make cmd.exe a defualt option? I was thinking
about adding a check in winlogon so that if it found
%SystemRoot%\system32\cmd.exe it used it and if not
then would load shell.exe. I guess it doesnt much
matter as everything will change anyway, once we have
windowing. 

Steven


> Cmd runs on ReactOS. But you have to make sure you
> build the
> ReactOS-compatible version, which doesn't use
> unimplemented features. ;-)
> You'll have to uncomment the line '#define
> __REACTOS__' in the config.h
> file. This version of cmd runs on ReactOS and
> expands environment varables,
> in most cases, properly.

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] bugfix

[Jason F. <jas...@ya...>]

reactos.com > documents > tutorials > developer tutorials > sharing
code

- Jason

--- Royce Mitchell III <ro...@ev...> wrote:
> Does this mean that to fix the problem I need to get the latest
> source?
> 
> What are the CVS commands? I don't remember ever seeing them on the
> web
> site.
> 
> ----- Original Message -----
> From: "Eric Kohl" <ek...@rz...>
> To: <rea...@li...>
> Sent: Saturday, July 06, 2002 12:33 PM
> Subject: Re: [ros-kernel] bugfix
> 
> 
> >
> > "KJK::Hyperion" <no...@li...> wrote:
> >
> > > but our cmd.exe doesn't run on ReactOS (AFAIK). The problem is
> in the
> > > obsolete shell.exe. And if you look at our cmd.exe's sources,
> you'll see
> > > that it expands environment variables as part of the parsing
> >
> > Cmd runs on ReactOS. But you have to make sure you build the
> > ReactOS-compatible version, which doesn't use unimplemented
> features. ;-)
> > You'll have to uncomment the line '#define __REACTOS__' in the
> config.h
> > file. This version of cmd runs on ReactOS and expands environment
> varables,
> > in most cases, properly.
> >
> > Eric
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Got root? We do.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > reactos-kernel mailing list
> > rea...@li...
> > https://lists.sourceforge.net/lists/listinfo/reactos-kernel
> >
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Got root? We do.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel


__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] bugfix

[Kohn E. D. <em...@cs...>]

On Sat, 6 Jul 2002, Royce Mitchell III wrote:

> Does this mean that to fix the problem I need to get the latest source?
>
> What are the CVS commands? I don't remember ever seeing them on the web
> site.


Look at the developer tutorials at

http://reactos.com/rosdocs/tutorials/bk02.html

chapters 10 and 11.


							Emil


>
> ----- Original Message -----
> From: "Eric Kohl" <ek...@rz...>
> To: <rea...@li...>
> Sent: Saturday, July 06, 2002 12:33 PM
> Subject: Re: [ros-kernel] bugfix
>
>
> >
> > "KJK::Hyperion" <no...@li...> wrote:
> >
> > > but our cmd.exe doesn't run on ReactOS (AFAIK). The problem is in the
> > > obsolete shell.exe. And if you look at our cmd.exe's sources, you'll see
> > > that it expands environment variables as part of the parsing
> >
> > Cmd runs on ReactOS. But you have to make sure you build the
> > ReactOS-compatible version, which doesn't use unimplemented features. ;-)
> > You'll have to uncomment the line '#define __REACTOS__' in the config.h
> > file. This version of cmd runs on ReactOS and expands environment
> varables,
> > in most cases, properly.
> >
> > Eric
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Got root? We do.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > reactos-kernel mailing list
> > rea...@li...
> > https://lists.sourceforge.net/lists/listinfo/reactos-kernel
> >
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Got root? We do.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

Re: [ros-kernel] bugfix

[Royce M. I. <ro...@ev...>]

Does this mean that to fix the problem I need to get the latest source?

What are the CVS commands? I don't remember ever seeing them on the web
site.

----- Original Message -----
From: "Eric Kohl" <ek...@rz...>
To: <rea...@li...>
Sent: Saturday, July 06, 2002 12:33 PM
Subject: Re: [ros-kernel] bugfix


>
> "KJK::Hyperion" <no...@li...> wrote:
>
> > but our cmd.exe doesn't run on ReactOS (AFAIK). The problem is in the
> > obsolete shell.exe. And if you look at our cmd.exe's sources, you'll see
> > that it expands environment variables as part of the parsing
>
> Cmd runs on ReactOS. But you have to make sure you build the
> ReactOS-compatible version, which doesn't use unimplemented features. ;-)
> You'll have to uncomment the line '#define __REACTOS__' in the config.h
> file. This version of cmd runs on ReactOS and expands environment
varables,
> in most cases, properly.
>
> Eric
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Got root? We do.
> http://thinkgeek.com/sf
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel
>

[ros-kernel] CVS Commit: reactos

[Eric K. <ek...@rz...>]

lib/ntdll/misc/env.c
    Revert last patch.

Eric

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"KJK::Hyperion" <no...@li...> wrote:

> but our cmd.exe doesn't run on ReactOS (AFAIK). The problem is in the
> obsolete shell.exe. And if you look at our cmd.exe's sources, you'll see
> that it expands environment variables as part of the parsing

Cmd runs on ReactOS. But you have to make sure you build the
ReactOS-compatible version, which doesn't use unimplemented features. ;-)
You'll have to uncomment the line '#define __REACTOS__' in the config.h
file. This version of cmd runs on ReactOS and expands environment varables,
in most cases, properly.

Eric

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"Royce Mitchell III" <ro...@ev...> wrote:

> If cmd.exe properly expands under NT, but not under ReactOS, then where's
> the bug? I'll be glad to apply the fix where it needs to be.

Actually, there is no bug in ReactOS. After reverting your patch, cmd
expands environment variables under ReactOS too.

There are a few related bugs in cmd:
1) It does not handle environment varables in a water-proof way. Environment
variables that are larger than 511 characters will not be expanded properly.
2) The command line buffers are still allocated from the stack.


Eric

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"KJK::Hyperion" <no...@li...> wrote:


> At 00.25 06/07/2002, you wrote:
> > > Sorry, but I think the bug is in the ReactOS shell. It should
> > > ExpandEnvironmentStrings() the command line
> >The ReactOS shell (shell.exe) doesn't support environment variables at
all.
> >The problem was that the expansion of environment variables works on
> >Windows when cmd is used. Although cmd doesn't call
> >ExpandEnvironmentStrings(). SetEnvironmentVariable() expands environment
> >variables but ReactOS didn't implement that.
>
> has this been verified? because here (Windows 2000 Professional) I'm able
> to set a variable to "%PATH%" without it being expanded:
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::set DOH=^%PATH^%
>
> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::echo %DOH%
> %PATH%
>

Hyperion, you're absolutely right! Cmd expands envionment variables
internally as part of the commandline analysis. Neither the ntdll functions
nor the kernel32 functions expand environment variables automatically.

I'll revert the patch!

Eric

Re: [ros-kernel] bugfix

[KJK::Hyperion <no...@li...>]

At 11.15 06/07/2002, you wrote:
>Yes, I verified it on Win98SE, WinNT4(SP6a) and Win2K Pro(SP2). On all 
>OS's an environment variable is expanded when using the default shell 
>(command.com/cmd.exe) or ReactOS cmd.exe!

but our cmd.exe doesn't run on ReactOS (AFAIK). The problem is in the 
obsolete shell.exe. And if you look at our cmd.exe's sources, you'll see 
that it expands environment variables as part of the parsing

> > ALDEBARAN\Hyperion [D:\home\Hyperion]
> > ::set DOH=^%PATH^%
>Why do you use '^%' instead of '%'?

"^" is the escape character. I want DOH to be assigned the literal string 
"%PATH%", to show that Win32 won't expand it

Re: [ros-kernel] research

[KJK::Hyperion <no...@li...>]

At 07.05 06/07/2002, you wrote:
>I'm curious what's allowed in order to come up with code for various 
>functions? Is it safe to read documentation on msdn.microsoft.com in order 
>to gain info on how to implement a function?

For the documented functions, yes, it's the best way (download or order - 
for free - the Platform SDK. All the documentation you'll need and more). 
For the others: disassemble, or invent. They're undocumented, so we can be 
pretty sure that (almost) no program uses them

Re: [ros-kernel] CVS commit

[David K. <kr...@mi...>]

I got this on current cvs tree :

make -f makefile.ros -C ./../wine/tools/winebuild
make[1]: Entering directory `d:/ros/wine/tools/winebuild'
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c im
port.c -o import.o
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c ma
in.c -o main.o
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c pa
rser.c -o parser.o
In file included from ../../include/winbase.h:27,
                 from parser.c:34:
./../include/windef.h:152: warning: `MAX_PATH' redefined
d:/mingw/bin/../lib/gcc-lib/mingw32/2.95.3-7/../../../../include/stdlib.h:62: warning: this is the location of the previous definition
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c re
lay.c -o relay.o
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c re
s16.c -o res16.o
In file included from ../../include/winbase.h:27,
                 from res16.c:35:
./../include/windef.h:152: warning: `MAX_PATH' redefined
d:/mingw/bin/../lib/gcc-lib/mingw32/2.95.3-7/../../../../include/stdlib.h:62: warning: this is the location of the previous definition
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c re
s32.c -o res32.o
In file included from ../../include/winbase.h:27,
                 from res32.c:35:
./../include/windef.h:152: warning: `MAX_PATH' redefined
d:/mingw/bin/../lib/gcc-lib/mingw32/2.95.3-7/../../../../include/stdlib.h:62: warning: this is the location of the previous definition
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c sp
ec16.c -o spec16.o
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c sp
ec32.c -o spec32.o
gcc -I../../include -D__REACTOS__ -D__MINGW__ -D_WINDOWS -DWINE_NOWINSOCK -I../../../reactos/include/wine -I./ -I../../include -pipe -march=i386 -c ut
ils.c -o utils.o
make[1]: *** No rule to make target `../../../reactos/dk/w32/lib/libwine.a', needed by `winebuild.nostrip.exe'.  Stop.
make[1]: Leaving directory `d:/ros/wine/tools/winebuild'
make: *** [winebuild] Error 2

David 

[ros-kernel] CVS commit

[Steven E. <ste...@ya...>]

reactos/Makefile -
Remove wine/dlls/rpcrt4.dll as a target

reactos/include/wine/config.h -
import a new config.h for the WINE fork

wine/makefile.ros -
fix some compiler FLAGS

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] WINE sync information

[Steven E. <ste...@ya...>]

I should be done syncing everything by sunday but as
it stands right now at 5 am est wine/programs and dlls
are  totaly hosed. Once I am done syncing everything
that can be built under Mingw wiht MSYS will be able
to be built by our buildsystem.

If anyone is interested and knows our build system
well I need to minor changes made. Currently I can
work around them but the 2 issues are

1. *.def - winebuild can automaticly build these from
the specs so we should adapt the system to do this.

2. wine resources - All wine resources must first pass
thought the wrc before going to windress.

Thanks
Steven

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] CVS Commit

[Steven E. <ste...@ya...>]

Sync the rest of the misc WINE stuff. 


*
graphics
graphics/x11drv
graphics/enhmetafiledrv
graphics/metafiledrv
graphics/win16drv
libtest
loader
loader/ne
loader/dos
memory
misc
miscemu
msdos
objects
ole
relay32
scheduler
server
tsx11
win32
windows
windows/x11drv

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

Re: [ros-kernel] bugfix

[Eric K. <ek...@rz...>]

"KJK::Hyperion" <no...@li...> wrote:

> > > Sorry, but I think the bug is in the ReactOS shell. It should
> > > ExpandEnvironmentStrings() the command line
> >The ReactOS shell (shell.exe) doesn't support environment variables at
all.
> >The problem was that the expansion of environment variables works on
> >Windows when cmd is used. Although cmd doesn't call
> >ExpandEnvironmentStrings(). SetEnvironmentVariable() expands environment
> >variables but ReactOS didn't implement that.
>
> has this been verified? because here (Windows 2000 Professional) I'm able
> to set a variable to "%PATH%" without it being expanded:

Yes, I verified it on Win98SE, WinNT4(SP6a) and Win2K Pro(SP2). On all OS's
an environment variable is expanded when using the default shell
(command.com/cmd.exe) or ReactOS cmd.exe! I always used the command 'set
zod=%path%'.


> ALDEBARAN\Hyperion [D:\home\Hyperion]
> ::set DOH=^%PATH^%

Why do you use '^%' instead of '%'?


Eric

[ros-kernel] CVS commit

[Steven E. <ste...@ya...>]

broke everything else not commited in our WINE tree.
Sync of WINE includes:

include/
include/wine
include/msvcrt
include/msvcrt/sys
include/bitmaps

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

[ros-kernel] CVS commit

[Steven E. <ste...@ya...>]

bringing wrc and winebuild up to sync

tools/wrc
tools/winebuild
include/windef.h
include/wingdi.h

__________________________________________________
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com