RE: [ros-kernel] Patch: Teach freeldr registry about multi andexpanded types

[Brian P. <br...@sg...>]

I have a few questions about this:

reactos.c line 193:
rc = RegQueryValue(hGroupKey, "List", NULL, (PUCHAR)&ValueBuffer,
&BufferSize);

Shouldn't that be:
rc = RegQueryValue(hGroupKey, "List", NULL, (PUCHAR)ValueBuffer,
&BufferSize);

And the same thing in meminit.c line 64. Since BiosMemoryMap is a
pointer to the array, you are passing in the address of the pointer to
the array and casting it to type PBIOS_MEMORY_MAP.

I also noticed that this patch changes all the function prototypes from
ULONG GetBiosMemoryMap(BIOS_MEMORY_MAP BiosMemoryMap[32]); to ULONG
GetBiosMemoryMap(PBIOS_MEMORY_MAP BiosMemoryMap); Now this would
normally be fine except that that function returns an array of exactly
32 items since the size of the memory map is not known before the
function call.

Also the %ld in the strings passed to printf() is not supported in the
printf() function included with freeldr. It should probably be updated.

Thanks for the patch, every little bit helps.

Brian


> -----Original Message-----
> From: rea...@li...
[mailto:reactos-kernel-
> ad...@li...] On Behalf Of Casper Hornstrup
> Sent: Tuesday, June 11, 2002 1:59 PM
> To: rea...@li...
> Subject: Re: [ros-kernel] Patch: Teach freeldr registry about multi
> andexpanded types
> 
> tir, 2002-06-11 kl. 21:07 skrev Joseph Galbraith:
> > freeldr\freeldr\reactos\reghive.c
> >
> >     Merge in smarts about multi: and
> >     expand: data types from the ntoskrnl
> >     version of the registry import
> >     functions so that freeldr can boot
> >     the OS again.
> >
> > Joseph
> 
> Applied. Thanks for the patch.
> 
> Casper
> 
> 
> 
> _______________________________________________________________
> 
> Multimillion Dollar Computer Inventory
> Live Webcast Auctions Thru Aug. 2002 -
> http://www.cowanalexander.com/calendar
> 
> 
> 
> _______________________________________________
> reactos-kernel mailing list
> rea...@li...
> https://lists.sourceforge.net/lists/listinfo/reactos-kernel