Re: [ros-kernel] Patch to implement NtCreateToken()

[Joseph G. <gal...@va...>]

"Eric Kohl" <ek...@rz...> wrote:

> "Joseph Galbraith" <gal...@va...> wrote:
>
>
> > I've implemented NtCreateToken and fixed up
> > NtQueryInformationToken().
> >
> > - Implement NtCreateToken()
> > - Implement RtlGetAce()
> > - Fix bug which cause RtlCreateAcl() to always fail.
> > - Cleanup parameter names and fix bug that caused a
> >   buffer overrun in RtlCopySidAndAttributesArray()
> > - When referencing the token object in NtQueryInformationToken()
> >   pass in either TOKEN_QUERY access or TOKEN_QUERY_SOURCE access.
> >   Passing in zero led to ObReferenceObjectByHandle() always
> >   failing with ACCESS_DENIED.
> > - Fixed NtQueryInformationToken() to check the buffer
> >   length and return STATUS_BUFFER_TO_SMALL and the
> >   required length.
> > - Ensure that the ReturnLength is set correctly when
> >   NtQueryInformationToken() succeeds.  Previously, it
> >   was set to the number of bytes unused in the user buffer
> >   in some cases or not set at all.
> > - Handle case of NULL default dacl correctly in
> >   NtQueryInformationToken()
> > - Update main makefile to build apps\utils.
> > - Update makefiles in apps\utils to have the
> >   correct PATH_TO_TOP.
> > - Update main makefile to build apps\tests\tokentest
>
> Great!
>
> > I've included the output from cvs diff; I'm
> > not sure if that is good enough or not (I'm
> > definitely not a patch / diff guru.)
>
> Could you resubmit patch.txt using the unified format (run 'diff -u'). The
> unified format is much more readable than the other formats.

Here it is.  Thanks.  Let me know if this didn't get
it.

- Joseph