Re: [ros-kernel] ReactOS.org in CVS

[KJK::Hyperion <no...@li...>]

At 20.04 08/05/2002, you wrote:
>I finally imported reactos.org into cvs (cvs co reactos.org). 
>Unfortunately I accidentally imported all my compiled template files too!! 
>If you check it out, remove everything in the templates_c directory (but 
>leave the directory itself there). There's an install.txt, but it's bound 
>to be lacking, so just mail me with any queries. It's very much a work in 
>progress... but give it a spin.

First of all, a suggestion: always htmlspecialchars() *ALL* text that is to 
be output literally, if you're outputting any kind of SGML (be it HTML, XML 
or whatever). This applies to text nodes and (easily overlooked) tag 
attribute values. It protects from any kind of code injection through HTML. 
If you know you have unprotected outputs, check them!

Another suggestion: always output something. PHP sends by default a content 
size header of zero bytes, because the content is generally generated on 
the fly. If you don't send anything some browsers (for example Opera) will 
think that the page hasn't output anything *YET*, and wait until they time 
out. This applies to tables.mysql.php. Add some progress messages after 
every table is created (I can fix this)

Finally: can't get it to run! :-/ index.php gives this error:

Warning: Smarty error: unable to read template resource: "index.tpl" in 
D:\programmi\sviluppo\librerie\Smarty\Smarty.class.php on line 546

Some details on how I deployed rosproj:
  - I couldn't use the recommended <http://localhost/rosproj/> URL since I 
have a dozen virtual hosts configured on this machine, and want to keep the 
default host non-configured. So I gave it an URL of 
<http://rosproj.aldebaran/rosproj/>
  - rosproj is installed in D:\misc\wwwroot\rosproj\rosproj
  - Smarty is installed in 
D:\programmi\sviluppo\librerie\Smarty\Smarty.class.php
  - PHP is installed in D:\devtools\php
  - my PHP include_path reads:
include_path = ".;D:\devtools\php\pear\;D:\programmi\sviluppo\librerie\Smarty\"

All looks fine to me. Maybe I need additional configuration for PHP? can 
you send me your php.ini?