From: SourceForge.net <no...@so...> - 2011-08-23 13:31:58
|
Bugs item #3027341, was opened at 2010-07-09 06:32 Message generated for change (Comment added) made by rexdieter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1128048&aid=3027341&group_id=264924 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Fixed Priority: 8 Private: No Submitted By: Tilman Blumenbach (tblue246) Assigned to: Nobody/Anonymous (nobody) Summary: re-alpine 2.01 fails to build (OpenSSL-related) Initial Comment: When trying to build re-alpine 2.01 with GCC 4.5.0 and OpenSSL 1.0.0a, I get the following error: smkeys.c: In function 'get_x509_subject_email': smkeys.c:280:5: error: 'STACK' undeclared (first use in this function) The referenced line is: STACK *emails = X509_get1_email(x) I don't know much about OpenSSL, but it looks like the return type of X509_get1_email() changed from STACK* to STACK_OF(OPENSSL_STRING)*. The following declaration works (also see attached patch): STACK_OF(OPENSSL_STRING) *emails = X509_get1_email(x); Oh, I also cloned the git repo and the problem exists there, too. ---------------------------------------------------------------------- Comment By: Rex Dieter (rexdieter) Date: 2011-08-23 08:31 Message: Had fedora's openssl maintainer provide a patch... I'll attach it, and work to commit it to scm asap. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2011-08-23 02:17 Message: re-alpine 2.02 does not compile on CentOS6 (and probably not on RHEL6 either), where OPENSSL_VERSION_NUMBER = 0x10000003 but the return type is STACK_OF(OPENSSL_STRING)*. The code checks for OPENSSL_VERSION_NUMBER>=0x1000000f and uses STACK*, which doesn't work. ---------------------------------------------------------------------- Comment By: Andraž Levstik (ruskie3) Date: 2010-07-16 00:51 Message: Will mark as closed once it hits a proper release. ---------------------------------------------------------------------- Comment By: Andraž Levstik (ruskie3) Date: 2010-07-16 00:46 Message: Applied and commited. ---------------------------------------------------------------------- Comment By: Tilman Blumenbach (tblue246) Date: 2010-07-09 12:45 Message: Well, I hope it *really* works now. See attached patch. ---------------------------------------------------------------------- Comment By: Tilman Blumenbach (tblue246) Date: 2010-07-09 12:18 Message: Nope. Looks like I messed something up. Will do some more research. ---------------------------------------------------------------------- Comment By: Tilman Blumenbach (tblue246) Date: 2010-07-09 12:02 Message: Please test the second version of my patch. I *think* it should build with OpenSSL v0.x and v1.0.0 now. ---------------------------------------------------------------------- Comment By: Tilman Blumenbach (tblue246) Date: 2010-07-09 11:44 Message: Okay, it looks like OpenSSL <= 0.9.8o uses a return type of STACK*, and the current version (1.0.0a) uses STACK_OF(OPENSSL_STRING) *. I only looked at release versions. I think we could check OPENSSL_VERSION_NUMBER. I will look at that. ---------------------------------------------------------------------- Comment By: Andraž Levstik (ruskie3) Date: 2010-07-09 11:19 Message: Hmm have you checked if this works with older openssl as well? It seems to build for me on 0.9.8l. ---------------------------------------------------------------------- Comment By: Tilman Blumenbach (tblue246) Date: 2010-07-09 06:49 Message: Oh wow, that was fast! Great to see this project is alive. Well, I don't think I need push access (yet?), but thanks anyway. ---------------------------------------------------------------------- Comment By: Andraž Levstik (ruskie3) Date: 2010-07-09 06:46 Message: Great... I'll apply it asap... If you want I can give you push access as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1128048&aid=3027341&group_id=264924 |