From: SourceForge.net <no...@so...> - 2006-02-18 19:36:52
|
Bugs item #1055468, was opened at 2004-10-27 19:30 Message generated for change (Comment added) made by ikonst You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381347&aid=1055468&group_id=24366 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Visual Group: None >Status: Closed >Resolution: Fixed Priority: 7 Submitted By: Nobody/Anonymous (nobody) Assigned to: Ilya Konstantinov (ikonst) Summary: Black display on non-8/15/16/24/32-bit visuals Initial Comment: Works fine without -a parameter in 256 colors. But if you try -a 16 or -a 24 always appear a black rdesktop client window. IRIX 6.5.21 rdesktop 1.3.1 compiled on origin200 for irix 6.4 and indigo for 6.2. with any warning. ---------------------------------------------------------------------- >Comment By: Ilya Konstantinov (ikonst) Date: 2006-02-18 21:36 Message: Logged In: YES user_id=335423 Fixed by patch #1390148. ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-11-27 13:56 Message: Logged In: YES user_id=335423 In fact, our order of preference should be: 1. If the RDP server's depth is above 8bpp --> a visual with the same bpp. 2. A visual with 24bpp. 3. Any other visual *we can handle* (i.e. have a matching translate_image function for it). Implementing this policy would also unintentionally solve bug #1341223 since we'll be avoiding the dreaded 32bpp visual in all relevant cases (i.e. on NVidia'a driver). ---------------------------------------------------------------------- Comment By: Ilya Konstantinov (ikonst) Date: 2005-10-30 00:26 Message: Logged In: YES user_id=335423 On IRIX, the visual with the highest depth is a 30-plane one, having 10 bits for each color (higher color fidelity than most PCs and not something useful to rdesktop anyway). rdesktop prefers the highest-depth visual, even when lower is enough (at until patch 1334905 is checked in). Apparently, xwin.c translate_image() contains no implementation for anything but 8, 15, 16, 24 and 32-planes visuals, so quite simply, nothing ever gets drawn -- thus black screen. The first solution shall be to refuse to accept anything but the visuals we support. Since such machines typically offer 24-bit visuals as well, this should be harmless and would even ensure better performance. Also, we'll have to ensure we only accept visuals with supported per-color masks (translate_image has hardcoded shifts!), or otherwise modify translate_image to support custom color masks (e.g. 3 bits for green, 3 bits for blue, 18 bits for red -- not like this would appear in real world, so it's not criticial). ---------------------------------------------------------------------- Comment By: Void Foo (voidfoo) Date: 2005-08-07 20:38 Message: Logged In: YES user_id=859378 same here when rdesktop try to use a visual with higher than 24bit color depth. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=381347&aid=1055468&group_id=24366 |