[rdesktop-devel] Possible patch for clipboard bug

[David L. <dl...@bj...>]

Hi,
I'd been having some trouble with Eclipse hanging and I was finally able
to figure out that the problem was linked with rdesktop somehow
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=106458). With the help of
the Eclipse people I was able to find out that the problem has to do
with the clipboard. When it does occur, this is the rdesktop output:

xclip_handle_SelectionRequest: selection=CLIPBOARD, target=resource-transfer-format:1130009212906:2739852, property=GDK_SELECTION
CLIPRDR send: type=4, status=0, length=4
channel_send, length = 16
Sending 16 bytes with FLAG_FIRST
CLIPRDR recv: type=5, status=2, length=0
CLIPRDR error (type=5)

As far as I can tell, rdesktop gets an error while trying to retrieve
the clipboard and then never sends anything back for the selection request.
Eclipse then just sits there waiting for a reply until it times out.

I've come up with a patch (against CVS) that will possibly fix the
problem. Could somebody take a look and tell me if what I'm doing is a
good idea? I'm mainly concerned about it sending back a selection with
length = 0. I'm not sure if that's a good idea.

I think this patch will address these two bugs:
https://sourceforge.net/tracker/?group_id=24366&atid=381347&func=detail&aid=1199060
https://sourceforge.net/tracker/?group_id=24366&atid=381347&func=detail&aid=862403

Thanks for your help.

David Lowry