Re: [rdesktop-devel] Strange Valgrind error

[Peter A. <pe...@ce...>]

> > When running rdesktop in Valgrind, I get the following error message:
> >
> > ==17399== Conditional jump or move depends on uninitialised value(s)
> > ==17399==    at 0x804FFD4: ui_create_cursor (xwin.c:1605)
> > ==17399==    by 0x804EFEE: ui_create_window (xwin.c:1057)
> > ==17399==    by 0x804C566: main (rdesktop.c:712)
> > ==17399==
> > [SNIP]
> >
> > Line 1605 looks like:
> >
> > if (xormask[0] || xormask[1] || xormask[2])
> 
> But Line 1616 reads:
> 
> xormask += 3;

You are right. I must admit that I don't understand how ui_create_cursor 
really works. However, I've committed this patch, which fixes the valgrind 
error. It should be safe. 

--- xwin.c      23 Aug 2004 11:28:23 -0000      1.176
+++ xwin.c      8 Sep 2004 07:18:32 -0000
@@ -946,7 +946,7 @@
 ui_create_window(void)
 {
        uint8 null_pointer_mask[1] = { 0x80 };
-       uint8 null_pointer_data[4] = { 0x00, 0x00, 0x00, 0x00 };
+       uint8 null_pointer_data[9] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
        XSetWindowAttributes attribs;
        XClassHint *classhints;
        XSizeHints *sizehints;


-- 
Peter Åstrand		Chief Developer
Cendio			www.thinlinc.com
Teknikringen 3		www.cendio.se
583 30 Linköping        Phone: +46-13-21 46 00