Re: Re[6]: [rdesktop-devel] port for svgalib

[Peter <pet...@ub...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 01 November 2002 16.06, Andrey Kovalev wrote:
> Hello Maikel,
>
> MV> svga.c:1584: `__NR_clone' undeclared (first use in this function)
> I think, it's for linux only...
>
> MV> this is my error message. I cannot find ANY reference to CLONE in m=
y
> header MV> files or man pages. Should I just try to rewrite it to use
> pthreads? Why did MV> you make your own thread function instead of usin=
g
> the pthreads libraries?
>
> Donald Gordon wrote start_thread, and I leave it unchanged, just
> because it work well for me.

actually it was me modifying the code.  start_thread was needed, to be=20
compatible with the ui scheme in the patches. I didn't use pthread, becau=
se=20
svgalib and pthreads don't mix well. they use the same signals.=20
	the notes are in the svgalib documentation, if they haven't changed it, =
it's=20
a while ago. at the time I verified against pthreads documentation, and i=
t=20
was true at the time.
	since the ui scheme of the patches aren't used in the cvs you may consid=
er=20
reworking it again, against the current cvs at sourceforge, in which case=
 you=20
wont need threads at all..

best regards,

Peter

>
> When we use direct calls to linux kernel, we make it "more portable",
> i.e. it will work at almost every linux ;)
>
> Ok, now I describe changes in svga.c for working with pthread.
> 1. Remove start_thread function.
> 2. Include <pthread.h>.
> 3.
>
> int
> ui_select_fd()
> {
> +  pthread_t     thrd;
> FTR("ui_select_fd");
>   if (pipe(fd_vga_evt) =3D=3D -1)
>     {
>       ERROR("ui_select_fd(): ERROR while creating pipe\n");
>       return -1;
>     }
>
> -  if (start_thread (svga_thread_wait, (void *) &fd_vga_evt[1]) =3D=3D =
-1)
> +  if (pthread_create (&thrd, NULL, svga_thread_wait, (void *)
> &fd_vga_evt[1])) {
>
> 4. Add pthread library to linker command string, i.e. add
> -lpthread
> to LDFLAGS in Makeconf.

- --=20
Peter Bystr=F6m <pet...@ub...>
Systemstechnician
=D6rebro UNI, Library
=20
PGP Key-ID: 0x41C60D62
- --
This electronic act of communication (called "mail")
may only be read by non-US citizens since it might contain
security related material covered by the DMCA act.
This mail is therefore released under the license found here:
http://www.thefreeworld.net/non-US/index.php



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9y1miqORp8UHGDWIRAslLAJ9qzQi3Gwq/6STNikOwBLv8IkvNNgCfTe3M
6/HVdVPTYhKtwNrw1Eh+7X0=3D
=3Dqulo
-----END PGP SIGNATURE-----