[Rdesktop-commits] SF.net SVN: rdesktop:[1788] rdesktop/trunk/rdesktop.c

[<he...@us...>]

Revision: 1788
          http://sourceforge.net/p/rdesktop/code/1788
Author:   hean01
Date:     2014-02-19 08:02:07 +0000 (Wed, 19 Feb 2014)
Log Message:
-----------
Clear memory before use. Fixes bug where hash of licensefilename
differs between load and save.

Thanks to Florent Peterschmitt for reporting,testing and patch.

Modified Paths:
--------------
    rdesktop/trunk/rdesktop.c

Modified: rdesktop/trunk/rdesktop.c
===================================================================
--- rdesktop/trunk/rdesktop.c	2014-02-07 14:08:00 UTC (rev 1787)
+++ rdesktop/trunk/rdesktop.c	2014-02-19 08:02:07 UTC (rev 1788)
@@ -1678,6 +1678,7 @@
 	if (home == NULL)
 		return -1;
 
+	memset(hi, 0, sizeof(hi));
 	snprintf((char *) hi, 16, "%s", g_hostname);
 	sec_hash_sha1_16(ho, hi, g_static_rdesktop_salt_16);
 	sec_hash_to_string(hash, sizeof(hash), ho, sizeof(ho));
@@ -1726,6 +1727,7 @@
 		return;
 	}
 
+	memset(hi, 0, sizeof(hi));
 	snprintf((char *) hi, 16, "%s", g_hostname);
 	sec_hash_sha1_16(ho, hi, g_static_rdesktop_salt_16);
 	sec_hash_to_string(hash, sizeof(hash), ho, sizeof(ho));

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.