Re: [rdesktop-devel] TSE licenses - continuously asking for new one?

[Florent P. <fl...@pe...>]

Hi Henrik,

I have a workaround for the license problem.

I printed sucesssively g_hostname, hi, ho and hash variables, in
load_licence and save_licence, and saw that ho has never the same value
and strangely, hi no more.

From that results an incorrect hash between load and save calls.

I don't know how this is possible, but to make it work, I made a memset
on hi and ho before any use of these variables.



I'm not sure it is a correct way to do, but for the moment, it works well.

See the attached patch.

On 07/02/2014 08:29, Henrik Andersson wrote:
> On Tue, 04 Feb 2014 22:27:26 +0100
> Florent Peterschmitt <fl...@pe...> wrote:
> 
>> Le 07/01/2014 09:03, Henrik Andersson a écrit :
>>> On Mon, 06 Jan 2014 17:04:45 +0100
>>> Florent Peterschmitt <fl...@pe...> wrote:
>>> Hi Florent,
>>>
>>>> What we see here is:
>>>>
>>>> 1. search for 09dcea473ad6f1ca5c33bc89df88aa42560b82b4.cal file
>>>> 2. fail to open it (it doesn't exists)
>>>> 3. write to another file something (a new TSE license?)
>>>> 4. close this new file
>>>>
>>>> If I re-launch rdesktop, then the same file (09...) is asked, not
>>>> found and another _new_ CAL file is created. At this point, I have
>>>> 2 CAL files.
>>>>
>>>> If I mv the latest CAL to the wanted CAL (09...), here is what I
>>>> have:
>>>>
>>>> [admin@S777TXDTTEST ~]$ cd .local/share/rdesktop/licenses/
>>>> [admin@S777TXDTTEST licenses]$ ls
>>>> 0f6f3932c9ecff5b253edabc71d017de013a1778.cal
>>>> ebbcc14692930d5d3f71925f6cc657ec02fa02cf.cal
>>>> [admin@S777TXDTTEST licenses]$ mv
>>>> 0f6f3932c9ecff5b253edabc71d017de013a1778.cal
>>>> 09dcea473ad6f1ca5c33bc89df88aa42560b82b4.cal
>>>> [admin@S777TXDTTEST licenses]$ strace -o rdesktop.trace
>>>> /usr/bin/rdesktop -x 0x86 -N -a 16 -P -z -k en-us S777SQ01 -u ''
>>>> Failed to negotiate protocol, retrying with plain RDP.
>>>> * is this behaviour the expected one?
>>>
>>> No, this is not an expected behavior.
>>>
>>>> * does this behaviour can be responsible about an over consumption
>>>> of TSE licenses?
>>>>
>>>
>>> I'm unsure, i need to investigate the issue first before having a
>>> straight up answer, I will take a look at this issue this week and
>>> get back to you.
>>>
>>>
>>> Kind Regards,
>>>
>>> Henrik Andersson (Cendio AB)
>>
>> Hello,
>>
>> Did you have the time for any investigation? Also, do you think
>> xfreerdp can "solve" this problem?
>>
> 
> The license filename hash is generated from local hostname if not
> specified by the -n <hostnam> argument to rdesktop.
> 
> I can't reproduce your problem and I have not found any oddities in the
> code regarding the license filename generation. Could you add a debug
> print in load_license() and save_license() of g_hostname to verify that
> its same while loading/storing ?
> 
> 
> Kind Regards,
> 
> Henrik Andersson
>