#161 drag-and-drop caused core dump

[Bernd Senf]

---

Problem:
I'm running rdesktop from unix (both x86 and sparc) and windows server 2003,2008.
On windows explorer I want select many files. I case of moving this files at the very first moment "rdesktop" crashed with core dump.

Debugging with ddd shows:

#0  0x00020c74 in ui_create_cursor (x=10, y=10, width=32, height=32,   andmask=0x256f23
"ÿÿÿÿÿÿÏÿÿÿ\207ÿÿÿ\207ÿÿÿ\017ÿÿß\017ÿÿÎ\037ÿÿÆ\037ÿÿÀ?ÿÿÀ?ÿÿÀ\003ÿÿÀ\aÿÿÀ\017ÿÿÀ\037ÿÿÀ?ÿÿÀ\177ÿÿÀÿÿÿÁÿÿÿÃÿÿÿÇÿÿÿÏÿÿÿß", 'ÿ' <repeats 42 times>,
"K", xormask=0x256723 "", bpp=16)
at xwin.c:2874

0x00020c74 in ui_create_cursor (x=10, y=10, width=32, height=32, andmask=0x256f23
 case 16:
     s16 = (uint16 *) xormask;
     SPLITCOLOUR16(s16[*k], pc);   <==== here
     rv = (pc.red << 16) | (pc.green << 8) | pc.blue;
     (*k) += 1;
     break;

I guest it can't create the drag-icon;

Workaround:

my workaround (our colordepth == 16)

./rdesktop-1.8.1 -g 1100x900 -k de windowsserver <= crash
./rdesktop-1.8.1 -g 1100x900 -k de -a 16 windowsserver <= crash
./rdesktop-1.8.1 -g 1100x900 -k de -a 32 windowsserver <= no crash
./rdesktop-1.8.1 -g 1100x900 -k de -a 24 windowsserver <= no crash

that means, i start rdesktop with a wrong option and it works

---

I found out, that this functionality was changed since rdesktop-1.5;

-> It never crashed with 1.5.0;
-> It crashed in 1.6.0 , 1.8.0 , 1.8.1

My stupid workaround ( ~ xwindow.c:83):

-int g_server_depth = -1;
+int g_server_depth = 24;

Any hint ?