#385 rdesktop 1.8.2 segmentation fault when receive server redirection PDU without PDU_REDIRECT_HAS_IP

[leeyiw]

when rdesktop 1.8.2 received a Server Redirection PDU and the redirect flags doesn't contain flag PDU_REDIRECT_HAS_IP(value 0x00000001, called LB_TARGET_NET_ADDRESS in RDP protocol). it will cause a segmentation fault because g_redirect_server was freed and set to NULL.

I'm pretty sure when mstsc.exe receive the Server Redirection PDU as I described before, it will reconnect to the server which it connect to first time.

I think rdesktop should behave the same way, and I upload a simple patch for this.

[Henrik Andersson]

Oh, I never realized that this was making rdesktop segfault. How does your setup look like ?, is this issue produced using a RDS gateway to a farm or just a nat'ed single server ?

The spec talks about redirection that just is informational and shouldn't actually perform a disconnect/connect, this packet you receive might be such a packet.

[leeyiw]

I received this packet from a NAT'ed single server. and I don't understand why you think this redirection packet is just informational.