#384 1.8.2 "Windows logo key" has stopped working

[PepeN]

I am testing version 1.8.2, and noticed the that the button "Windows logo key" has stopped working.
In 1.8.1 - no problem

============ 1.8.2 ============
No input context, using XLookupString
KeyPress for keysym (0xffeb, Super_L)
Before updating modifier_state:0x0, pressed=0x1
After updating modifier_state:0x80
Sending extended scancode=0x5b, flags=0x0

KeyRelease for keysym (0xffeb, Super_L)
Before updating modifier_state:0x80, pressed=0x0
After updating modifier_state:0x0
============

============ 1.8.1 ============
No input context, using XLookupString
KeyPress for keysym (0xffeb, Super_L)
Before updating modifier_state:0x0, pressed=0x1
After updating modifier_state:0x80
Sending extended scancode=0x5b, flags=0x0

KeyRelease for keysym (0xffeb, Super_L)
Before updating modifier_state:0x80, pressed=0x0
After updating modifier_state:0x0
Sending extended scancode=0x5b, flags=0xc000
============

[Henrik Andersson]

I can't reproduce this issue, tested rdesktop 1.8.2 aginst WinXP and 2012R2 where the Windows key worked as expected. In my case nothing differs in the keyboard debug output;

===
No input context, using XLookupString
KeyPress for keysym (0xffeb, Super_L)
Before updating modifier_state:0x0, pressed=0x1
After updating modifier_state:0x80
Sending extended scancode=0x5b, flags=0x0

KeyRelease for keysym (0xffeb, Super_L)
Before updating modifier_state:0x80, pressed=0x0
After updating modifier_state:0x0
Sending extended scancode=0x5b, flags=0xc000
===

In your 1.8.2 log, did you miss the last expected line 'Sending extended...' ?

Any special keymap used ?

/Henrik

[PepeN]

Yes one line missing.

===
No input context, using XLookupString
KeyPress for keysym (0xffeb, Super_L)
Before updating modifier_state:0x0, pressed=0x1
After updating modifier_state:0x80
Sending extended scancode=0x5b, flags=0x0

KeyRelease for keysym (0xffeb, Super_L)
Before updating modifier_state:0x80, pressed=0x0
After updating modifier_state:0x0
Sending extended scancode=0x5b, flags=0xc000
===
My system is Linux Mint 10 Julia.
tar -xf rdesktop-1.8.2.tar.gz
cd rdesktop-1.8.2
./configure --disable-credssp --disable-smartcard --with-x --without-ipv6 --with-debug-kbd

make

sudo make install

/usr/local/bin/rdesktop -g 1280x800 -b -a 16 10.12.112.7

When I press the Windows key Start Menu does not open. (Server Windows 2003 SP2 and 2008R2)

How can I provide more (debug) information?

[Henrik Andersson]

I did a retest of this issue and is able to reproduce, must have testing with wrong binary. This is really a strange issue, the scancode is actually sent to the server and if you test menu key which is alike it would bring up the menu.

I need to bisect what broke the win key usage, meanwhile you could use ctrl+esc :)

/Henrik

[Alexander Zakharov]

Done a manual bisect (thx subversion for lacking it). I'm sure that the problem was introduced in r1766 ( last good is r1765).
Patch is trivial ( just one line needs to be changed).
rdp.c:384 Add
flags |= RDP_LOGON_BLOB;
Just before
DEBUG_RDP5(("Sending RDP5-style Logon packet\n"));

Anyway, I've attached the patch for convinience.

[Henrik Andersson]

I now see why this happend, RDP_LOGON_BLOB flag was used for branching if password or cookie should be sent. I couldn't find why it was used and I got rid of it. Now the flag is correctly named and correctly used :) in commit 1816.

[leeyiw]

You can check this flag out in MS-RDPBCGR, this flag is actually called "INFO_ENABLEWINDOWSKEY", it seems only control if windows key is enabled.

[donguru]

Hi, I have same problem. Don't send windows key events.
Alt + number combinations also don't work ( alt + 64 = @)
I'll wait the fix. Thanks

update: Alt + number works with -N rdesktop parameter.