Menu
▾
▴
Re: [Rapideuphoria-develop] Nomenclature: Fwd: [Rapideuphoria-commits] euphoria: default: * add C_LONG_PTR for windows
|
From: Matt L. <mat...@gm...> - 2013-03-18 13:02:52
|
Yes. It's a stupid name. Take it up with Microsoft. :-) http://msdn.microsoft.com/en-us/library/cc230349.aspx As this is the sort of thing you find, I think it's valuable to stick to the native naming convention as possible, as that makes it easier for people to figure out how to wrap things. In the past, we didn't have duplication, and users needed to figure out which euphoria C type to use. If there's one with the exact name that they're seeing, then it's a lot easier. I don't think we should try to add every third party thing, but MS is worthy of special treatment in this respect, I think. On Mon, Mar 18, 2013 at 8:51 AM, Shawn Pringle <sha...@gm...> wrote: > > The constant name C_LONG_PTR immediately made me think of a long* in C. > Now, you mean is an signed integer whose size is a pointer. It's a bad > name. The 'LONG' in the term confuses the issue. Also all of this > abbreviating with PTR for POINTER makes it harder to remember which to > use. We already use C_POINTER as now we have identifiers with POINTER > and PTR, we should stick with one. Remember we all have editors that > auto complete. In the identifiers many have 'U' to denote that they are > unsigned. So lets change C_LONG_PTR to C_SPOINTER. > > > > -------- Original Message -------- > From: - Sun Mar 17 10:28:14 2013 > X-Mozilla-Status: 0005 > X-Mozilla-Status2: 00000000 > X-Mozilla-Keys: > Delivered-To: sha...@gm... > Received: by 10.50.114.99 with SMTP id jf3csp158372igb; Sat, 16 > Mar 2013 15:46:47 -0700 (PDT) > X-Received: by 10.224.220.211 with SMTP id > hz19mr11586824qab.49.1363474007411; Sat, 16 Mar 2013 15:46:47 > -0700 (PDT) > Return-Path: <rap...@li...> > Received: from lists.sourceforge.net (lists.sourceforge.net. > [216.34.181.88]) by mx.google.com with ESMTPS id > d67si13617684yhn.134.2013.03.16.15.46.46 (version=TLSv1 > cipher=RC4-SHA bits=128/128); Sat, 16 Mar 2013 15:46:47 -0700 (PDT) > Received-SPF: pass (google.com: domain of > rap...@li... designates > 216.34.181.88 as permitted sender) client-ip=216.34.181.88; > Authentication-Results: mx.google.com; spf=pass (google.com: > domain of rap...@li... designates > 216.34.181.88 as permitted sender) > smtp.mail=rap...@li... > Received: from localhost ([127.0.0.1] > helo=sfs-ml-2.v29.ch3.sourceforge.com) by > sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from > <rap...@li...>) id > 1UGzsD-000807-Co; Sat, 16 Mar 2013 22:46:45 +0000 > Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] > helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp > (Exim 4.76) (envelope-from <sc...@op...>) id 1UGzsB-0007yT-8H > for rap...@li...; Sat, 16 Mar 2013 > 22:46:43 +0000 > Received: from [64.120.145.14] (helo=openeuphoria.org) by > sog-mx-3.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id > 1UGzsA-0002JE-Ej for rap...@li...; Sat, > 16 Mar 2013 22:46:43 +0000 > Received: from [0.2.233.26] (unknown [127.0.0.1]) by openeuphoria.org > (Postfix) with ESMTP id 422791CC84E5 for > <rap...@li...>; Sat, 16 Mar 2013 18:46:37 > -0400 (EDT) > MIME-Version: 1.0 > Date: Sat, 16 Mar 2013 18:46:37 -0400 > From: sc...@op... > X-Hg-Notification: changeset 4799252e3ba5 > Message-Id: <hg.4799252e3ba5.1363473997.-1467248918@190746> > To: rap...@li... > X-Spam-Score: 4.0 (++++) > X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See > http://spamassassin.org/tag/ for more details. 1.0 RDNS_NONE Delivered > to internal network by a host with no rDNS 0.1 FROM_12LTRDOM > >From a 12-letter domain 2.9 TO_NO_BRKTS_NORDNS To: misformatted and > no rDNS > X-Headers-End: 1UGzsA-0002JE-Ej > Subject: [Rapideuphoria-commits] euphoria: default: * add C_LONG_PTR for > windows > X-BeenThere: rap...@li... > X-Mailman-Version: 2.1.9 > Precedence: list > List-Id: SVN commit logs <rapideuphoria-commits.lists.sourceforge.net> > List-Unsubscribe: > <https://lists.sourceforge.net/lists/listinfo/rapideuphoria-commits>, > <mailto:rap...@li...?subject=unsubscribe> > List-Archive: > <http://sourceforge.net/mailarchive/forum.php?forum_name=rapideuphoria-commits> > List-Post: <mailto:rap...@li...> > List-Help: > <mailto:rap...@li...?subject=help> > List-Subscribe: > <https://lists.sourceforge.net/lists/listinfo/rapideuphoria-commits>, > <mailto:rap...@li...?subject=subscribe> > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > Errors-To: rap...@li... > > changeset: 4799252e3ba5 in /home/euweb/scm/hg_repos/euphoria > branch: default > author: Matt Lewis > url: > http://scm.openeuphoria.org/hg/euphoria?cmd=changeset;node=4799252e3ba5 > description: > * add C_LONG_PTR for windows > * make C_HANDLE, C_HWND signed > > diffstat: > > include/std/dll.e | 20 +++++++++++++++----- > 1 files changed, 15 insertions(+), 5 deletions(-) > > diffs (39 lines): > > diff -r 424eebd38635 -r 4799252e3ba5 include/std/dll.e > --- a/include/std/dll.e Thu Mar 14 23:38:01 2013 -0300 > +++ b/include/std/dll.e Sat Mar 16 18:43:36 2013 -0400 > @@ -50,10 +50,22 @@ > C_SIZE_T = C_ULONG, > --** any valid pointer > C_POINTER = #03000001, > + --** longlong 64-bits > + C_LONGLONG = #03000002, > + $ > +ifdef BITS32 then > +public constant > + --** signed integer sizeof pointer > + C_LONG_PTR = C_LONG > +elsedef > +public constant > + C_LONG_PTR = C_LONGLONG > +end ifdef > +public constant > --** handle sizeof pointer > - C_HANDLE = C_POINTER, > + C_HANDLE = C_LONG_PTR, > --** hwnd sizeof pointer > - C_HWND = C_POINTER, > + C_HWND = C_LONG_PTR, > --** dword 32-bits > C_DWORD = C_UINT, > --** wparam sizeof pointer > @@ -67,9 +79,7 @@ > --** double 64-bits > C_DOUBLE = #03000008, > --** dwordlong 64-bits > - C_DWORDLONG = #03000002, > - --** longlong 64-bits > - C_LONGLONG = C_DWORDLONG, > + C_DWORDLONG = C_LONGLONG, > $ > > --**** > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Rapideuphoria-commits mailing list > Rap...@li... > https://lists.sourceforge.net/lists/listinfo/rapideuphoria-commits > > > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_mar > _______________________________________________ > Rapideuphoria-develop mailing list > Rap...@li... > https://lists.sourceforge.net/lists/listinfo/rapideuphoria-develop -- Matt Lewis |