rails-devel — List for discussion of Rails development

Re: [Rails-devel] Including CC art resources

[Edward S. R. <ed...@we...>]

The legal code for by-sa is more explicit about what attribution means. 

>From section 4(c):

"The credit required by this Section 4(c) may be implemented in any reasonable manner; provided, however, that in the case of a Adaptation or Collection, at a minimum such credit will appear, if a credit for all contributing authors of the Adaptation or Collection appears, then as part of these credits and in a manner at least as prominent as the credits for the other contributing authors." 

Full text here - http://creativecommons.org/licenses/by-sa/3.0/legalcode

Using artwork licensed with by-sa shouldn't effect anything else in rails - since rails is GPLed anyway, there's no issues around commercial/non-commercial work and since artwork is generally considered to be bundled and thus doesn't have issues with different licences. At least as far as I understand the issues thus far :)

Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Saturday, 11 February 2012 at 07:18, Frederick Weld wrote:

> There are a lot of art resources (icons,...) that could be included into rails.
> 
> But for me, the following is unclear:
> 
> (1) Is there a demand for this? (It may well increase of the size of rails.)
> 
> (2) How to deal with the CreativeCommons licences that such art
> resources would have been licenced under?
> Most commonly, there are two types of licences:
> - Attribution: http://creativecommons.org/licenses/by/3.0/
> - The web doesn't provide any conclusive statement whether
> putting an attribution txt within rails' main folder would be enough
> for this purpose
> - Or should the credits popups be amended for this purpose?
> - Attribution with ShareAlike: http://creativecommons.org/licenses/by-sa/3.0/
> - ShareAlike appears to be a no-go as we don't want to share
> rails under the CC licence (CC is even not intended for software)
> - But this would be a pity as most resources are by-sa and not only by
> 
> -- Frederick
> 
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing 
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li... (mailto:Rai...@li...)
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> 

[Rails-devel] Including CC art resources

[Frederick W. <fre...@go...>]

There are a lot of art resources (icons,...) that could be included into rails.

But for me, the following is unclear:

(1) Is there a demand for this? (It may well increase of the size of rails.)

(2) How to deal with the CreativeCommons licences that such art
resources would have been licenced under?
Most commonly, there are two types of licences:
- Attribution: http://creativecommons.org/licenses/by/3.0/
      - The web doesn't provide any conclusive statement whether
putting an attribution txt within rails' main folder would be enough
for this purpose
      - Or should the credits popups be amended for this purpose?
- Attribution with ShareAlike: http://creativecommons.org/licenses/by-sa/3.0/
      - ShareAlike appears to be a no-go as we don't want to share
rails under the CC licence (CC is even not intended for software)
      - But this would be a pity as most resources are by-sa and not only by

-- Frederick

Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.

[<Dr....@t-...>]

Hi Stefan, 

	Eriks new non Modal Dialogs for the StartroundWindow arent used in
the 1.6.x release. 

	Might it be possible that with the release of 1.6.x those changes got
omitted ? 

	Cause they fix the behaviour/bug Russel has been reporting. 

	I mistakenly used the master branch to come to the result of my
earlier emails. 

	The current master with the new non modal dialogs is fixing the
problem Russel has reported. 

	@Russel: Sorry, the bug is valid, but already fixed in development,
the fix needs to be pushed to a release. 

	The save file i send earlier should allow you to continue playing
though. 

	Regards,
Martin 

	Von: "Dr....@t-..." <Dr....@t-...> 

	An: "Development list for Rails: an 18xx game"
<rai...@li...>, "Russell J. Alphey"
<Ra...@Mt...> 

	Betreff: Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830. 

	Datum: Sat, 11 Feb 2012 00:11:17 +0100 

	Hi Russel, 

	Yes the save file is 1.6.2. i have to say this is interesting. Cause
Eric introduced the non modal dialogs and they do function as
intended. 

	Can somebody else reproduce Russels problem ? As i said i was able to
switch to the Main Window and save the game and on reloading the right
player was asked to set the price (which of course might be a lucky
case, cause that player was actually the owner of the B&O). 

	Regards, 

	Martin 

	Von: "Dr....@t-..." <Dr....@t-...> 

	An: "Development list for Rails: an 18xx game"
<rai...@li...>, "Russell J. Alphey"
<Ra...@Mt...> 

	Betreff: Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830. 

	Datum: Sat, 11 Feb 2012 00:07:10 +0100 

	Hi Russel, 

	on my system i could bring the Main Window into the foreground and
save the turn. 

	Find attached the save file with the dialog of Sime still active. 

	Are you sure you are using 1.6.x ? 

	Regards, 

	Martin 

	  Von: "Russell J. Alphey" <Ra...@Mt...>
 An: rai...@li...
 Betreff: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
 Datum: Wed, 08 Feb 2012 06:08:44 +0100

 Hello,

 We've just started up a game of 1830, and in my turn I'm trying to 
 buy the final Private.
 The moment I do, Rails is insisting on the next player setting the 
 price of the B&O, and I can't
 cancel that, or save the game, or anything other than shut Rails
down.

 Turn file attached.

 R.

Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.

[<Dr....@t-...>]

Hi Russel, 

	Yes the save file is 1.6.2. i have to say this is interesting. Cause
Eric introduced the non modal dialogs and they do function as
intended. 

	Can somebody else reproduce Russels problem ? As i said i was able to
switch to the Main Window and save the game and on reloading the right
player was asked to set the price (which of course might be a lucky
case, cause that player was actually the owner of the B&O). 

	Regards, 

	Martin 

	Von: "Dr....@t-..." <Dr....@t-...> 

	An: "Development list for Rails: an 18xx game"
<rai...@li...>, "Russell J. Alphey"
<Ra...@Mt...> 

	Betreff: Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830. 

	Datum: Sat, 11 Feb 2012 00:07:10 +0100 

	Hi Russel, 

	on my system i could bring the Main Window into the foreground and
save the turn. 

	Find attached the save file with the dialog of Sime still active. 

	Are you sure you are using 1.6.x ? 

	Regards, 

	Martin 

	  Von: "Russell J. Alphey" <Ra...@Mt...>
 An: rai...@li...
 Betreff: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
 Datum: Wed, 08 Feb 2012 06:08:44 +0100

 Hello,

 We've just started up a game of 1830, and in my turn I'm trying to 
 buy the final Private.
 The moment I do, Rails is insisting on the next player setting the 
 price of the B&O, and I can't
 cancel that, or save the game, or anything other than shut Rails
down.

 Turn file attached.

 R.

Re: [Rails-devel] Swing Docking Framework for Rails

[Frederick W. <fre...@go...>]

Master now contains further extensions that, though motivated by the
availability of the docking functionality, are also beneficial for the
conventional layout:
- Message Panel is capable of dynamic word wrapping (needed for
vertical panel layout)
- Remaining Tiles Window wraps the tiles according to the available
horizontal space and has a vertical scroll bar if needed

On top of that, the docking implementation now includes:
- marked some dockables (messages, tiles) as optional
   - their dockables have a close button
   - they can be closed / opened from the layout menu
- remaining tiles window becomes a docking pane (not visible by
default as before)

-- Frederick

Re: [Rails-devel] GUI testing (was Re: Bug fix: 1856 dit upgrade phases)

[Frederick W. <fre...@go...>]

Stefan:
Sounds good.
Then, the rails newbies will probably get the x.x.>0 release and the
rails-devel/announce followers the x.x.0 releases.

--Frederick.

Re: [Rails-devel] GUI testing (was Re: Bug fix: 1856 dit upgrade phases)

[Stefan F. <ste...@we...>]

Frederick:
the current release cycle makes the x.x.0 a kind of beta release already 
as this is the moment where program changes get exposed
to the users.

I do not like tagging (open source) releases as beta, as either they are 
releases or not. Open source/GPL software is run on your own risk anyway.

But I have an idea that might work in that direction: Sourceforge allows 
to tag the "latest version" manually and this is the offered default 
download. For a x.x.0 release this tag would not be applied and thus 
only users actively looking for the x.x.0 release would get that.

Are there any objections to this procedure?

Stefan


On 02/09/2012 06:34 PM, Frederick Weld wrote:
> Stefan:
> As an additional thought, we could change the release procedure such
> that major/minor releases (eg. 1.7.0) are tagged as beta at first. By
> doing so, we could close the gap between our current alpha testing and
> the release consumption by the end-users. I think we would have enough
> users that would be willing to use a beta release / report bugs but
> who fall short of setting up / maintaining a local git clone.
>
> What's your take on this?
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Release Rails 1.6.3 available

[Stefan F. <ste...@we...>]

Erik:
it seems that you forgot to push this fix.
In master the bug still occurs and I have not found
anything in the git logs.
Could you please double-check again?
Thanks,
Stefan

On 02/07/2012 11:03 PM, Erik Vos wrote:
> Fixed. No presidency check was done in start rounds, this has now been
> added.
>
> Erik.
>
>> -----Original Message-----
>> From: Schnell, Volker [mailto:vol...@ar...]
>> Sent: Tuesday, February 07, 2012 9:29 PM
>> To: rai...@li...
>> Subject: Re: [Rails-devel] Release Rails 1.6.3 available
>>
>> Hi Stefan,
>>
>> here is another bug with 1835.
>> In the SR round one player buys the Bay-director and another  the NF, OBB
>> and PB.
>> The player with the three privates must be the director of then Bayern.
>> rails did not hand over the director share. see attached example.
>> The new release has also the bug.
>>
>> Thanks
>>
>> Volker
>>
>>
>> --
>> Volker Schnell
>> email: vol...@ar...
>> homepage: home.arcor.de\volker_schnell
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] GUI testing (was Re: Bug fix: 1856 dit upgrade phases)

[Frederick W. <fre...@go...>]

Stefan:
As an additional thought, we could change the release procedure such
that major/minor releases (eg. 1.7.0) are tagged as beta at first. By
doing so, we could close the gap between our current alpha testing and
the release consumption by the end-users. I think we would have enough
users that would be willing to use a beta release / report bugs but
who fall short of setting up / maintaining a local git clone.

What's your take on this?

-- Frederick

Re: [Rails-devel] GUI testing (was Re: Bug fix: 1856 dit upgrade phases)

[Frederick W. <fre...@go...>]

Stefan:
Perhaps you are able to create a UI test automate when letting one of
these tools record the steps of your manual release tests?
For my part, I don't have any knowledge of UI test automates for Java.
But from my professional experience, I would advise to only build UI
automates once the right (eg., layout agnostic) technology is
available _and_ the tradeoff between finding regressions and the
effort (creating and, especially, maintaining/adjusting the automates)
is right.

-- Frederick

[Rails-devel] GUI testing (was Re: Bug fix: 1856 dit upgrade phases)

[Stefan F. <ste...@we...>]

>
> I would advocate against building UI units (as regression tests) right
> now because
> - units would have to be adjusted too frequently (UIs are currently
> altered far more frequently than the game engine)
> - the number of regressions has been very low
> - additional technology is required to do UI units right
> - UI units wouldn't have helped with javac/jvm issues as those
> reported in this thread
>
Frederick:
one could argue about the ratios between regressions and frequency of 
changes in the UI and you are right that the recent bug would not have 
been catched, however that was not the reason for me to bring up the 
topic: The GUI is not yet covered by any test, so it has marginal gain 
is largest here to add tests there. And for each release I do some 
manual testing (e.g. if Rails still starts and allows to finish an 
auction and load a game). This is the only manual task in the release 
process and I would be glad to automate that as well.

Have you any experience in the choice of a Java/Swing ui framework? I 
have only limited experience with Mercury testing (from my professional 
past), but there should be much more focused/integrated open source 
tools. Maybe Brett has some recommendations too?

What I have seen recently was Cucumber's approach, but most likely that 
is an overkill, but I am curious about it, especially as it seems to be 
(in all respects) language-agnostic.

Stefan

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Frederick W. <fre...@go...>]

Stefan:

> At some point in time we should consider which of the many UI
> changes you did (and most of them I like) should be made the default
> option.

I leave this to the rails-devel community or the release manager since
my judgement would be too subjective. (I use all of the new
options...)
Putting new functionality to off by default is my standard way of
adding features to rails that I would like but others potentially
would not.

> Have you thought about automatically UI testing

I would advocate against building UI units (as regression tests) right
now because
- units would have to be adjusted too frequently (UIs are currently
altered far more frequently than the game engine)
- the number of regressions has been very low
- additional technology is required to do UI units right
- UI units wouldn't have helped with javac/jvm issues as those
reported in this thread

What is true is that the increasing level of UI variability (added
options) hurts our ability to achieve sufficient code coverage by
manual testing. But this would be alleviated if aforementioned point
(about including new UI options as default) is agreed upon.

-- Frederick

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Stefan F. <ste...@we...>]

Frederick:
thanks I thought that the 1.6.x branch was effected too.

At some point in time we should consider which of the many UI
changes you did (and most of them I like) should be made the default 
option. Otherwise they will be lost for most players as no one will 
actually turn them on. This also implies that they do not get really tested.

Additionally this again highlights the problem that there is no 
automatic testing of the UI part of Rails. Have you thought about 
automatically UI testing, this would really be helpful for changing the 
UI and even more important to check if the UI and game engine still
cooperate as they should.

Stefan

PS: Have not pushed the tile fix yet to master, will do so soon.


On 02/08/2012 05:48 PM, Frederick Weld wrote:
> Bill:
> Thanks for the additional information.
> It appears that, on your local machine, JSpinner gets a null border by
> default (whereas it gets a non-null border on other machines) - very
> weird.
> Master should now be able to cope with that.
>
> Stefan:
> No need for a hotfix because the lack of robustness only applies to master/1.7.
> btw: Have you pushed bill's tile fix to master yet?
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Swing Docking Framework for Rails

[Frederick W. <fre...@go...>]

I've come to the conclusion to add that "Reset Layout" command into
the newly created menu of the ORWindow (I couldn't add it to the OR
Panel's menu as the user might not be able to see the OR Panel when he
wants to reset).

On top of this, I've added some round-offs:
- Added option to select from various dockingFrames rendering themes
    - also part of layout persistence
- Existing layouts can be picked as templates
- Added logging / file-access error popups
- Incorporated OR Panel's menu bar into OR Window's newly created one
    - would have been odd to place the menu bar under the "Companies" dockable

-- Frederick

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Bill R. <ro...@gm...>]

On 2012-02-09, at 0:48 , Frederick Weld wrote:

> Bill:
> Thanks for the additional information.
> It appears that, on your local machine, JSpinner gets a null border by
> default (whereas it gets a non-null border on other machines) - very
> weird.
> Master should now be able to cope with that.

Frederick:

Thanks for the fix, master now works as expected on my machine.

Bill

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Frederick W. <fre...@go...>]

Bill:
Thanks for the additional information.
It appears that, on your local machine, JSpinner gets a null border by
default (whereas it gets a non-null border on other machines) - very
weird.
Master should now be able to cope with that.

Stefan:
No need for a hotfix because the lack of robustness only applies to master/1.7.
btw: Have you pushed bill's tile fix to master yet?

-- Frederick

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Stefan F. <ste...@we...>]

Bill & Frederick,
on my system the error does not occur. Neither with the attached file, 
nor any other save file and not after creating a new game.
I even setup a new default configuration profile that should be 
identical to the on that Bill uses (or do you have any changes to your 
configuration active?).

However I believe the error is real and most likely the fix below seems 
to be reasonable, so if Frederick confirms that it has no side-effects I 
would release 1.6.4 hot-fix with that and the 1835 bug adressed.

Stefan



>
> Frederik and Stefan,
>
> I am still seeing the problem.  Looking at it in the debugger, when the exception is thrown it is not because getBorderInsets returns null, it is because innerBorder (and thus nativeInnerBorder) is null.
>
> Digging further, this happens when GridPanel.addField is called to add a Spinner, which has a null border, and so passes in a null value to the constructor.
>
> I can make this problem go away by adding the following test to the FieldBorder constructor, just above line 257 where I get the exception:
>
> if (innerBorder == null) return;
>
> Once I do this, the interface works as expected, but I do not know what side effects are likely to occur as a result.
>
> I've attached a savegame, but as far as I can tell the problem is completely generic.  This happens when I create new games and when I load existing games.
>
> Bill
>
>
>
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.

[Phil D. <de...@gm...>]

It just asks that someone set the price, since by the game rules that
must be done as soon as the private is bought.  Simply ask the player
who gets the B&O what price they want and set it yourself, once that's
done you can save it for their turn.  Playing PBEM over Dropbox
frequently requires a bit of back and forth communication between
players to make the game play smoothly

On 8 February 2012 05:08, Russell J. Alphey <Ra...@mt...> wrote:
> Hello,
>
> We've just started up a game of 1830, and in my turn I'm trying to buy the
> final Private.
> The moment I do, Rails is insisting on the next player setting the price of
> the B&O, and I can't
> cancel that, or save the game, or anything other than shut Rails down.
>
> Turn file attached.
>
> R.
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.

[Erik V. <eri...@xs...>]

Russell,

For the time being, I can only advise to work with that next player to set
the price correctly.
Rails via Dropbox is still kind of experimental, and no doubt there are
several more cases of such player-turn mismatches. 

Not sure if anyone else want to dig into this issue, otherwise I will do so,
but that will then happen next week earliest.

Erik.

> -----Original Message-----
> From: Russell J. Alphey [mailto:Ra...@Mt...]
> Sent: Wednesday, February 08, 2012 6:09 AM
> To: rai...@li...
> Subject: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
> 
> Hello,
> 
> We've just started up a game of 1830, and in my turn I'm trying to buy the
> final Private.
> The moment I do, Rails is insisting on the next player setting the price
of the
> B&O, and I can't cancel that, or save the game, or anything other than
shut
> Rails down.
> 
> Turn file attached.
> 
> R.

[Rails-devel] Bug in 1.6.2, buying final Private in 1830.

[Russell J. A. <Ra...@Mt...>]

Hello,

We've just started up a game of 1830, and in my turn I'm trying to 
buy the final Private.
The moment I do, Rails is insisting on the next player setting the 
price of the B&O, and I can't
cancel that, or save the game, or anything other than shut Rails down.

Turn file attached.

R.

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Bill R. <ro...@gm...>]

On 2012-02-08, at 0:45 , Frederick Weld wrote:

> Bill:
> Thanks for the details.
> Unfortunately, I wasn't able to reproduce the exception, even when
> disabling the grid table layout option.
> But the details you provided were enough to identify the symptom
> (getBorderInsets returns null on the field to be added). Now, the
> GridPanel should be robust enough to handle that.
> 
> The problem is that this perhaps does not really help you as you
> reported that the OR window didn't proceed to OR 1.1. I can't tell why
> this is the case unless being able to reproduce the issue...
> 
> Would you mind checking what happens now on your local installation?
> 
> --Frederick

Frederik and Stefan,

I am still seeing the problem.  Looking at it in the debugger, when the exception is thrown it is not because getBorderInsets returns null, it is because innerBorder (and thus nativeInnerBorder) is null.

Digging further, this happens when GridPanel.addField is called to add a Spinner, which has a null border, and so passes in a null value to the constructor.

I can make this problem go away by adding the following test to the FieldBorder constructor, just above line 257 where I get the exception:

if (innerBorder == null) return;
           
Once I do this, the interface works as expected, but I do not know what side effects are likely to occur as a result.

I've attached a savegame, but as far as I can tell the problem is completely generic.  This happens when I create new games and when I load existing games.

Bill

Re: [Rails-devel] Release Rails 1.6.3 available

[Erik V. <eri...@xs...>]

Fixed. No presidency check was done in start rounds, this has now been
added.

Erik.

> -----Original Message-----
> From: Schnell, Volker [mailto:vol...@ar...]
> Sent: Tuesday, February 07, 2012 9:29 PM
> To: rai...@li...
> Subject: Re: [Rails-devel] Release Rails 1.6.3 available
> 
> Hi Stefan,
> 
> here is another bug with 1835.
> In the SR round one player buys the Bay-director and another  the NF, OBB
> and PB.
> The player with the three privates must be the director of then Bayern.
> rails did not hand over the director share. see attached example.
> The new release has also the bug.
> 
> Thanks
> 
> Volker
> 
> 
> --
> Volker Schnell
> email: vol...@ar...
> homepage: home.arcor.de\volker_schnell

Re: [Rails-devel] Release Rails 1.6.3 available

[Schnell, V. <vol...@ar...>]

Hi Stefan,

here is another bug with 1835.
In the SR round one player buys the Bay-director and another  the NF, 
OBB and PB.
The player with the three privates must be the director of then Bayern.
rails did not hand over the director share. see attached example.
The new release has also the bug.

Thanks

Volker


-- 
Volker Schnell
email: vol...@ar...
homepage: home.arcor.de\volker_schnell

[Rails-devel] Rails2.0 : Added PortfolioNG and Wallet classes

[Stefan F. <ste...@we...>]

All:
further update about the progress on Rails2.0 (if anyone follows that 
already). This update added new Portfolio and Wallet classes which are 
based on the general State class.

Overall Status:
The state package should now be close to feature complete, however
expect frequent updates and fixes.
The model package now contains a lot of classes and interfaces 
(everything around Owner...) which will be removed eventually.

Next step is removing remaining errors and bugs.
After this the Context/Item setup will be implemented throughout Rails.

Stefan


More details:
As I was not convinced by my previous refactoring of the Portfolio and 
Ownership approach, I did a fresh start there. For this I decided to 
create a basic Portfolio class that is a first class child of State.

It is currently called PortfolioNG, however will be renamed to Portfolio 
later on. It allows storing of OwnableItem(s) and is basically a thin 
wrapper around an ArrayListMultimap. However it ensures that adding to a 
portfolio always remove the item from its previous portfolio. The map 
keys have to implement the new Interface ItemType.

An example with Train objects will make this clear:

A portfolio will be defined as
Portfolio<Train> portfolio = Portfolio.create("Trains");

Then a train object train can be moved into that portfolio using

portfolio.moveInto(train);

and will be automatically removed from the previous owning
portfolio.

For trains the TrainType will be the key that is used in the portfolio 
so one can use

portfolio.getItems(trainType);

to retrieve all trains from the portfolio that belong to the specified 
trainType.

In parallel there is a Wallet class which is another subclass of State
which can store CountableItem(s). Again this is a thin wrapper this time 
around HashMultiset.

This works with a similar syntax, but it allows to store resources that 
comes in (integer) multiples, e.g. money. In principle it could also be 
used (in the longer run) for all objects (shares, tiles and even 
trains), where the individual items only differ in respect with to the 
owner.

For reference for the Collection types discussed above please refer to 
the collections of the Guava library (aka Google Collections).
See 
http://code.google.com/p/guava-libraries/wiki/NewCollectionTypesExplained

Re: [Rails-devel] Bug fix: 1856 dit upgrade phases

[Stefan F. <ste...@we...>]

Bill:
I tried to recreate the error too, but this was not possible for me either.
Could you please provide a game file, which is stored just before this 
occurs (or even at the time of error, if saving is still possible).
Two weeks ago I got the same behavior reported by friends playing a 
face-to-face game, however no save file received for that occasion too.
Thanks,
Stefan


On 02/07/2012 05:45 PM, Frederick Weld wrote:
> Bill:
> Thanks for the details.
> Unfortunately, I wasn't able to reproduce the exception, even when
> disabling the grid table layout option.
> But the details you provided were enough to identify the symptom
> (getBorderInsets returns null on the field to be added). Now, the
> GridPanel should be robust enough to handle that.
>
> The problem is that this perhaps does not really help you as you
> reported that the OR window didn't proceed to OR 1.1. I can't tell why
> this is the case unless being able to reproduce the issue...
>
> Would you mind checking what happens now on your local installation?
>
> --Frederick
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel