rails-devel — List for discussion of Rails development

Re: [Rails-devel] Rails configuration profiles (was: Planned Release 1.7.0)

[Frederick W. <fre...@go...>]

Stefan:
I do not perceive adding defaults to a schema as mixing schema/data
definition. Defining defaults is actually a common part of schema
definition (see XMLSchema).
But I don't argue to change the current setup as it is already well established.

==>All config changes I initiated are now part of the default property
file - I will also maintain that file when adding new options in the
future.

-- Frederick

[Rails-devel] Game Initialization within the EDT / AWT EventQueue

[Frederick W. <fre...@go...>]

In RunGame, I've found the following comment:
"We have to run loadGame on an AWT EventQueue to make sure that NDC
will properly initialize game key so that GameManager instance can be
properly queried for. This is a consequence of NDC abuse."

New games are also initialized within EDT since this is triggered by
the button pressed event.

So my question to Erik/Stefan/Brett:
What is the goal of (ab)using the EDT? Is it that only one game may be
started at the same time?

-- Frederick

[Rails-devel] Rails configuration profiles (was: Planned Release 1.7.0)

[Stefan F. <ste...@we...>]

Frederick:

there is already a 2-tier structure in place: The user settings
are only stored as delta to the selected pre-defined profile.
As there is only one pre-defined profile (the "default" profile) it
is not that obvious now.

The 3rd tier would only make our life easier as it allows to
define the other (predefined) profiles as delta one pre-defined profile.
So adding new options would only require the change of one file instead
of a number equal to the number of pre-defined profiles.

It was obvious now that you had not figure out the existing of a default 
profile as you did not add your new options to that file.
It is the file "default.profile" inside folder data.profiles.
The filetype is a java property file which allows easy loading.
If you prefer we can store it as a xml-file as java allows that too (see 
loadFromXML and storeToXML methods of the java.util.Properties class). 
Currently you rely on the setting for missing values for each option, 
which is not a defined behavior and might change after refactoring.

I did not want to add the defaults to Properties.xml inside the data 
folder following the principle from separating structure definition and 
data. In addition it is much easier to load the data from a property 
file (especially Properties supports a hierarchy approach).

Again I took the opportunity to copy the content of a previous e-mail 
message into the wiki:
http://sourceforge.net/apps/mediawiki/rails/index.php?title=Rails_configuration

Stefan


On 02/14/2012 07:33 AM, Frederick Weld wrote:
> Stefan:
> The suggested settings are fine.
>
> Regarding 3-tier:
> The 3-tier proposal is interesting. But I'm not sure that the end
> users will understand how the tiers work.
>
> Regarding the default profile:
> I wasn't aware that there is a default profile (do you mean
> my.properties?). Perhaps, a better approach would be to put the
> default values into properties.xml (adding attribute "default") so
> that we can ensure that property set and property defaulting always
> stay in synch. But in the short term (for 1.7.0), we could leave the
> repos as it is as the new functionality defaults the on/off options to
> off by default.
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Keep Your Developer Skills Current with LearnDevNow!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-d2d
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Release Rails 1.6.3 available

[Erik V. <eri...@xs...>]

> > However the existing 1835 and a new test case I have added
> > fail now. This is most likely related to the Clemens variant change of
> > player priority and rerunning several 1835 in one instance, however
> > this usually indicates some probability that it is not undo-proof.
> >
> > So let us wait for you coming back to solve this jointly.
> 
> I haven't looked at the non-standard 1835 variants for a long time, so
it's
> good to have a test case now.
> I only see 1835_NatDoubleShare failing, all other cases are OK.  Do you
have
> more failures?

I don't understand why JUnit does things different from normal running.

The report expects:

BuysItemFor,T3,M5,80
FloatsWithCash,M5,80
BuysItemFor,T2,M1,80  <===
FloatsWithCash,M1,80
BuysItemFor,T1,M3,80
FloatsWithCash,M3,80

and that is exactly what happens in a normal run (extract from log):

2012-02-14 21:08:25 INFO   T3 buys M5 for 80M  (ReportBuffer addMessage 186)

2012-02-14 21:08:25 INFO   M5 floats and receives 80M  (ReportBuffer
addMessage 186) 
2012-02-14 21:08:25 INFO   T2 buys M1 for 80M  (ReportBuffer addMessage 186)
<===
2012-02-14 21:08:25 INFO   M1 floats and receives 80M  (ReportBuffer
addMessage 186) 
2012-02-14 21:08:25 INFO   T1 buys M3 for 80M  (ReportBuffer addMessage 186)

2012-02-14 21:08:25 INFO   M3 floats and receives 80M  (ReportBuffer
addMessage 186) 

so I'm amazed that the JUnit report says that >>T1<< has bought M3 in its
test run.

junit.framework.ComparisonFailure: Reports differ in line 13
expected:<BuysItemFor,T[2],M1,80> but was:<BuysItemFor,T[1],M1,80>

where line 13 corresponds to the lines where I added arrows.

I'm lost.

Erik.

Re: [Rails-devel] Including CC art resources

[Frederick W. <fre...@go...>]

Stefan:
... which proves that we don't run the same OS... Thanks!

-- Frederick

Re: [Rails-devel] Planned Release 1.7.0

[Frederick W. <fre...@go...>]

Stefan:
The suggested settings are fine.

Regarding 3-tier:
The 3-tier proposal is interesting. But I'm not sure that the end
users will understand how the tiers work.

Regarding the default profile:
I wasn't aware that there is a default profile (do you mean
my.properties?). Perhaps, a better approach would be to put the
default values into properties.xml (adding attribute "default") so
that we can ensure that property set and property defaulting always
stay in synch. But in the short term (for 1.7.0), we could leave the
repos as it is as the new functionality defaults the on/off options to
off by default.

-- Frederick

Re: [Rails-devel] Release Rails 1.6.3 available

[Erik V. <eri...@xs...>]

> enjoy your stay in Rome: Hopefully it was/is not as cold as everywhere
else
> here in Europe?

Around freezing point, which is cold for Rome. It snowed a little, which
made the mayor panic and close all municipal musea (and schools and
offices), so we had to change plans.
The good side was that all those Vespa's weren't allowed to ride at all.
The worst was that the last two days the hotel heating was broken down.  The
cause seemed to be that the gas company had added some stuff to prevent the
gas to freeze (or so I understood from the apology that the hotel sent me by
mail in very bad English).

Anyway, I'm back at home now.

> Thanks for the info: It was my mistake (again) in using git cli and
eclipse
> together. However the existing 1835 and a new test case I have added fail
> now. This is most likely related to the Clemens variant change of player
> priority and rerunning several 1835 in one instance, however this usually
> indicates some probability that it is not undo-proof.
> 
> So let us wait for you coming back to solve this jointly.

I haven't looked at the non-standard 1835 variants for a long time, so it's
good to have a test case now.  
I only see 1835_NatDoubleShare failing, all other cases are OK.  Do you have
more failures?

I'll have a closer look later.

Erik.

Re: [Rails-devel] Release Rails 1.6.3 available

[Stefan F. <ste...@we...>]

Erik:
enjoy your stay in Rome: Hopefully it was/is not as cold as everywhere 
else here in Europe?

Thanks for the info: It was my mistake (again) in using git cli and 
eclipse together. However the existing 1835 and a new test case I have 
added fail now. This is most likely related to the Clemens variant 
change of player priority and rerunning several 1835 in one instance, 
however this usually indicates some probability that it is not undo-proof.

So let us wait for you coming back to solve this jointly.

Stefan


On 02/11/2012 10:31 PM, Erik Vos wrote:
> Sorry guys, I'm visiting Rome with my wife, which makes me a bit slow in
> checking email.
>
> It's commit c60ac2a4 "Fix for 1835 bug: BY presidency not transferred
> during start round.", which is in origin/master, so it must exist in the
> repo.
> And git tells me I have nothing to push. On my side the bug appears to be
> fixed.
>
> This commit adds a new statement in StartRound.java line 303:
>    if (comp.hasStarted()) comp.checkPresidency();  // Needed for 1835 BY
>
> I hope this helps...
>
> Erik.
>
>
>> Erik:
>> it seems that you forgot to push this fix.
>> In master the bug still occurs and I have not found
>> anything in the git logs.
>> Could you please double-check again?
>> Thanks,
>> Stefan
>>
>> On 02/07/2012 11:03 PM, Erik Vos wrote:
>>> Fixed. No presidency check was done in start rounds, this has now been
>>> added.
>
>
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Planned Release 1.7.0

[Stefan F. <ste...@we...>]

Frederick:

this are my suggested settings for a PrettyUI.profile:

button.iconPosition=left
button.iconText=text and icon
button.iconSize=small
gridPanel.tableBorders=enabled
map.image.display=yes
map.displayCurrentRoutes=yes
map.highlightHexes=yes

(A zoom option is not included - opinion on that?)

and for ORDocking.profile:

or.window.dockablePanels=yes

(Docking should be evaluated orthogonal to all other UI options.)

I realized that the new options are not added to default.profile yet, 
this is something still to be done. Everything else identical to
default.profile.

One thing that will be annoying is that every new option has to be added
to the all of pre-configured profiles.

An alternative is to have a three-tier property structure for the 
configuration (default / preconfigured / user-adjustment).

I will delay release 1.7.0 until I have your opinion on the settings above.

Stefan


On 02/12/2012 07:33 AM, Frederick Weld wrote:
> Stefan:
> The icons could be included into both options if there is a
> confirmation that this new functionality is also running on another
> machine.
> I think your manual pre-release click-through would be enough for this purpose.
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Including CC art resources

[Stefan F. <ste...@we...>]

Frederick:
icon works fine.
I fixed the type in the filename of train.png.

Stefan


On 02/12/2012 07:37 AM, Frederick Weld wrote:
> New in master: Extended the scope of the icon functionality to
> - upgrade panel buttons
> - non-modal dialog buttons (but not for modal dialogs)
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Swing Docking Framework for Rails

[Frederick W. <fre...@go...>]

Further update on dockable layout:
Upgrade panel buttons (lay tile/token, no tile/token) have been moved
to the ORPanel button panel.
Now, there is one central place where the OR command buttons are to be
found (ie., the Commands dockable).
Only applies to dockable layout as, only there, the button panel's
size is flexible.

-- Frederick

Re: [Rails-devel] Including CC art resources

[Frederick W. <fre...@go...>]

New in master: Extended the scope of the icon functionality to
- upgrade panel buttons
- non-modal dialog buttons (but not for modal dialogs)

-- Frederick

Re: [Rails-devel] Planned Release 1.7.0

[Frederick W. <fre...@go...>]

Stefan:
The icons could be included into both options if there is a
confirmation that this new functionality is also running on another
machine.
I think your manual pre-release click-through would be enough for this purpose.

-- Frederick

Re: [Rails-devel] Planned Release 1.7.0

[Stefan F. <ste...@we...>]

Frederick,
=> Network Info: ok I understand.

=> UI profiles:
Most likely create two profiles:
* New UI options
* New UI options + docking

Do you consider the new Icons as experimental so far or would you 
include them under the second or both options above?

Actually I have not neither tested icons nor reset buttons, but
I want the actual users convinced not me as (currently mainly) developer.

Stefan


On 02/11/2012 07:44 PM, Frederick Weld wrote:
> Stefan:
> The simulation functionality is only availability in dev mode
> (@DEVELOP@). Otherwise, the user is only notified of the potential
> revenue (plus the train routes redraw if this is not the current
> company).
>
> You may add the following to the list (under UI options) if the new
> icon functionality is to be released, too:
>     - Appearance / Button display type: Allows for icons on action buttons
>     - Appearance / Icon size
>
>> If time permits I will add a predefined configuration which has all your
>> options enabled.
> So you want to propose the use of the docking functionality to the users?
> This would be the one option for which I'm not 100 percent sure
> whether it's the right decision to set as default right now - or have
> you been convinced by the "reset" and the "apply from..." menu option?
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Including CC art resources

[John A. T. <ja...@ja...>]

On Sat, Feb 11, 2012 at 1:42 PM, Frederick Weld <
fre...@go...> wrote:

> Master now contains an icon set for the action buttons and dockables.
> Note the following:
>
> - Built a framework for accessing icons and applied it for
> ActionButton and Dockables
>   - expanded RailsIcon and ActionButton
>   - ActionButton: construction, setText not based on label text but
> on RailsIcon enum instance
>   - Added two options (display text/icon/both and small/large icons)
>   - Icons can also be associated to dockable panels
>
> - Added icon sets
>   - Found some BY licensed icons for this purpose
>   - Expanded the credits section according to Edward's comment
> (thanks for the information/confirmation!)


I am not a lawyer, but I believe it is perfectly fine to use SA-BY content
in Rails.  The credit needs to go where other creates are (as Edward
suggested), and share-alike means we have to make the image available
(especially with any modifications, if we are just reusing it we can
probably get away with a URL where someone can get it), with any
modifications licensed the same way.

-- 
John A. Tamplin

Re: [Rails-devel] Release Rails 1.6.3 available

[Erik V. <vo...@xs...>]

Sorry guys, I'm visiting Rome with my wife, which makes me a bit slow in
checking email.

It's commit c60ac2a4 "Fix for 1835 bug: BY presidency not transferred
during start round.", which is in origin/master, so it must exist in the
repo.
And git tells me I have nothing to push. On my side the bug appears to be
fixed.

This commit adds a new statement in StartRound.java line 303:
  if (comp.hasStarted()) comp.checkPresidency();  // Needed for 1835 BY

I hope this helps...

Erik.


> Erik:
> it seems that you forgot to push this fix.
> In master the bug still occurs and I have not found
> anything in the git logs.
> Could you please double-check again?
> Thanks,
> Stefan
>
> On 02/07/2012 11:03 PM, Erik Vos wrote:
>> Fixed. No presidency check was done in start rounds, this has now been
>> added.

Re: [Rails-devel] Planned Release 1.7.0

[Frederick W. <fre...@go...>]

Stefan:
The simulation functionality is only availability in dev mode
(@DEVELOP@). Otherwise, the user is only notified of the potential
revenue (plus the train routes redraw if this is not the current
company).

You may add the following to the list (under UI options) if the new
icon functionality is to be released, too:
   - Appearance / Button display type: Allows for icons on action buttons
   - Appearance / Icon size

> If time permits I will add a predefined configuration which has all your
> options enabled.
So you want to propose the use of the docking functionality to the users?
This would be the one option for which I'm not 100 percent sure
whether it's the right decision to set as default right now - or have
you been convinced by the "reset" and the "apply from..." menu option?

-- Frederick

Re: [Rails-devel] Including CC art resources

[Frederick W. <fre...@go...>]

Master now contains an icon set for the action buttons and dockables.
Note the following:

- Built a framework for accessing icons and applied it for
ActionButton and Dockables
   - expanded RailsIcon and ActionButton
   - ActionButton: construction, setText not based on label text but
on RailsIcon enum instance
   - Added two options (display text/icon/both and small/large icons)
   - Icons can also be associated to dockable panels

- Added icon sets
   - Found some BY licensed icons for this purpose
   - Expanded the credits section according to Edward's comment
(thanks for the information/confirmation!)

-- Frederick

Re: [Rails-devel] Planned Release 1.7.0

[Stefan F. <ste...@we...>]

Frederick:
thanks a lot for your list:
You have added a lot of sweet sugar to the UI.

If time permits I will add a predefined configuration which has all your 
options enabled.

One thing that strikes me that it is now so easy to (by clicking on the
company logo) to initiate the revenue output which was mainly intended
to be a testing tool. I would prefer a behavior which only displays the 
current routes (and/or displays the current revenue value) and does not 
allow to add trains (especially not trains which are not available in
that specific game).

Stefan


On 02/11/2012 02:44 PM, Frederick Weld wrote:
> Stefan:
> This is a condensed list (omitting minor roundoffs/improvements):
>
> - General UI improvements:
>      - Interactive highlighting of hexes
>      - Enhanced highlighting of active table cells during Operating Round
>      - Adaptive rendering of token labels
>      - Lay Tile: Invalid tile lays are displayed (incl. the reason for
> not being valid)
>
> - Added UI options:
>      - Map / Zoom Fit Option: Fit-to-window and more
>      - Map / Display Routes of Active Company
>      - Map / Highlight company locations
>      - Appearance / Display borders in grid layout
>      - Windows / Flexible panels for operating round: Applies a docking
> framework to Operating Round Window
>
> - Added Music/Sound Effects options (mp3 only):
>      - Music: Background music can be specified per round-type and phase
>      - Sound Effects: Sound effects can be associated to more than 20 game events
>          - Includes support of "intelligent" effects (eg., revenue
> sound as in RailroadTycoon1)
>      - No music/sound files are provided by rails
>
> -- Frederick
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[Stefan F. <ste...@we...>]

Hi Martin,
thanks. This was my mistake (again I forgot to clean the project after 
updating master via git on command line).
I still intend to release a 1.7.0 tomorrow instead of an 1.6.x.
Stefan


On 02/11/2012 02:20 PM, Dr....@t-... wrote:
> Hi Stefan,
>
> should be the following commit:
>
> commit c60ac2a448bd5b3d727673a23fa879da839c4d54
>
> Author: Erik Vos <eri...@xs...> 2012-02-07 23:01:08
> Committer: Erik Vos <eri...@xs...> 2012-02-07 23:01:08
> Parent: 59e98fa0bda31a4f2944fee0dac6bd123b322bb0 (Increased robustness
> of grid panel highlighting)
> Child: 5f70d21472cf24abf7ac417896273245f39074e8 (Increased robustness
> for GridPanel(2): Added field may have null-border)
> Branches: origin/master, origin/HEAD, master
>
> Regards,
>
> Martin
>
> *Von:* Stefan Frey <ste...@we...>
>
> *An:* "Dr....@t-..." <Dr....@t-...>,
> "Development list for Rails: an 18xx game"
> <rai...@li...>
>
> *Betreff:* Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2,
> buying final Private in 1830.)
>
> *Datum:* Sat, 11 Feb 2012 13:52:51 +0100
>
> Martin:
> Did you find Erik's fix in master?
> In any case there is no need for a patch against 1.6.X as I only need
> the commit id to pick it into that branch.
> However I do not intend to release another 1.6.x
> Thanks,
> Stefan
>
>
>
> "Dr....@t-..." <Dr....@t-...> schrieb:
>
>     Hi Stefan,
>
>     i'll send a patch later against 1.6.3 that should include Eriks 1835
>     fix.
>
>     Regards,
>     Martin
>
>     *Von:* Stefan Frey <ste...@we...>
>     *An:* rai...@li...
>     *Betreff:* [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2,
>     buying final Private in 1830.)
>     *Datum:* Sat, 11 Feb 2012 12:47:48 +0100
>
>     Martin:
>     no I did not consider the non-modal dialogs to be bug-fixes and from
>     the feedback of Phil and Erik there was no indication that the two
>     issues are related.
>     However as Erik works on master only, it is likely that it you catched
>     the problem here.
>
>     So my plan is to release a version 1.7.0 at the end of this weekend
>     which will include all changes of master. The only thing missing
>     currently is the 1835 bug fix, which will have to wait until 1.7.1
>     unless Erik updates it until tomorrow.
>
>     Frederick:
>     would it be possible for you to collect a list of all UI changes you
>     made until now and (if required) which option has to be used to
>     activate
>     it. I would use that for the release readme/message.
>
>     Thanks,
>     Stefan
>
>
>     On 02/11/2012 12:22 AM, Dr....@t-... wrote:
>      > Hi Stefan,
>      >
>      > Eriks new non Modal Dialogs for the StartroundWindow arent used
>     in the
>      > 1.6.x release.
>      >
>      > Might it be possible that with the release of 1.6.x those changes got
>      > omitted ?
>      >
>      > Cause they fix the behaviour/bug Russel has been reporting.
>      >
>      > I mistakenly used the master branch to come to the result of my
>     earlier
>      > emails.
>      >
>      > The current master with the new non modal dialogs is fixing the
>     problem
>      > Russel has reported.
>      >
>      > @Russel: Sorry, the bug is valid, but already fixed in
>     development, the
>      > fix needs to be pushed to a release.
>      >
>      > The save file i send earlier should allow you to continue playing
>     though.
>      >
>      > Regards,
>      > Martin
>      >
>      >
>      > *Von:* "Dr....@t-..."
>      >
>      > *An:* "Development list for Rails: an 18xx game"
>      > , "Russell J. Alphey"
>      >
>      >
>      > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private
>     in 1830.
>      >
>      > *Datum:* Sat, 11 Feb 2012 00:11:17 +0100
>      >
>      > Hi Russel,
>      >
>      > Yes the save file is 1.6.2. i have to say this is interesting. Cause
>      > Eric introduced the non modal dialogs and they do function as
>     intended.
>      >
>      > Can somebody else reproduce Russels problem ? As i said i was able to
>      > switch to the Main Window and save the game and on reloading the
>     right
>      > player was asked to set the price (which of course might be a lucky
>      > case, cause that player was actually the owner of the B&O).
>      >
>      > Regards,
>      >
>      > Martin
>      >
>      > *Von:* "Dr....@t-..."
>      >
>      > *An:* "Development list for Rails: an 18xx game"
>      > , "Russell J. Alphey"
>      >
>      >
>      > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private
>     in 1830.
>      >
>      > *Datum:* Sat, 11 Feb 2012 00:07:10 +0100
>      >
>      > Hi Russel,
>      >
>      > on my system i could bring the Main Window into the foreground
>     and save
>      > the turn.
>      >
>      > Find attached the save file with the dialog of Sime still active.
>      >
>      > Are you sure you are using 1.6.x ?
>      >
>      > Regards,
>      >
>      > Martin
>      >
>      > *Von:* "Russell J. Alphey"
>      > *An:* rai...@li...
>      > *Betreff:* [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
>      > *Datum:* Wed, 08 Feb 2012 06:08:44 +0100
>      >
>      > Hello,
>      >
>      > We've just started up a game of 1830, and in my turn I'm trying to
>      > buy the final Private.
>      > The moment I do, Rails is insisting on the next player setting the
>      > price of the B&O, and I can't
>      > cancel that, or save the game, or anything other than shut Rails
>     down.
>      >
>      > Turn file attached.
>      >
>      > R.
>      >
>      >
>      >
>      >
>     ------------------------------------------------------------------------------
>      > Virtualization& Cloud Management Using Capacity Planning
>      > Cloud computing makes use of virtualization - but cloud computing
>      > also focuses on allowing computing to be delivered as a service.
>      > http://www.accelacomm.com/jaw/sfnl/114/51521223/
>      >
>      >
>      >
>      > _______________________________________________
>      > Rails-devel mailing list
>      > Rai...@li...
>      > https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>     ------------------------------------------------------------------------------
>     Virtualization & Cloud Management Using Capacity Planning
>     Cloud computing makes use of virtualization - but cloud computing
>     also focuses on allowing computing to be delivered as a service.
>     http://www.accelacomm.com/jaw/sfnl/114/51521223/
>     _______________________________________________
>     Rails-devel mailing list
>     Rai...@li...
>     https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[Frederick W. <fre...@go...>]

Stefan:
This is a condensed list (omitting minor roundoffs/improvements):

- General UI improvements:
    - Interactive highlighting of hexes
    - Enhanced highlighting of active table cells during Operating Round
    - Adaptive rendering of token labels
    - Lay Tile: Invalid tile lays are displayed (incl. the reason for
not being valid)

- Added UI options:
    - Map / Zoom Fit Option: Fit-to-window and more
    - Map / Display Routes of Active Company
    - Map / Highlight company locations
    - Appearance / Display borders in grid layout
    - Windows / Flexible panels for operating round: Applies a docking
framework to Operating Round Window

- Added Music/Sound Effects options (mp3 only):
    - Music: Background music can be specified per round-type and phase
    - Sound Effects: Sound effects can be associated to more than 20 game events
        - Includes support of "intelligent" effects (eg., revenue
sound as in RailroadTycoon1)
    - No music/sound files are provided by rails

-- Frederick

Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[<Dr....@t-...>]

Hi Stefan, 

	should be the following commit: 

	commit c60ac2a448bd5b3d727673a23fa879da839c4d54 

	Author: Erik Vos <eri...@xs...> 2012-02-07 23:01:08
Committer: Erik Vos <eri...@xs...> 2012-02-07 23:01:08
Parent: 59e98fa0bda31a4f2944fee0dac6bd123b322bb0 (Increased robustness
of grid panel highlighting)
Child: 5f70d21472cf24abf7ac417896273245f39074e8 (Increased robustness
for GridPanel(2): Added field may have null-border)
Branches: origin/master, origin/HEAD, master 

	Regards, 

	Martin  

	Von: Stefan Frey <ste...@we...> 

	An: "Dr....@t-..." <Dr....@t-...>,
"Development list for Rails: an 18xx game"
<rai...@li...> 

	Betreff: Re: [Rails-devel] Planned Release 1.7.0 (was:  Bug in 1.6.2,
buying final Private in 1830.) 

	Datum: Sat, 11 Feb 2012 13:52:51 +0100 

	   Martin:
 Did you find Erik's fix in master?
 In any case there is no need for a patch against 1.6.X as I only need
the commit id to pick it into that branch.
 However I do not intend to release another 1.6.x
 Thanks,
 Stefan

 "Dr....@t-..." <Dr....@t-...> schrieb: 
 

	Hi Stefan, 

	i'll send a patch later against 1.6.3 that should include Eriks 1835
fix. 

	Regards,
Martin

	  Von: Stefan Frey <ste...@we...>
 An: rai...@li...
 Betreff: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2,
buying final Private in 1830.)
 Datum: Sat, 11 Feb 2012 12:47:48 +0100

 Martin:
 no I did not consider the non-modal dialogs to be bug-fixes and from
 the feedback of Phil and Erik there was no indication that the two 
 issues are related.
 However as Erik works on master only, it is likely that it you
catched 
 the problem here.

 So my plan is to release a version 1.7.0 at the end of this weekend 
 which will include all changes of master. The only thing missing 
 currently is the 1835 bug fix, which will have to wait until 1.7.1 
 unless Erik updates it until tomorrow.

 Frederick:
 would it be possible for you to collect a list of all UI changes you 
 made until now and (if required) which option has to be used to
activate 
 it. I would use that for the release readme/message.

 Thanks,
 Stefan

 On 02/11/2012 12:22 AM, Dr....@t-... wrote:
 > Hi Stefan,
 >
 > Eriks new non Modal Dialogs for the StartroundWindow arent used in
the
 > 1.6.x release.
 >
 > Might it be possible that with the release of 1.6.x those changes
got
 > omitted ?
 >
 > Cause they fix the behaviour/bug Russel has been reporting.
 >
 > I mistakenly used the master branch to come to the result of my
earlier
 > emails.
 >
 > The current master with the new non modal dialogs is fixing the
problem
 > Russel has reported.
 >
 > @Russel: Sorry, the bug is valid, but already fixed in development,
the
 > fix needs to be pushed to a release.
 >
 > The save file i send earlier should allow you to continue playing
though.
 >
 > Regards,
 > Martin
 >
 >
 > *Von:* "Dr....@t-..." 
 >
 > *An:* "Development list for Rails: an 18xx game"
 > , "Russell J. Alphey"
 > 
 >
 > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 >
 > *Datum:* Sat, 11 Feb 2012 00:11:17 +0100
 >
 > Hi Russel,
 >
 > Yes the save file is 1.6.2. i have to say this is interesting.
Cause
 > Eric introduced the non modal dialogs and they do function as
intended.
 >
 > Can somebody else reproduce Russels problem ? As i said i was able
to
 > switch to the Main Window and save the game and on reloading the
right
 > player was asked to set the price (which of course might be a lucky
 > case, cause that player was actually the owner of the B&O).
 >
 > Regards,
 >
 > Martin
 >
 > *Von:* "Dr....@t-..." 
 >
 > *An:* "Development list for Rails: an 18xx game"
 > , "Russell J. Alphey"
 > 
 >
 > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 >
 > *Datum:* Sat, 11 Feb 2012 00:07:10 +0100
 >
 > Hi Russel,
 >
 > on my system i could bring the Main Window into the foreground and
save
 > the turn.
 >
 > Find attached the save file with the dialog of Sime still active.
 >
 > Are you sure you are using 1.6.x ?
 >
 > Regards,
 >
 > Martin
 >
 > *Von:* "Russell J. Alphey" 
 > *An:* rai...@li...
 > *Betreff:* [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 > *Datum:* Wed, 08 Feb 2012 06:08:44 +0100
 >
 > Hello,
 >
 > We've just started up a game of 1830, and in my turn I'm trying to
 > buy the final Private.
 > The moment I do, Rails is insisting on the next player setting the
 > price of the B&O, and I can't
 > cancel that, or save the game, or anything other than shut Rails
down.
 >
 > Turn file attached.
 >
 > R.
 >
 >
 >
 >
------------------------------------------------------------------------------
 > Virtualization& Cloud Management Using Capacity Planning
 > Cloud computing makes use of virtualization - but cloud computing
 > also focuses on allowing computing to be delivered as a service.
 > http://www.accelacomm.com/jaw/sfnl/114/51521223/
 >
 >
 >
 > _______________________________________________
 > Rails-devel mailing list
 > Rai...@li...
 > https://lists.sourceforge.net/lists/listinfo/rails-devel

 ------------------------------------------------------------------------------
 Virtualization & Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing 
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 _______________________________________________
 Rails-devel mailing list
 Rai...@li...
 https://lists.sourceforge.net/lists/listinfo/rails-devel

Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[Stefan F. <ste...@we...>]

Martin:
Did you find Erik's fix in master?
In any case there is no need for a patch against 1.6.X as I only need the commit id to pick it into that branch.
However I do not intend to release another 1.6.x
Thanks,
Stefan



"Dr....@t-..." <Dr....@t-...> schrieb:

Hi Stefan,

 

i'll send a patch later against 1.6.3 that should include Eriks 1835 fix.

 

Regards,
Martin

 

Von: Stefan Frey <ste...@we...>
An: rai...@li...
Betreff: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)
Datum: Sat, 11 Feb 2012 12:47:48 +0100

Martin:
no I did not consider the non-modal dialogs to be bug-fixes and from
the feedback of Phil and Erik there was no indication that the two 
issues are related.
However as Erik works on master only, it is likely that it you catched 
the problem here.

So my plan is to release a version 1.7.0 at the end of this weekend 
which will include all changes of master. The only thing missing 
currently is the 1835 bug fix, which will have to wait until 1.7.1 
unless Erik updates it until tomorrow.

Frederick:
would it be possible for you to collect a list of all UI changes you 
made until now and (if required) which option has to be used to activate 
it. I would use that for the release readme/message.

Thanks,
Stefan


On 02/11/2012 12:22 AM, Dr....@t-... wrote:
> Hi Stefan,
>
> Eriks new non Modal Dialogs for the StartroundWindow arent used in the
> 1.6.x release.
>
> Might it be possible that with the release of 1.6.x those changes got
> omitted ?
>
> Cause they fix the behaviour/bug Russel has been reporting.
>
> I mistakenly used the master branch to come to the result of my earlier
> emails.
>
> The current master with the new non modal dialogs is fixing the problem
> Russel has reported.
>
> @Russel: Sorry, the bug is valid, but already fixed in development, the
> fix needs to be pushed to a release.
>
> The save file i send earlier should allow you to continue playing though.
>
> Regards,
> Martin
>
>
> *Von:* "Dr....@t-..." 
>
> *An:* "Development list for Rails: an 18xx game"
> , "Russell J. Alphey"
> 
>
> *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
>
> *Datum:* Sat, 11 Feb 2012 00:11:17 +0100
>
> Hi Russel,
>
> Yes the save file is 1.6.2. i have to say this is interesting. Cause
> Eric introduced the non modal dialogs and they do function as intended.
>
> Can somebody else reproduce Russels problem ? As i said i was able to
> switch to the Main Window and save the game and on reloading the right
> player was asked to set the price (which of course might be a lucky
> case, cause that player was actually the owner of the B&O).
>
> Regards,
>
> Martin
>
> *Von:* "Dr....@t-..." 
>
> *An:* "Development list for Rails: an 18xx game"
> , "Russell J. Alphey"
> 
>
> *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
>
> *Datum:* Sat, 11 Feb 2012 00:07:10 +0100
>
> Hi Russel,
>
> on my system i could bring the Main Window into the foreground and save
> the turn.
>
> Find attached the save file with the dialog of Sime still active.
>
> Are you sure you are using 1.6.x ?
>
> Regards,
>
> Martin
>
> *Von:* "Russell J. Alphey" 
> *An:* rai...@li...
> *Betreff:* [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
> *Datum:* Wed, 08 Feb 2012 06:08:44 +0100
>
> Hello,
>
> We've just started up a game of 1830, and in my turn I'm trying to
> buy the final Private.
> The moment I do, Rails is insisting on the next player setting the
> price of the B&O, and I can't
> cancel that, or save the game, or anything other than shut Rails down.
>
> Turn file attached.
>
> R.
>
>
>
> ------------------------------------------------------------------------------
> Virtualization& Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel

 

Re: [Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[<Dr....@t-...>]

Hi Stefan, 

	i'll send a patch later against 1.6.3 that should include Eriks 1835
fix. 

	Regards,
Martin

	  Von: Stefan Frey <ste...@we...>
 An: rai...@li...
 Betreff: [Rails-devel] Planned Release 1.7.0 (was:  Bug in 1.6.2,
buying final Private in 1830.)
 Datum: Sat, 11 Feb 2012 12:47:48 +0100

 Martin:
 no I did not consider the non-modal dialogs to be bug-fixes and from
 the feedback of Phil and Erik there was no indication that the two 
 issues are related.
 However as Erik works on master only, it is likely that it you
catched 
 the problem here.

 So my plan is to release a version 1.7.0 at the end of this weekend 
 which will include all changes of master. The only thing missing 
 currently is the 1835 bug fix, which will have to wait until 1.7.1 
 unless Erik updates it until tomorrow.

 Frederick:
 would it be possible for you to collect a list of all UI changes you 
 made until now and (if required) which option has to be used to
activate 
 it. I would use that for the release readme/message.

 Thanks,
 Stefan

 On 02/11/2012 12:22 AM, Dr....@t-... wrote:
 > Hi Stefan,
 >
 > Eriks new non Modal Dialogs for the StartroundWindow arent used in
the
 > 1.6.x release.
 >
 > Might it be possible that with the release of 1.6.x those changes
got
 > omitted ?
 >
 > Cause they fix the behaviour/bug Russel has been reporting.
 >
 > I mistakenly used the master branch to come to the result of my
earlier
 > emails.
 >
 > The current master with the new non modal dialogs is fixing the
problem
 > Russel has reported.
 >
 > @Russel: Sorry, the bug is valid, but already fixed in development,
the
 > fix needs to be pushed to a release.
 >
 > The save file i send earlier should allow you to continue playing
though.
 >
 > Regards,
 > Martin
 >
 >
 > *Von:* "Dr....@t-..." 
 >
 > *An:* "Development list for Rails: an 18xx game"
 > , "Russell J. Alphey"
 > 
 >
 > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 >
 > *Datum:* Sat, 11 Feb 2012 00:11:17 +0100
 >
 > Hi Russel,
 >
 > Yes the save file is 1.6.2. i have to say this is interesting.
Cause
 > Eric introduced the non modal dialogs and they do function as
intended.
 >
 > Can somebody else reproduce Russels problem ? As i said i was able
to
 > switch to the Main Window and save the game and on reloading the
right
 > player was asked to set the price (which of course might be a lucky
 > case, cause that player was actually the owner of the B&O).
 >
 > Regards,
 >
 > Martin
 >
 > *Von:* "Dr....@t-..." 
 >
 > *An:* "Development list for Rails: an 18xx game"
 > , "Russell J. Alphey"
 > 
 >
 > *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 >
 > *Datum:* Sat, 11 Feb 2012 00:07:10 +0100
 >
 > Hi Russel,
 >
 > on my system i could bring the Main Window into the foreground and
save
 > the turn.
 >
 > Find attached the save file with the dialog of Sime still active.
 >
 > Are you sure you are using 1.6.x ?
 >
 > Regards,
 >
 > Martin
 >
 > *Von:* "Russell J. Alphey" 
 > *An:* rai...@li...
 > *Betreff:* [Rails-devel] Bug in 1.6.2, buying final Private in
1830.
 > *Datum:* Wed, 08 Feb 2012 06:08:44 +0100
 >
 > Hello,
 >
 > We've just started up a game of 1830, and in my turn I'm trying to
 > buy the final Private.
 > The moment I do, Rails is insisting on the next player setting the
 > price of the B&O, and I can't
 > cancel that, or save the game, or anything other than shut Rails
down.
 >
 > Turn file attached.
 >
 > R.
 >
 >
 >
 >
------------------------------------------------------------------------------
 > Virtualization&  Cloud Management Using Capacity Planning
 > Cloud computing makes use of virtualization - but cloud computing
 > also focuses on allowing computing to be delivered as a service.
 > http://www.accelacomm.com/jaw/sfnl/114/51521223/
 >
 >
 >
 > _______________________________________________
 > Rails-devel mailing list
 > Rai...@li...
 > https://lists.sourceforge.net/lists/listinfo/rails-devel

 ------------------------------------------------------------------------------
 Virtualization & Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing 
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 _______________________________________________
 Rails-devel mailing list
 Rai...@li...
 https://lists.sourceforge.net/lists/listinfo/rails-devel

[Rails-devel] Planned Release 1.7.0 (was: Bug in 1.6.2, buying final Private in 1830.)

[Stefan F. <ste...@we...>]

Martin:
no I did not consider the non-modal dialogs to be bug-fixes and from
the feedback of Phil and Erik there was no indication that the two 
issues are related.
However as Erik works on master only, it is likely that it you catched 
the problem here.

So my plan is to release a version 1.7.0 at the end of this weekend 
which will include all changes of master. The only thing missing 
currently is the 1835 bug fix, which will have to wait until 1.7.1 
unless Erik updates it until tomorrow.

Frederick:
would it be possible for you to collect a list of all UI changes you 
made until now and (if required) which option has to be used to activate 
it. I would use that for the release readme/message.

Thanks,
Stefan


On 02/11/2012 12:22 AM, Dr....@t-... wrote:
> Hi Stefan,
>
> Eriks new non Modal Dialogs for the StartroundWindow arent used in the
> 1.6.x release.
>
> Might it be possible that with the release of 1.6.x those changes got
> omitted ?
>
> Cause they fix the behaviour/bug Russel has been reporting.
>
> I mistakenly used the master branch to come to the result of my earlier
> emails.
>
> The current master with the new non modal dialogs is fixing the problem
> Russel has reported.
>
> @Russel: Sorry, the bug is valid, but already fixed in development, the
> fix needs to be pushed to a release.
>
> The save file i send earlier should allow you to continue playing though.
>
> Regards,
> Martin
>
>
> *Von:* "Dr....@t-..." <Dr....@t-...>
>
> *An:* "Development list for Rails: an 18xx game"
> <rai...@li...>, "Russell J. Alphey"
> <Ra...@Mt...>
>
> *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
>
> *Datum:* Sat, 11 Feb 2012 00:11:17 +0100
>
> Hi Russel,
>
> Yes the save file is 1.6.2. i have to say this is interesting. Cause
> Eric introduced the non modal dialogs and they do function as intended.
>
> Can somebody else reproduce Russels problem ? As i said i was able to
> switch to the Main Window and save the game and on reloading the right
> player was asked to set the price (which of course might be a lucky
> case, cause that player was actually the owner of the B&O).
>
> Regards,
>
> Martin
>
> *Von:* "Dr....@t-..." <Dr....@t-...>
>
> *An:* "Development list for Rails: an 18xx game"
> <rai...@li...>, "Russell J. Alphey"
> <Ra...@Mt...>
>
> *Betreff:* Re: [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
>
> *Datum:* Sat, 11 Feb 2012 00:07:10 +0100
>
> Hi Russel,
>
> on my system i could bring the Main Window into the foreground and save
> the turn.
>
> Find attached the save file with the dialog of Sime still active.
>
> Are you sure you are using 1.6.x ?
>
> Regards,
>
> Martin
>
> *Von:* "Russell J. Alphey" <Ra...@Mt...>
> *An:* rai...@li...
> *Betreff:* [Rails-devel] Bug in 1.6.2, buying final Private in 1830.
> *Datum:* Wed, 08 Feb 2012 06:08:44 +0100
>
> Hello,
>
> We've just started up a game of 1830, and in my turn I'm trying to
> buy the final Private.
> The moment I do, Rails is insisting on the next player setting the
> price of the B&O, and I can't
> cancel that, or save the game, or anything other than shut Rails down.
>
> Turn file attached.
>
> R.
>
>
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
>
>
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel