rails-devel — List for discussion of Rails development

Re: [Rails-devel] Contributing - and is this mailing list still active?

[Dave M. <da...@mi...>]

I’m listening, but not actively doing anything at the moment.
Dave.

Sent from Mail for Windows 10

From: Chris Moore
Sent: Thursday, April 25, 2019 11:24 AM
To: rai...@li...
Subject: [Rails-devel] Contributing - and is this mailing list still active?

Hello,

I'm looking at adding 1861 to the list of supported games, and I've forked the repo on github to work on it.  

Is this mailing list still active, or is there a new place for discussions now that the source has been moved to github?

Thanks,
Chris Moore

[Rails-devel] Contributing - and is this mailing list still active?

[Chris M. <cmo...@gm...>]

Hello,

I'm looking at adding 1861 to the list of supported games, and I've forked
the repo on github to work on it.

Is this mailing list still active, or is there a new place for discussions
now that the source has been moved to github?

Thanks,
Chris Moore

Re: [Rails-devel] [rails:code] Merge request: Fix Gradle build errors

[brett l. <bre...@gm...>]

Sourceforge's ownership has been a concern for quite a while now. Their
reliability hasn't always been the best.

So, a while ago, we started moving things to Github. But the old
sourceforge repos are still intact and haven't been cleared out (yet).

---Brett.


On Tue, Oct 23, 2018 at 2:30 PM Larry North <ln...@sw...> wrote:

> Created a pull request.
>
>
>
> Why are there two repositories?
>
>
>
> Larry
>
>
>
> *From:* brett lentz [mailto:bre...@gm...]
> *Sent:* Tuesday, October 23, 2018 11:30 AM
> *To:* Development list for Rails: an 18xx game <
> rai...@li...>
> *Subject:* Re: [Rails-devel] [rails:code] Merge request: Fix Gradle build
> errors
>
>
>
> Please also make sure this change is propagated to github, too.
>
>
> ---Brett.
>
>
>
>
>
> On Tue, Oct 23, 2018 at 12:29 PM Dr. Martin Brumm <
> neu...@us...> wrote:
>
>
>    - *Status*: open --> merged
>
> ------------------------------
>
> Larry North has requested to merge changes from ssh://@
> git.code.sf.net/u/lrnorth/rails at commit [7d69f5] into the branch
> rails_2_develop
>
> Fix Gradle build errors
> ------------------------------
>
> Sent from sourceforge.net because you indicated interest in
> https://sourceforge.net/p/rails/code/merge-requests/2/
>
> To unsubscribe from further messages, please visit
> https://sourceforge.net/auth/subscriptions/
>
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] [rails:code] Merge request: Fix Gradle build errors

[Larry N. <ln...@sw...>]

Created a pull request.

 

Why are there two repositories?

 

Larry

 

From: brett lentz [mailto:bre...@gm...] 
Sent: Tuesday, October 23, 2018 11:30 AM
To: Development list for Rails: an 18xx game <rai...@li...>
Subject: Re: [Rails-devel] [rails:code] Merge request: Fix Gradle build errors

 

Please also make sure this change is propagated to github, too.



---Brett.

 

 

On Tue, Oct 23, 2018 at 12:29 PM Dr. Martin Brumm <neu...@us... <mailto:neu...@us...> > wrote:

*	Status: open --> merged

  _____  

Larry North has requested to merge changes from ssh://@git.code.sf.net/u/lrnorth/rails <http://git.code.sf.net/u/lrnorth/rails>  at commit [7d69f5] into the branch rails_2_develop

Fix Gradle build errors

  _____  

Sent from sourceforge.net <http://sourceforge.net>  because you indicated interest in https://sourceforge.net/p/rails/code/merge-requests/2/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

Re: [Rails-devel] [rails:code] Merge request: Fix Gradle build errors

[brett l. <bre...@gm...>]

Please also make sure this change is propagated to github, too.

---Brett.


On Tue, Oct 23, 2018 at 12:29 PM Dr. Martin Brumm <
neu...@us...> wrote:

>
>    - *Status*: open --> merged
>
> ------------------------------
>
> Larry North has requested to merge changes from ssh://@
> git.code.sf.net/u/lrnorth/rails at commit [7d69f5] into the branch
> rails_2_develop
>
> Fix Gradle build errors
> ------------------------------
>
> Sent from sourceforge.net because you indicated interest in
> https://sourceforge.net/p/rails/code/merge-requests/2/
>
> To unsubscribe from further messages, please visit
> https://sourceforge.net/auth/subscriptions/
>

Re: [Rails-devel] Gradle Build Errors

[Larry N. <ln...@sw...>]

Martin,

 

I’ll submit a merge request.

 

Larry

 

From: Martin Brumm [mailto:dr....@t-...] 
Sent: Monday, October 22, 2018 12:59 PM
To: rai...@li...
Subject: Re: [Rails-devel] Gradle Build Errors

 

Am 22.10.2018 um 02:53 schrieb Larry North:

These errors occur in the Gradle build of branch rails_2_develop:

 

1.       junit.framework.AssertionFailedError: Class
net.sf.rails.test.TestGame has no public constructor TestCase(String name)
or TestCase()

2.       junit.framework.ComparisonFailure: Reports differ in line 2
expected:<PlayerIs,1,Klaus-J[ü]rgen> but was:<PlayerIs,1,Klaus-J[ü]rgen>

3.       junit.framework.ComparisonFailure: Reports differ in line 503
expected:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B> but
was:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B>

4.       junit.framework.ComparisonFailure: Reports differ in line 477
expected:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B> but
was:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B>

 

Error 1 occurs because the Gradle test task attempts to run TestGame, which
is not intended as a standalone test class.

 

The others occur because UTF-8 was not the default file encoding.

 

I fixed these errors by adding this to build.gradle:

 

test {

    systemProperty 'file.encoding', 'UTF-8'

    exclude 'net/sf/rails/test/TestGame.class'

}

 

Do you want a patch or pull request?

 

Larry North

 

 

Hi Larry,
thanks. If you are willing a pull request would be nice. Otherwise i can fix
that myself :) But yours the honours.
Regards,
Martin

Re: [Rails-devel] Gradle Build Errors

[Martin B. <dr....@t-...>]

Am 22.10.2018 um 02:53 schrieb Larry North:
>
> These errors occur in the Gradle build of branch rails_2_develop:
>
>  
>
> 1.junit.framework.AssertionFailedError: Class
> net.sf.rails.test.TestGame has no public constructor TestCase(String
> name) or TestCase()
>
> 2.junit.framework.ComparisonFailure: Reports differ in line 2
> expected:<PlayerIs,1,Klaus-J[ü]rgen> but was:<PlayerIs,1,Klaus-J[ü]rgen>
>
> 3.junit.framework.ComparisonFailure: Reports differ in line 503
> expected:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B> but
> was:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B>
>
> 4.junit.framework.ComparisonFailure: Reports differ in line 477
> expected:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B> but
> was:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B>
>
>  
>
> Error 1 occurs because the Gradle test task attempts to run TestGame,
> which is not intended as a standalone test class.
>
>  
>
> The others occur because UTF-8 was not the default file encoding.
>
>  
>
> I fixed these errors by adding this to build.gradle:
>
>  
>
> test{
>
>     systemProperty 'file.encoding', 'UTF-8'
>
>     exclude 'net/sf/rails/test/TestGame.class'
>
> }
>
>  
>
> Do you want a patch or pull request?
>
>  
>
> Larry North
>
>  
>
>  
>
Hi Larry,
thanks. If you are willing a pull request would be nice. Otherwise i can
fix that myself :) But yours the honours.
Regards,
Martin

[Rails-devel] Gradle Build Errors

[Larry N. <ln...@sw...>]

These errors occur in the Gradle build of branch rails_2_develop:

 

1. junit.framework.AssertionFailedError: Class net.sf.rails.test.TestGame
has no public constructor TestCase(String name) or TestCase()

2. junit.framework.ComparisonFailure: Reports differ in line 2
expected:<PlayerIs,1,Klaus-J[ü]rgen> but was:<PlayerIs,1,Klaus-J[ü]rgen>

3. junit.framework.ComparisonFailure: Reports differ in line 503
expected:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B> but
was:<..._COMPANY_LOG,Arne,KK[ÖB,90,180,2,20,KKÖ]B>

4. junit.framework.ComparisonFailure: Reports differ in line 477
expected:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B> but
was:<...OMPANY_LOG,Martin,KK[ÖB,75,150,2,20,KKÖ]B>

 

Error 1 occurs because the Gradle test task attempts to run TestGame, which
is not intended as a standalone test class.

 

The others occur because UTF-8 was not the default file encoding.

 

I fixed these errors by adding this to build.gradle:

 

test {

    systemProperty 'file.encoding', 'UTF-8'

    exclude 'net/sf/rails/test/TestGame.class'

}

 

Do you want a patch or pull request?

 

Larry North

 

 

[Rails-devel] Closing NF in no map 1935

[Stefan M. <st...@m1...>]

Hello,
we are in a no-map game of 1835 (actually our first game using rails).

How can I manually close the NF after the tile has been laid? We don't 
use the map display...

Thanks for your help
Stefan

Re: [Rails-devel] Rails-18xx on Github - Email invite

[Russell I. <mwn...@ya...>]

NICE!  Thanks!
I use GitHub at work so I am familiar with its ins-and-outs.
I'll register when I get a chance.
R.

      From: Dr. Martin Brumm <dr....@t-...>
 To: Development list for Rails: an 18xx game <rai...@li...>; rai...@li... 
 Sent: Sunday, July 9, 2017 8:28 AM
 Subject: [Rails-devel] Rails-18xx on Github - Email invite
   
Good Day,

some of the more regular contributors received or should have received a 
direct invite to a new organisation github called

Rails-18xx

Now whats behind that, after discussion with Brett Lentz (he and myself 
are the last remaining Admins on Rails@sourceforge and hes one of the 
original creators) and we pretty much agreeing on needing more active 
people and better visibility (and more tools), i went ahead and setup a 
organisation on Github for collaboration and not running again in a 
deadlock like happening with the owner of a specific github-account 
getting inactive and thus stalling the work, like it sadly happened.

So if you didnt receive an invite please bear with me. If you are still 
interested in contributing like programming, testing or discussing 
implementation, bugs, rules etc, head over to

https://github.com/Rails-18xx
and become a member of the group or just lurk around there :)

The mailinglists here will still be fed with announcements and 
discussions will be watched (at least by me).

I'll try together with Brett to transfer the repositories to github from 
sourceforge and get the documentation going over there.

If anyone wants to help, feel free :)

Martin

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


   

[Rails-devel] Rails-18xx on Github - Email invite

[Dr. M. B. <dr....@t-...>]

Good Day,

some of the more regular contributors received or should have received a 
direct invite to a new organisation github called

Rails-18xx

Now whats behind that, after discussion with Brett Lentz (he and myself 
are the last remaining Admins on Rails@sourceforge and hes one of the 
original creators) and we pretty much agreeing on needing more active 
people and better visibility (and more tools), i went ahead and setup a 
organisation on Github for collaboration and not running again in a 
deadlock like happening with the owner of a specific github-account 
getting inactive and thus stalling the work, like it sadly happened.

So if you didnt receive an invite please bear with me. If you are still 
interested in contributing like programming, testing or discussing 
implementation, bugs, rules etc, head over to

https://github.com/Rails-18xx
and become a member of the group or just lurk around there :)

The mailinglists here will still be fed with announcements and 
discussions will be watched (at least by me).

I'll try together with Brett to transfer the repositories to github from 
sourceforge and get the documentation going over there.

If anyone wants to help, feel free :)

Martin

[Rails-devel] Rails 2 RC 3 released via Sourceforge

[Dr. M. B. <dr....@t-...>]

Good Day to whom it may concern,

even though Stefan planned to have 2.0 out of the gate a long time ago, 
things didnt go that well. But i'll hope that this RC will be shortlived 
and nearly free of bugs.

There might be one left in regard to semirestrictive tile laying 
options. If someone has the time to check and produce some savegames 
which show a unexpected behaviour, i'll be happy to have a go at 
debugging :).

please find below the latest changes towards Rails -18xx:
# Rails 2.0 Release Candidate 3

Major Contributor: Stefan Frey
Minor Contributors : Erik Vos, Chris Noon, Marek Jeszka, Martin Brumm

Be carefull while using this Release on games in progress on 1880 and 1835.
Due to the bugfixes here it is recommended that you replay the game 
using the game log from the old version.
It was not possible to make the savegames compatible if you ht the bug 
in your ongoing game (1835).

Fixes:
Fixed the Reload Command, missing was the RailsRoot Instance, Move some
Code around to resemble the initial load sequence.
Condition check for zero vertexes added (Marek Jeszka)

18AL : BonusToken Situation in 18AL
         Quick Fix to make MapHex.upgrade working for hexes that have no 
station
         and get upgraded to a station by a specialtilelay.
         18AL has exactly that scenario and a number of other games too.

1880 :     Fix Tile 8877 Shanghai Yellow value was wrong now corrected to 30
         Fixing a bug in 1880s handling of players debt during emergency 
raise of trains.
         Fixing the bug that an investor was still able to operate in 
Phase 4.
             This apparently didnt get transfered to 2.0 RC1 while being 
fixed in 1.9.
         Fixed the problem that a Special Train Buy using the RC could 
trigger a
         phase change that wouldnt be recognised for Train Discards.
         Fixed missing Stockmarket field F8.

1835 :    Corrected game behaviour for 1835. According to Rules a sell 
share action only does NOT prolong the Stockround but is treated as a pass.
         Only share buying actions are valid to prolong a round.


1856:     Fixes by Erik Vos
         fixed reload and press done button bug in 1856 (SF)
         quick fix to remove token of ship company in 1856 in phase 5
         (first 6 train), this is related to name and realName 
attributes of Phase (SF)

18EU:     added 18EU test games from Volker Schnell, fixed two reporting 
issues (SF)
         preliminary bugfix for 18EU offboard revenue modifier (SF)
         fix for StartCompany_18EU equality problems (SF)
         added third station on B/V -3005 tile to prevent error on 
upgrade to 581 (SF)

Internal reworking of code and structure too numerous to mention; all 
being done by Stefan Frey

UI Fixes: (Chris Noon)
allow use of the edit box on spin controls, i.e.  font size.
Sizeable Fonts in Stockspace enabled


If i forgot anyone on that list please excuse the oversight.

Thanks and have fun
Martin Brumm for all contributors.

Re: [Rails-devel] Making changes

[Dr. M. B. <dr....@t-...>]

Hi Brett,
did you make the move ?

I am asking as i would be probably ready to release another Release 
Candidate into the wild.

Do you plan to merge rails_2_develop onto the old master branch ?
The branch rails_2_maintenance and rails_2_development are currently one 
or two commits out of sync. I had to revert one of Stefans Commits to 
his Networkgraphing code because it broke the routefinding algorythmn.
The routefinding algo is currently my main concern....

Other than that the game and the variants implemented look stable. So we 
could move onto more variants.

I have been working on 1844 with numerous new problems,
- Private Companies being bought in later stages of the game from the 
bank (Stockround)
- additional SpecialProerties
- Map handling of the Furka-Oberalp
- Map and Revenue Handling of the Mountain Trains
- Map and Revenue Handling of Tunnels
as well as 1837(map handling in different phases, restricted tracks for 
Coal trains, the rest should be covered) .
We have a preliminary 1800 implementation sitting in the 1800 branch.

Some preliminary Setup Code on 18GB and 1854.

1846/1853 need a mechanismn to handle initial bids/startpoint 
allocations in a manner that noone can read/alter them until pre bidding 
phase has passed.

Regards,
Martin
Am 27.06.17 um 15:49 schrieb Brett Lentz:
> On Tue, Jun 20, 2017 at 5:09 PM, Martin Brumm
> <dr....@t-...> wrote:
>> Am 20.06.2017 um 18:55 schrieb brett lentz:
>>
>> Martin, et al. -
>>
>> If Stefan truly is completely inactive, I can fork his github repo and at
>> least be maintainer for purposes of responding to pull-requests.
>>
>> Unless there are serious objections, I think I'd prefer to focus development
>> activity there. I think Github's workflow is pretty well-known at this
>> point, so it might help breathe some new life into the project to make that
>> the "official" repo location.
>>
>> Thoughts?
>>
>> ---Brett
>>
>> Hi Brett,
>>
>> Actually Stefans Github Repo is behind the changes on Sourceforge being done
>> be myself and others in the period since mid 2016. I think then his hooks
>> and other stuff that he had setup to have sourceforge and github
>> synchronized went dead in July 2016. You'll find an import on my Github page
>> called Rails-SF that contains all commits minus one (Chris Noon from
>> Monday).  I do think that Stefan has had some more changes internally and
>> maybe on Github but since they didnt appear in the development nor maint
>> branch i ignored them. IF you want to check them please go ahead.
>>
>> I have no objections against github, though we have more visibility on
>> Sourceforge :)
>> But if that means you get back to active mode i am all in favour :) could
>> use some help even if we have attracted some newcomers lately.
>>
>
> My thinking is to keep the SF stuff (webpage, docs), but just move the
> code repository.
>
> I'll pull all of the branches from both SF and github and try to line
> things up. :)
>
>
>> Guess we should up the docs a little bit to make entry easier...
>>
> I've made you admin for the SF project. So, you should have access to
> do whatever you need to.
>
>> Regards,
>> Martin
>>
>> P.s. Perhaps you can tell me whats wrong see my note to the list on Sunday
>> with the non recognised function ? :)
>
> I'll look at that when I have a few minutes.  :-)

Re: [Rails-devel] Making changes

[brett l. <bre...@gm...>]

Martin, et al. -

If Stefan truly is completely inactive, I can fork his github repo and at
least be maintainer for purposes of responding to pull-requests.

Unless there are serious objections, I think I'd prefer to focus
development activity there. I think Github's workflow is pretty well-known
at this point, so it might help breathe some new life into the project to
make that the "official" repo location.

Thoughts?

---Brett


---Brett.

On Sun, Jun 18, 2017 at 2:25 AM, Martin Brumm <dr....@t-...>
wrote:

> Am 17.06.2017 um 23:19 schrieb Chris NOON:
>
> Hi,
>
>
>
> I was able to get a dev environment up and running, and was looking at the
> code.
>
>
>
> I found a minor, but annoying bug, and was able to fix it.  I do not see
> instructions on how this should be relayed, I assume newbies can’t just
> check in code.
>
>
>
> Thanks,
>
> Chris
>
> Hi Chris,
>
> 2 ways to do this right now.
> a)Prepare a diff and send that to the list or me directly - Preferred way,
> but also create an account on sourceforge if you havent done so already.
> b) Fork Stefans Github  Repo and put your changes in there and then create
> a pull request. Since stefan is not active in the moment this is the less
> preferred way cause i means i have to cross track the changes :) But it
> would also work.
>
> Regards
> Martin
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>
>

Re: [Rails-devel] Making changes

[Russell I. <mwn...@ya...>]

diff is is UNIX utility that produces a specially formatted file.
It is relatively human readable.
You need to have two source files then a command line utility diff
You can load Cygwin on Windows to give you a near complete Linux shell.

      From: Chris NOON <chr...@ms...>
 To: 'Development list for Rails: an 18xx game' <rai...@li...> 
 Sent: Sunday, June 18, 2017 6:58 PM
 Subject: Re: [Rails-devel] Making changes
   
#yiv0807983731 #yiv0807983731 -- _filtered #yiv0807983731 {panose-1:2 4 5 3 5 4 6 3 2 4;} _filtered #yiv0807983731 {font-family:Calibri;panose-1:2 15 5 2 2 2 4 3 2 4;} _filtered #yiv0807983731 {font-family:Tahoma;panose-1:2 11 6 4 3 5 4 4 2 4;}#yiv0807983731 #yiv0807983731 p.yiv0807983731MsoNormal, #yiv0807983731 li.yiv0807983731MsoNormal, #yiv0807983731 div.yiv0807983731MsoNormal {margin:0in;margin-bottom:.0001pt;font-size:11.0pt;color:black;}#yiv0807983731 a:link, #yiv0807983731 span.yiv0807983731MsoHyperlink {color:blue;text-decoration:underline;}#yiv0807983731 a:visited, #yiv0807983731 span.yiv0807983731MsoHyperlinkFollowed {color:purple;text-decoration:underline;}#yiv0807983731 span.yiv0807983731EmailStyle17 {color:windowtext;}#yiv0807983731 span.yiv0807983731EmailStyle18 {color:#1F497D;}#yiv0807983731 .yiv0807983731MsoChpDefault {font-size:10.0pt;} _filtered #yiv0807983731 {margin:1.0in 1.0in 1.0in 1.0in;}#yiv0807983731 div.yiv0807983731WordSection1 {}#yiv0807983731 Is there a preferred way to make a diff?  I can compare in Eclipse, but just copying from the two views does not seem ideal.    Chris    From: Martin Brumm [mailto:dr....@t-...]
Sent: Saturday, June 17, 2017 11:25 PM
To: rai...@li...
Subject: Re: [Rails-devel] Making changes    Am 17.06.2017 um 23:19 schrieb Chris NOON: 
Hi,   I was able to get a dev environment up and running, and was looking at the code.   I found a minor, but annoying bug, and was able to fix it.  I do not see instructions on how this should be relayed, I assume newbies can’t just check in code.   Thanks, Chris 
Hi Chris,

2 ways to do this right now. 
a)Prepare a diff and send that to the list or me directly - Preferred way, but also create an account on sourceforge if you havent done so already.
b) Fork Stefans Github  Repo and put your changes in there and then create a pull request. Since stefan is not active in the moment this is the less preferred way cause i means i have to cross track the changes :) But it would also work.

Regards
Martin ------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
Rails-devel mailing list
Rai...@li...
https://lists.sourceforge.net/lists/listinfo/rails-devel


   

Re: [Rails-devel] Making changes

[Chris N. <chr...@ms...>]

Is there a preferred way to make a diff?  I can compare in Eclipse, but just copying from the two views does not seem ideal.

Chris

From: Martin Brumm [mailto:dr....@t-...]
Sent: Saturday, June 17, 2017 11:25 PM
To: rai...@li...
Subject: Re: [Rails-devel] Making changes

Am 17.06.2017 um 23:19 schrieb Chris NOON:
Hi,

I was able to get a dev environment up and running, and was looking at the code.

I found a minor, but annoying bug, and was able to fix it.  I do not see instructions on how this should be relayed, I assume newbies can’t just check in code.

Thanks,
Chris
Hi Chris,

2 ways to do this right now.
a)Prepare a diff and send that to the list or me directly - Preferred way, but also create an account on sourceforge if you havent done so already.
b) Fork Stefans Github  Repo and put your changes in there and then create a pull request. Since stefan is not active in the moment this is the less preferred way cause i means i have to cross track the changes :) But it would also work.

Regards
Martin

Re: [Rails-devel] Making changes

[Chris N. <chr...@ms...>]

Should (can?) I create a bug for this, or is that not necessary?


Chris



________________________________
From: Martin Brumm <dr....@t-...>
Sent: Sunday, June 18, 2017 6:25 AM
To: rai...@li...
Subject: Re: [Rails-devel] Making changes

Am 17.06.2017 um 23:19 schrieb Chris NOON:
Hi,

I was able to get a dev environment up and running, and was looking at the code.

I found a minor, but annoying bug, and was able to fix it.  I do not see instructions on how this should be relayed, I assume newbies can’t just check in code.

Thanks,
Chris
Hi Chris,

2 ways to do this right now.
a)Prepare a diff and send that to the list or me directly - Preferred way, but also create an account on sourceforge if you havent done so already.
b) Fork Stefans Github  Repo and put your changes in there and then create a pull request. Since stefan is not active in the moment this is the less preferred way cause i means i have to cross track the changes :) But it would also work.

Regards
Martin

Re: [Rails-devel] Making changes

[Martin B. <dr....@t-...>]

Am 17.06.2017 um 23:19 schrieb Chris NOON:
>
> Hi,
>
>  
>
> I was able to get a dev environment up and running, and was looking at
> the code.
>
>  
>
> I found a minor, but annoying bug, and was able to fix it.  I do not
> see instructions on how this should be relayed, I assume newbies can’t
> just check in code.
>
>  
>
> Thanks,
>
> Chris
>
Hi Chris,

2 ways to do this right now.
a)Prepare a diff and send that to the list or me directly - Preferred
way, but also create an account on sourceforge if you havent done so
already.
b) Fork Stefans Github  Repo and put your changes in there and then
create a pull request. Since stefan is not active in the moment this is
the less preferred way cause i means i have to cross track the changes
:) But it would also work.

Regards
Martin

Re: [Rails-devel] Making changes

[Dave M. <da...@mi...>]

Well depending on how many lines of code were changed, you could just post a diff.
Dave.

Sent from Mail for Windows 10

From: Chris NOON
Sent: Saturday, June 17, 2017 5:19 PM
To: rai...@li...
Subject: [Rails-devel] Making changes

Hi,

I was able to get a dev environment up and running, and was looking at the code.

I found a minor, but annoying bug, and was able to fix it.  I do not see instructions on how this should be relayed, I assume newbies can’t just check in code.

Thanks,
Chris



---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

[Rails-devel] Making changes

[Chris N. <chr...@ms...>]

Hi,

I was able to get a dev environment up and running, and was looking at the code.

I found a minor, but annoying bug, and was able to fix it.  I do not see instructions on how this should be relayed, I assume newbies can’t just check in code.

Thanks,
Chris

Re: [Rails-devel] Need help with Eclipse java/git setup - Java Setup

[Dave M. <da...@mi...>]

Thanks,
         setting the Main Class was the most important piece of the puzzle.

I was able to run an instance of an 1830 game last night.
I've never actually played a game on Rails 
before, so I had to stumble around with the Stock Round interface.
It could use some more explanation and prompting.

I built into New York city with the Central.  And 
while I was unable to token the NH base, I could 
put a token on the southern NY space while not 
being connected.  Looking though the bug reports 
it does seem that the connectivity code has some issues.

Next I have to find my way around where the Java 
code is supposed to be accessed in Eclipse.

The funny thing is that I've been using Eclipse 
on a Linux system editing Java code for the past 
year, but it was heavily tailored for a specific product environment.

Dave.

On 6/12/2017 12:28 PM, Martin Brumm wrote:
>Content-Type: multipart/mixed; boundary="OQkn5jIWPCsc7i60QDl0AOi9pDRD2g0ln";
>  protected-headers="v1"
>From: Martin Brumm <dr....@t-...>
>To: rai...@li...
>Message-ID: <a5a...@t-...>
>Subject: Re: [Rails-devel] Need help with Eclipse java/git setup - Java Setup
>
>
>Am 11.06.2017 um 18:50 schrieb Dave Mitton:
>>I need a walk through or a pointer to how to 
>>configure an Eclipse Java "project" and how to 
>>setup the git relationship to sf.net.
>>
>>So far, I tried:
>>
>>- downloaded the jar, expanded it, - but 
>>Eclipse doesn't recognize any sort of project 
>>in there.  I don't know what it's looking for.
>>
>>- I tried several variations of using the git 
>>dialogs to pull from SourceForge, and the one that finally succeeded
>>didn't find anything in there either. (I'm starting with 2.0.RC1)
>>
>>
>>My current goal is to have a set of code that I 
>>can build/run/debug and checkin changes to a private branch.
>>But I don't know the right magic in this environment.
>>
>>Dave.
>>more of a Turtle Mercurial veteran....
>
>Please make sure your setup inside eclipse is like the following:
>
>...
>
>
>You should then be able to build/debug the 
>project by using the eclipse mechanismns.
>
>If you click on the green symbol to run the 
>application it might ask you for the main class location:
>
>
>...
>
>
>Once you have successfully launched the 
>application "RunGame", just click on the debug 
>(left of the run button) and your eclipse view 
>should switch from java to debug window mode.
>
>If you have more questions, feel free.
>
>Regards
>
>Martin
>
>
>
>
>------------------------------------------------------------------------------
>Check out the vibrant tech community on one of the world's most
>engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>_______________________________________________
>Rails-devel mailing list
>Rai...@li...
>https://lists.sourceforge.net/lists/listinfo/rails-devel


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

Re: [Rails-devel] Need help with Eclipse java/git setup - Java Setup

[Martin B. <dr....@t-...>]

Am 11.06.2017 um 18:50 schrieb Dave Mitton:
> I need a walk through or a pointer to how to configure an Eclipse Java
> "project" and how to setup the git relationship to sf.net.
>
> So far, I tried:
>
> - downloaded the jar, expanded it, - but Eclipse doesn't recognize any
> sort of project in there.  I don't know what it's looking for.
>
> - I tried several variations of using the git dialogs to pull from
> SourceForge, and the one that finally succeeded
> didn't find anything in there either. (I'm starting with 2.0.RC1)
>
>
> My current goal is to have a set of code that I can build/run/debug
> and checkin changes to a private branch.
> But I don't know the right magic in this environment.
>
> Dave.
> more of a Turtle Mercurial veteran....
>

Please make sure your setup inside eclipse is like the following:



You should then be able to build/debug the project by using the eclipse
mechanismns.

If you click on the green symbol to run the application it might ask you
for the main class location:



Once you have successfully launched the application "RunGame", just
click on the debug (left of the run button) and your eclipse view should
switch from java to debug window mode.

If you have more questions, feel free.

Regards

Martin

Re: [Rails-devel] Need help with Eclipse java/git setup Step 4

[Martin B. <dr....@t-...>]

Am 11.06.2017 um 18:50 schrieb Dave Mitton:
> I need a walk through or a pointer to how to configure an Eclipse Java
> "project" and how to setup the git relationship to sf.net.
>
If you followed the steps before you should now have a project called
rails or rails code in your eclipse project view.
with a branch in [] behind that project name.
Right click on the project. Go for Team->Switch To-> rails_2_develop.

Right click on the project. Go for Team->Switch To-> New Branch
this should show the following picture:



You can select the branch you want as a base via the select dialog. Give
your new branch a speaking name for example davem_1871 (or whatever
variant you want to work upon) or davem_1830_fix_Startround...

As you probably will work locally for a start dont check the Configure
upstream for push and pull.


This should create a branch based on the rails_2_develop branch for you
to play with.

Next part will be about setting up Gradle and or Ant.

Regards

Martin

Re: [Rails-devel] Need help with Eclipse java/git setup Step 3

[Martin B. <dr....@t-...>]

Take a look here:
http://stackoverflow.com/questions/2432764/how-to-change-a-remote-repository-uri-using-git

Your remote URL (including your username) is shown under Code after you
have logged into sourceforge.

https://sourceforge.net/p/rails/code/ci/master/tree/



For that you need to mail me your sourceforge account to grant you access later on.
FOr the start you should start working on your code and post the patches to the list for crosschecks.


Press next again :)

In the enxt windows you'll be asked to select branches. You should
select the following branches:

rails2.0 (the 2.0 master branch, the master branch is the old 1.x master)

rails_2_develop (development)


rails_2_maintenance (maintenance for the latest released version out of
the 2.0 branch)


and any other branch your are interested in....


If you start working on the code please create a local branch from the
rails_2_development branch. How to follows in the next email.

Regards,

Martin

Re: [Rails-devel] Need help with Eclipse java/git setup Step 2

[Martin B. <dr....@t-...>]

Am 11.06.2017 um 18:50 schrieb Dave Mitton:
> I need a walk through or a pointer to how to configure an Eclipse Java
> "project" and how to setup the git relationship to sf.net.
>
> So far, I tried:
>
> - downloaded the jar, expanded it, - but Eclipse doesn't recognize any
> sort of project in there.  I don't know what it's looking for.
>
> - I tried several variations of using the git dialogs to pull from
> SourceForge, and the one that finally succeeded
> didn't find anything in there either. (I'm starting with 2.0.RC1)
>
>
> My current goal is to have a set of code that I can build/run/debug
> and checkin changes to a private branch.
> But I don't know the right magic in this environment.
>
> Dave