rails-devel — List for discussion of Rails development

Re: [Rails-devel] Cities and stations

[Brett L. <wak...@gm...>]

On Tue, 2008-02-26 at 22:54 +0100, Erik Vos wrote:
> > Also, in the case of 1870, there is a standard and a variant way of
> > handling destination tokens.
> > 
> > The standard rule is that destination tokens don't occupy one of the
> > normal city spaces.
> > 
> > The variant is they do.
> 
> 1870 is beyond my horizon right now, but it'll be considered when the time
> comes...
> 
> Erik.

Of course. The point isn't 'this feature is needed to implement 1870'.
The point is, there is at least one game that has requirements for token
placement outside of town spots on a map hex.

We need to either define an additional "town" spot for map hexes that
allow token placements for certain game mechanics, such as destination
runs. Or we need to define tokens in a way that allows them to be used
in places other than city spots.

The big thing I don't want to see us do is specializing the tokens into
"town tokens" and "non-town tokens". The board games don't make this
distinction, and I see no reason for us to do it either.

These are generic enough mechanisms that I don't think 1870 is the only
game that uses them. So, if you're going to be cleaning up the token
code, this is something to keep in mind and, if you don't code it
directly, leave room in your design to add it later.


 ---Brett.


If you're going to do something tonight that you'll be sorry for tomorrow
morning, sleep late.
		-- Henny Youngman

Re: [Rails-devel] Cities and stations

[Erik V. <eri...@hc...>]

> Also, in the case of 1870, there is a standard and a variant way of
> handling destination tokens.
> 
> The standard rule is that destination tokens don't occupy one of the
> normal city spaces.
> 
> The variant is they do.

1870 is beyond my horizon right now, but it'll be considered when the time
comes...

Erik.

Re: [Rails-devel] Cities and stations

[Erik V. <eri...@hc...>]

 

I noticed in 1870 that a company could place a station marker on a spot that
should be reserved for another company's start location.  You might want to
check this out while you're improving this area.

Yes, currently their is no relationship whatsoever between token placement
and tile city location. There are just one or two standard spots.

Also, this might be a little further than you're working right now, but
consider the impact of needing to place a bonus token on a particular city
in a multi-city tile. 

Yes, we need some algorithm to find a free spot.... 

Re: [Rails-devel] Cities and stations

[Brett L. <wak...@gm...>]

Also, in the case of 1870, there is a standard and a variant way of
handling destination tokens.

The standard rule is that destination tokens don't occupy one of the
normal city spaces.

The variant is they do.

So, we're going to need this to be very flexible and configurable.

---Brett.


On Tue, 2008-02-26 at 12:26 -0700, Jeff Bowers wrote:
> I noticed in 1870 that a company could place a station marker on a
> spot that should be reserved for another company's start location.
> You might want to check this out while you're improving this area.
> 
> Also, this might be a little further than you're working right now,
> but consider the impact of needing to place a bonus token on a
> particular city in a multi-city tile.
> 
> On Tue, Feb 26, 2008 at 11:38 AM, Erik Vos <eri...@hc...> wrote:
>         Just to let you know that I am working on the behaviour on
>         cities/stations
>         during tile upgrades, making sure that the tokens end up in
>         the proper
>         place, etc.
>         This was needed for the 18EU company start in/after phase 5,
>         where a home base must be chosen, possibly on a multi-city
>         tile.
>         This should also take care of 1830 OO tile upgrades and the
>         Erie home base.
>         
>         Proper token drawing is a related but more complicated issue,
>         perhaps I may find inspiration to attack that one too.
>         
>         One thing I'm doing is separating the dual use of the Station
>         class:
>         for defining a city/station on a generic tile, and for a city
>         on
>         a tile actually laid on some hex, possibly having tokens.
>         For the latter purpose I'm adding a new City class.
>         The reason is clarity - the current dual use is too confusing
>         for me.
>         
>         Erik
>         
>         
>         -------------------------------------------------------------------------
>         This SF.net email is sponsored by: Microsoft
>         Defy all challenges. Microsoft(R) Visual Studio 2008.
>         http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>         _______________________________________________
>         Rails-devel mailing list
>         Rai...@li...
>         https://lists.sourceforge.net/lists/listinfo/rails-devel
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel

 ---Brett.


I CAN BE ROBBED BUT NEVER DENIED, I TOLD MYSELF. WHY WORRY?
'I too cannot be cheated,' snapped Fate.
SO I HAVE HEARD.
(Colour of Magic)

Re: [Rails-devel] Cities and stations

[Jeff B. <jef...@gm...>]

I noticed in 1870 that a company could place a station marker on a spot that
should be reserved for another company's start location.  You might want to
check this out while you're improving this area.

Also, this might be a little further than you're working right now, but
consider the impact of needing to place a bonus token on a particular city
in a multi-city tile.

On Tue, Feb 26, 2008 at 11:38 AM, Erik Vos <eri...@hc...> wrote:

> Just to let you know that I am working on the behaviour on cities/stations
> during tile upgrades, making sure that the tokens end up in the proper
> place, etc.
> This was needed for the 18EU company start in/after phase 5,
> where a home base must be chosen, possibly on a multi-city tile.
> This should also take care of 1830 OO tile upgrades and the Erie home
> base.
>
> Proper token drawing is a related but more complicated issue,
> perhaps I may find inspiration to attack that one too.
>
> One thing I'm doing is separating the dual use of the Station class:
> for defining a city/station on a generic tile, and for a city on
> a tile actually laid on some hex, possibly having tokens.
> For the latter purpose I'm adding a new City class.
> The reason is clarity - the current dual use is too confusing for me.
>
> Erik
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

[Rails-devel] Cities and stations

[Erik V. <eri...@hc...>]

Just to let you know that I am working on the behaviour on cities/stations
during tile upgrades, making sure that the tokens end up in the proper
place, etc.
This was needed for the 18EU company start in/after phase 5, 
where a home base must be chosen, possibly on a multi-city tile.
This should also take care of 1830 OO tile upgrades and the Erie home base.

Proper token drawing is a related but more complicated issue,
perhaps I may find inspiration to attack that one too.

One thing I'm doing is separating the dual use of the Station class:
for defining a city/station on a generic tile, and for a city on 
a tile actually laid on some hex, possibly having tokens.
For the latter purpose I'm adding a new City class.
The reason is clarity - the current dual use is too confusing for me.

Erik

[Rails-devel] 18EU Pullmann trains

[Erik V. <eri...@hc...>]

I have added the 18EU Pullmann train buying and discarding rules.

Mike, this has affected OperatingRound, but it should not interfere with
your plan to fix the OR number undo/redo bug.

Erik Vos

Re: [Rails-devel] 18EU undo fix

[Erik V. <eri...@hc...>]

Hi Mike,

I was not aware of this bug, but you are absolutely right:
orNumber is still an int whereas it should be an IntegerState.
I'm not really surprised, though; my testing was not exhaustive, 
and it may well be that more items have escaped undoability.

Please go ahead, I'm out of the way!

Erik.


> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of Michal Bazynski
> Sent: Thursday 21 February 2008 10:49
> To: Dev...@sc...; 
> li...@sc...; 
> fo...@sc...; 
> "Ra...@sc...":an 18xx game
> Subject: Re: [Rails-devel] 18EU undo fix
> 
> 
> I meant to just try to research the problem and send the 
> patch, but the 
> changes below sound close enough I'll ask:
> 
> I believe there are some problems with undo and numbering of 
> operating 
> rounds - I think that if I am in OR 2 of 2 and I undo back 
> into OR 1/2, 
> the program will go to a stock round with the end of the first of 
> supposed two operating roudns, as if the Undo action didn't 
> decrease the 
> variable holding which operating round is happening.
> 
> So my question - does that sound like something close enough 
> to what you 
> are doing you most likely will (or just have in this commit) 
> fix, or is 
> it something I can work on without crossing your paths too much?
> 
> Mike
> 
> Erik Vos wrote:
> > In 18EU, Undo did not revert all changes resulting from 
> minor conversion
> > actions.
> > That has been fixed now.
> > 
> > Erik Vos
> > 
> > 
> > 
> --------------------------------------------------------------
> -----------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> > 
> 
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] 18EU undo fix

[Michał B. <ba...@tl...>]

I meant to just try to research the problem and send the patch, but the 
changes below sound close enough I'll ask:

I believe there are some problems with undo and numbering of operating 
rounds - I think that if I am in OR 2 of 2 and I undo back into OR 1/2, 
the program will go to a stock round with the end of the first of 
supposed two operating roudns, as if the Undo action didn't decrease the 
variable holding which operating round is happening.

So my question - does that sound like something close enough to what you 
are doing you most likely will (or just have in this commit) fix, or is 
it something I can work on without crossing your paths too much?

Mike

Erik Vos wrote:
> In 18EU, Undo did not revert all changes resulting from minor conversion
> actions.
> That has been fixed now.
> 
> Erik Vos
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

[Rails-devel] 18EU undo fix

[Erik V. <eri...@hc...>]

In 18EU, Undo did not revert all changes resulting from minor conversion
actions.
That has been fixed now.

Erik Vos

Re: [Rails-devel] fix to bug 1870539

[Erik V. <eri...@hc...>]

I have found and fixed another bug that manifested itself in 18AL:
tiles with different internal and external IDs could not be laid,
like the Elyton/Birmingham yellow tile.

I have also added an "unfloated" (U) indicator to the GameStatus window for
companies that have been started but not yet floated: the President's
share percentage field now shows e.g. "30%PU" as long as that condition
exists.
The reason is that in games like 18EU you can't use the presence or absence 
of treasury money to see if a company has floated or not.

The main news is, that in 18EU you can now start a company by converting a
Minor, 
and fold in other Minors to already started companies as long as the latter
haven't operated. 

Most of the typical 18EU features have now been implemented.
The main missing ones are the final Minor exchange round and the Pullmann
trains.
I have upgraded the 18EU status in GamesList.xml to "Partly playable".

And now I really have to start doing taxes...

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Tuesday 19 February 2008 03:22
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] fix to bug 1870539
> 
> On Feb 18, 2008 2:52 PM, Michał Bażyński <ba...@tl...> wrote:
> >
> > first of, how to reproduce the bug:
> >
> > In 18AL, conduct a start round in such a way that there's only one
> > bidder for the last private company. you can have every one make a
> > single bid on a different private for example, then buy 
> Tusc. Result:
> > the application hangs.
> >
> > Reason:
> >    in StockRound_1830.java in setPossibleActions() there's 
> a check if
> > there are any unsold companies left before each item is 
> looked at to see
> > if it is just auto-sold as there's only one bidder for it.
> >
> > Solution:
> >    add the extra check if any unsold privates remain after 
> looking at
> > them all.
> >
> > Attached is a patch doing just that.
> >
> > (My first patch, if I should be doing something differently 
> please tell me.)
> >
> > best regards,
> >    mike
> >
> > ? patch.txt
> > Index: StartRound_1830.java
> > ===================================================================
> > RCS file: /cvsroot/rails/18xx/rails/game/StartRound_1830.java,v
> > retrieving revision 1.11
> > diff -u -r1.11 StartRound_1830.java
> > --- StartRound_1830.java        13 Feb 2008 19:59:03 -0000      1.11
> > +++ StartRound_1830.java        18 Feb 2008 22:43:38 -0000
> > @@ -143,7 +143,13 @@
> >                                 }
> >
> >                         }
> > -
> > +
> > +            /*
> > +             * it is possible that the last unsold item 
> was sold in the above loop.
> > +             * go to next round if that happened
> > +             */
> > +            if (StartPacket.getStartPacket().areAllSold()) 
> return false;
> > +
> >                         if (possibleActions.isEmpty()) {
> >                                 numPasses.add(1);
> >                                 if 
> (auctionItemState.getObject() == null) {
> >
> 
> 
> 
> Applied.  Thanks!
> 
> ---Brett.
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] fix to bug 1870539

[brett l. <wak...@gm...>]

On Feb 18, 2008 2:52 PM, Michał Bażyński <ba...@tl...> wrote:
>
> first of, how to reproduce the bug:
>
> In 18AL, conduct a start round in such a way that there's only one
> bidder for the last private company. you can have every one make a
> single bid on a different private for example, then buy Tusc. Result:
> the application hangs.
>
> Reason:
>    in StockRound_1830.java in setPossibleActions() there's a check if
> there are any unsold companies left before each item is looked at to see
> if it is just auto-sold as there's only one bidder for it.
>
> Solution:
>    add the extra check if any unsold privates remain after looking at
> them all.
>
> Attached is a patch doing just that.
>
> (My first patch, if I should be doing something differently please tell me.)
>
> best regards,
>    mike
>
> ? patch.txt
> Index: StartRound_1830.java
> ===================================================================
> RCS file: /cvsroot/rails/18xx/rails/game/StartRound_1830.java,v
> retrieving revision 1.11
> diff -u -r1.11 StartRound_1830.java
> --- StartRound_1830.java        13 Feb 2008 19:59:03 -0000      1.11
> +++ StartRound_1830.java        18 Feb 2008 22:43:38 -0000
> @@ -143,7 +143,13 @@
>                                 }
>
>                         }
> -
> +
> +            /*
> +             * it is possible that the last unsold item was sold in the above loop.
> +             * go to next round if that happened
> +             */
> +            if (StartPacket.getStartPacket().areAllSold()) return false;
> +
>                         if (possibleActions.isEmpty()) {
>                                 numPasses.add(1);
>                                 if (auctionItemState.getObject() == null) {
>



Applied.  Thanks!

---Brett.

[Rails-devel] fix to bug 1870539

[Michał B. <ba...@tl...>]

first of, how to reproduce the bug:

In 18AL, conduct a start round in such a way that there's only one 
bidder for the last private company. you can have every one make a 
single bid on a different private for example, then buy Tusc. Result: 
the application hangs.

Reason:
   in StockRound_1830.java in setPossibleActions() there's a check if 
there are any unsold companies left before each item is looked at to see 
if it is just auto-sold as there's only one bidder for it.

Solution:
   add the extra check if any unsold privates remain after looking at 
them all.

Attached is a patch doing just that.

(My first patch, if I should be doing something differently please tell me.)

best regards,
   mike

Re: [Rails-devel] [newbie] null pointer in PublicCompany?

[Erik V. <eri...@hc...>]

Apologies for this error. It was caused by work in progress.

I have somewhat reorganized the various XML fragments that dealt with 
tile laying and base token costing, and moved the latter into PublicCompany.
You catched me halfway this move....

I have just committed the above changes and some more bug fixes,
and things look well, although I haven't tested very extensively yet. 
Side-effects on games completed before occasionally happen, 
and we're always grateful for bug reports.

Erik.

> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of brett lentz
> Sent: Sunday 17 February 2008 19:12
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] [newbie] null pointer in PublicCompany?
> 
> On Feb 17, 2008 9:57 AM, Michał Bażyński <ba...@tl...> wrote:
> >
> > Hi,
> >    I have recently played a game of 18AL, found 4 or 5 
> bugs, and decided
> > to try to see if I can fix some of them... I downloaded sources from
> > cvs, and kept on getting a NullPointer right after clicking 
> 'New Game'.
> 
> 
> Welcome!   If you read through the archives for the last two weeks,
> you'll see a
> few posts that will shed light on this. There's some work being done
> to get 18EU
> up and running that has likely destabilized things a bit.
> 
> I'm not aware of this particular NPE happening during the last release
> version, so
> it's likely to be recent commits that did this.
> 
> > So my question: what am I doing wrong? Did I checkout code I wasn't
> > supposed to, and I should check out a branch of a stable 
> version (how?)?
> > Or is the code fine as it is and my NullPointer is me doing 
> something
> > wrong along the way?  I am a bit reluctant to try fixing 
> anything while
> > not understatnding what's the deal with this NullPointer...
> 
> It sounds like you didn't do anything wrong. Just find which 
> variable is
> unexpectedly null, and see if you can put together a patch 
> that fixes it. If
> you want to send us a stack trace, that will help 
> significantly more than a
> code segment.
> 
> >
> > Best regards,
> >    Mike Bazynski
> >
> 
> 
> ---Brett.
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] [newbie] null pointer in PublicCompany?

[brett l. <wak...@gm...>]

On Feb 17, 2008 9:57 AM, Michał Bażyński <ba...@tl...> wrote:
>
> Hi,
>    I have recently played a game of 18AL, found 4 or 5 bugs, and decided
> to try to see if I can fix some of them... I downloaded sources from
> cvs, and kept on getting a NullPointer right after clicking 'New Game'.


Welcome!   If you read through the archives for the last two weeks,
you'll see a
few posts that will shed light on this. There's some work being done
to get 18EU
up and running that has likely destabilized things a bit.

I'm not aware of this particular NPE happening during the last release
version, so
it's likely to be recent commits that did this.

> So my question: what am I doing wrong? Did I checkout code I wasn't
> supposed to, and I should check out a branch of a stable version (how?)?
> Or is the code fine as it is and my NullPointer is me doing something
> wrong along the way?  I am a bit reluctant to try fixing anything while
> not understatnding what's the deal with this NullPointer...

It sounds like you didn't do anything wrong. Just find which variable is
unexpectedly null, and see if you can put together a patch that fixes it. If
you want to send us a stack trace, that will help significantly more than a
code segment.

>
> Best regards,
>    Mike Bazynski
>


---Brett.

[Rails-devel] [newbie] null pointer in PublicCompany?

[Michał B. <ba...@tl...>]

Hi,
   I have recently played a game of 18AL, found 4 or 5 bugs, and decided 
to try to see if I can fix some of them... I downloaded sources from 
cvs, and kept on getting a NullPointer right after clicking 'New Game'. 
I tracked that down to some code in PublicCompany.java that is a cut and 
paste code from CompanyManager.java:

		// BaseToken
		Tag baseTokenTag = tag.getChild("BaseTokens");
		// Cost of laying a token
		Tag layCostTag = baseTokenTag.getChild("LayCost");
		String costMethod = layCostTag.getAttributeAsString("method");
		// Must validate the cost method!

		baseTokenLayCost = layCostTag.getAttributeAsIntegerArray("cost");

		/* Cost of buying a token (mutually exclusive with laying cost) */
		Tag buyCostTag = tag.getChild("BuyCost");
		// We don't have this yet - ignore for now.


         Tag tokenLayTimeTag = tag.getChild("HomeBase");
         if (tokenLayTimeTag != null) {
             String layTimeString = 
tokenLayTimeTag.getAttributeAsString("lay");
             if (Util.hasValue(layTimeString)) {
                 for (int i = 0; i < tokenLayTimeNames.length; i++) {
                     if 
(tokenLayTimeNames[i].equalsIgnoreCase(layTimeString)) {
                         homeBaseTokensLayTime = i;
                         break;
                     }
                 }
             }
         }


(lines 463 to 488 in PublicCompany.java).

Commenting this code out results in everything seemingly working fine...




So my question: what am I doing wrong? Did I checkout code I wasn't 
supposed to, and I should check out a branch of a stable version (how?)? 
Or is the code fine as it is and my NullPointer is me doing something 
wrong along the way?  I am a bit reluctant to try fixing anything while 
not understatnding what's the deal with this NullPointer...

Best regards,
   Mike Bazynski

[Rails-devel] 18EU aspects

[Erik V. <eri...@hc...>]

Against expectations, I have some spare time, and so I'm regularly
committing code to implement aspects of 18EU. The initial Minor selling
round is now done (so you can start practising this complex event), 
as is the start of major companies by converting a minor.

Usually, such additions of new mechanisms have many side-effects, 
so the number of affected classes is almost always substantial.

Erik Vos

Re: [Rails-devel] 1870 Data file patch

[Brett L. <wak...@gm...>]

On Wed, 2008-02-13 at 13:59 -0700, Jeff Bowers wrote:
> Here are two patches to 1870 data files to include the small city in
> H3 and change the cost of 2 trains to $80.  Tell me if I'm doing this
> right.


Patch merged.


 ---Brett.


In computing, the mean time to failure keeps getting shorter.

Re: [Rails-devel] Getting started

[Erik V. <eri...@hc...>]

> On Wed, 2008-02-13 at 13:30 -0700, Jeff Bowers wrote:
> > My question is then, what would you like people to work on? 
>  I'd like
> > to get 1870 up and running.  Is that compatible with your current
> > efforts, or is it something better left for later
> 
> 
> I have no objection to having you work on 1870. Adding new games is a
> great place to start. Just remember to keep as much of the game's
> mechanics as generic and reusable as possible. Things like price
> protection are needed for many games beyond 1870.

You might want to start with configuring the private special properties
in data/1870/CompanyManager.xml.

I suppose that all special properties (except the Bridgeone ) can be 
implemented by just adding XML. Look at the 18AL S&NA private for how 
to configure the bonus tokens (cattle and shipping).
(N.B. The existing "tokens" and "tokenValue" attributes in the XML 
of these privates should be removed and replaced by the SpecialProperty
tags).

The Bridge will require new Java code, as well as all the restrictions
around the Mississippi.

Erik.

[Rails-devel] 1870 Data file patch

[Jeff B. <jef...@gm...>]

Here are two patches to 1870 data files to include the small city in H3 and
change the cost of 2 trains to $80.  Tell me if I'm doing this right.

### Eclipse Workspace Patch 1.0
#P 18xx
Index: data/1870/Map.xml
===================================================================
RCS file: /cvsroot/rails/18xx/data/1870/Map.xml,v
retrieving revision 1.7
diff -u -r1.7 Map.xml
--- data/1870/Map.xml    23 Jan 2007 21:50:53 -0000    1.7
+++ data/1870/Map.xml    13 Feb 2008 20:57:41 -0000
@@ -73,7 +73,7 @@
     <Hex name="G18" tile="0" cost="60"/>
     <Hex name="G20" tile="-1"/>
     <Hex name="H1" tile="0"/>
-    <Hex name="H3" tile="0" cost="40"/>
+    <Hex name="H3" tile="-1" cost="40"/>
     <Hex name="H5" tile="0" cost="40"/>
     <Hex name="H7" tile="0" cost="60"/>
     <Hex name="H9" tile="0"/>
Index: data/1870/Game.xml
===================================================================
RCS file: /cvsroot/rails/18xx/data/1870/Game.xml,v
retrieving revision 1.17
diff -u -r1.17 Game.xml
--- data/1870/Game.xml    11 Dec 2007 20:58:34 -0000    1.17
+++ data/1870/Game.xml    13 Feb 2008 20:57:41 -0000
@@ -32,7 +32,7 @@
             <Reach base="stops" countTowns="major"/>
             <Score towns="yes"/>
         </Defaults>
-        <Train name="2" majorStops="2" cost="100" amount="7"/>
+        <Train name="2" majorStops="2" cost="80" amount="7"/>
         <Train name="3" majorStops="3" cost="180" amount="6"
startPhase="2"/>
         <Train name="4" majorStops="4" cost="300" amount="5" startPhase="3"
             rustedTrain="2"/>

Re: [Rails-devel] Getting started

[Brett L. <wak...@gm...>]

On Wed, 2008-02-13 at 13:30 -0700, Jeff Bowers wrote:
> My question is then, what would you like people to work on?  I'd like
> to get 1870 up and running.  Is that compatible with your current
> efforts, or is it something better left for later


I have no objection to having you work on 1870. Adding new games is a
great place to start. Just remember to keep as much of the game's
mechanics as generic and reusable as possible. Things like price
protection are needed for many games beyond 1870.

Also, here's some other bits that need love, in no particular order:

* Token placement (especially wrt OO cities).
* Map drawing. Resizing the map is currently broken.
* Route calculation (BIG PROJECT) 



 ---Brett.


No one regards what is before his feet; we all gaze at the stars.
		-- Quintus Ennius

Re: [Rails-devel] Getting started

[Jeff B. <jef...@gm...>]

My question is then, what would you like people to work on?  I'd like to get
1870 up and running.  Is that compatible with your current efforts, or is it
something better left for later

On Feb 13, 2008 1:19 PM, Erik Vos <eri...@hc...> wrote:

> Welcome Jeff!
>
> I have just committed a bunch of changes, mostly related to the 18EU start
> round.
> As usual, this has had some consequences in various places,
> so please refresh your sources before you start updating
> (but I haven't touched the 1870 map).
>
> A general warning for Jeff and others: the main goal behind
> all I'm doing is still trying to get the basic program design right.
> That is why I'm currently mostly working on implementing new games
> that have different mechanics than the ones we've already done.
> Fitting in new features often enforces rethinking various design
> aspects, to make it ever more generic.
>
> Although we have already gone a long way, the above still means that
> the code base is not yet as stable as we would like it to be.
> So be warned: often check for updates (I'm saying this to myself as
> well!).
>
> Erik.
>
>
> > -----Original Message-----
> > From: rai...@li...
> > [mailto:rai...@li...] On Behalf
> > Of Brett Lentz
> > Sent: Wednesday 13 February 2008 01:54
> > To: Development list for Rails: an 18xx game
> > Subject: Re: [Rails-devel] Getting started
> >
> >
> > On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> > > Greetings all.  I downloaded Rails today to take a look at it and I
> > > can see that you've put in a lot of work.  I'm interested in
> > > contributing, and while I am an experienced programmer, I
> > haven't used
> > > Java before and I haven't worked on an open source project.
> > >
> > > Anyway, I installed Eclipse, downloaded the rails source, looked
> > > around a bit, found a bug and fixed it.  Now what?
> > >
> > > The change is very minor.  On the 1870 map, hex H3 should be a small
> > > city hex.
> >
> >
> > Welcome aboard Jeff!
> >
> > You're definitely on the right track. While you're getting
> > familiar with
> > the codebase, please try to focus on fixing small-ish issues.
> >
> > For the first few changes, please send patches to the list.
> > Unified diff
> > is the preferred format. Breaking up changes into logical
> > chunks is also
> > recommended.
> >
> > As soon as we've seen a few sets of patches from you, we can
> > talk about
> > giving you direct commit access and letting you drive a bigger segment
> > of the changes. To give a tangible goal, I personally like to see at
> > least 3-5 patches.
> >
> >
> >  ---Brett.
> >
> >
> > Machines certainly can solve problems, store information, correlate,
> > and play games -- but not with pleasure.
> >               -- Leo Rosten
> >
> >
> > --------------------------------------------------------------
> > -----------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Rails-devel mailing list
> > Rai...@li...
> > https://lists.sourceforge.net/lists/listinfo/rails-devel
> >
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
>

Re: [Rails-devel] Getting started

[Erik V. <eri...@hc...>]

Welcome Jeff!

I have just committed a bunch of changes, mostly related to the 18EU start
round.
As usual, this has had some consequences in various places,
so please refresh your sources before you start updating
(but I haven't touched the 1870 map).

A general warning for Jeff and others: the main goal behind
all I'm doing is still trying to get the basic program design right.
That is why I'm currently mostly working on implementing new games
that have different mechanics than the ones we've already done.
Fitting in new features often enforces rethinking various design
aspects, to make it ever more generic.

Although we have already gone a long way, the above still means that
the code base is not yet as stable as we would like it to be.
So be warned: often check for updates (I'm saying this to myself as well!).

Erik.


> -----Original Message-----
> From: rai...@li... 
> [mailto:rai...@li...] On Behalf 
> Of Brett Lentz
> Sent: Wednesday 13 February 2008 01:54
> To: Development list for Rails: an 18xx game
> Subject: Re: [Rails-devel] Getting started
> 
> 
> On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> > Greetings all.  I downloaded Rails today to take a look at it and I
> > can see that you've put in a lot of work.  I'm interested in
> > contributing, and while I am an experienced programmer, I 
> haven't used
> > Java before and I haven't worked on an open source project.
> > 
> > Anyway, I installed Eclipse, downloaded the rails source, looked
> > around a bit, found a bug and fixed it.  Now what?
> > 
> > The change is very minor.  On the 1870 map, hex H3 should be a small
> > city hex.
> 
> 
> Welcome aboard Jeff!
> 
> You're definitely on the right track. While you're getting 
> familiar with
> the codebase, please try to focus on fixing small-ish issues. 
> 
> For the first few changes, please send patches to the list. 
> Unified diff
> is the preferred format. Breaking up changes into logical 
> chunks is also
> recommended.
> 
> As soon as we've seen a few sets of patches from you, we can 
> talk about
> giving you direct commit access and letting you drive a bigger segment
> of the changes. To give a tangible goal, I personally like to see at
> least 3-5 patches.
> 
> 
>  ---Brett.
> 
> 
> Machines certainly can solve problems, store information, correlate,
> and play games -- but not with pleasure.
> 		-- Leo Rosten
> 
> 
> --------------------------------------------------------------
> -----------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rails-devel mailing list
> Rai...@li...
> https://lists.sourceforge.net/lists/listinfo/rails-devel
> 

Re: [Rails-devel] Getting started

[Brett L. <wak...@gm...>]

On Tue, 2008-02-12 at 16:51 -0700, Jeff Bowers wrote:
> Greetings all.  I downloaded Rails today to take a look at it and I
> can see that you've put in a lot of work.  I'm interested in
> contributing, and while I am an experienced programmer, I haven't used
> Java before and I haven't worked on an open source project.
> 
> Anyway, I installed Eclipse, downloaded the rails source, looked
> around a bit, found a bug and fixed it.  Now what?
> 
> The change is very minor.  On the 1870 map, hex H3 should be a small
> city hex.


Welcome aboard Jeff!

You're definitely on the right track. While you're getting familiar with
the codebase, please try to focus on fixing small-ish issues. 

For the first few changes, please send patches to the list. Unified diff
is the preferred format. Breaking up changes into logical chunks is also
recommended.

As soon as we've seen a few sets of patches from you, we can talk about
giving you direct commit access and letting you drive a bigger segment
of the changes. To give a tangible goal, I personally like to see at
least 3-5 patches.


 ---Brett.


Machines certainly can solve problems, store information, correlate,
and play games -- but not with pleasure.
		-- Leo Rosten

[Rails-devel] Getting started

[Jeff B. <jef...@gm...>]

Greetings all.  I downloaded Rails today to take a look at it and I can see
that you've put in a lot of work.  I'm interested in contributing, and while
I am an experienced programmer, I haven't used Java before and I haven't
worked on an open source project.

Anyway, I installed Eclipse, downloaded the rails source, looked around a
bit, found a bug and fixed it.  Now what?

The change is very minor.  On the 1870 map, hex H3 should be a small city
hex.