Menu
▾
▴
rails-devel — List for discussion of Rails development
You can subscribe to this list here.
| 2005 |
Jan
|
Feb
(25) |
Mar
(84) |
Apr
(76) |
May
(25) |
Jun
(1) |
Jul
(28) |
Aug
(23) |
Sep
(50) |
Oct
(46) |
Nov
(65) |
Dec
(76) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2006 |
Jan
(60) |
Feb
(33) |
Mar
(4) |
Apr
(17) |
May
(16) |
Jun
(18) |
Jul
(131) |
Aug
(11) |
Sep
(1) |
Oct
|
Nov
(1) |
Dec
(5) |
| 2007 |
Jan
(71) |
Feb
|
Mar
|
Apr
|
May
(6) |
Jun
(19) |
Jul
(40) |
Aug
(38) |
Sep
(7) |
Oct
(58) |
Nov
|
Dec
(10) |
| 2008 |
Jan
(17) |
Feb
(27) |
Mar
(12) |
Apr
(1) |
May
(50) |
Jun
(10) |
Jul
|
Aug
(15) |
Sep
(24) |
Oct
(64) |
Nov
(115) |
Dec
(47) |
| 2009 |
Jan
(30) |
Feb
(1) |
Mar
|
Apr
|
May
(2) |
Jun
|
Jul
(5) |
Aug
|
Sep
|
Oct
(4) |
Nov
(132) |
Dec
(93) |
| 2010 |
Jan
(266) |
Feb
(120) |
Mar
(168) |
Apr
(127) |
May
(83) |
Jun
(93) |
Jul
(77) |
Aug
(77) |
Sep
(86) |
Oct
(30) |
Nov
(4) |
Dec
(22) |
| 2011 |
Jan
(48) |
Feb
(81) |
Mar
(198) |
Apr
(174) |
May
(72) |
Jun
(101) |
Jul
(236) |
Aug
(144) |
Sep
(54) |
Oct
(132) |
Nov
(94) |
Dec
(111) |
| 2012 |
Jan
(135) |
Feb
(166) |
Mar
(86) |
Apr
(85) |
May
(137) |
Jun
(83) |
Jul
(54) |
Aug
(29) |
Sep
(49) |
Oct
(37) |
Nov
(8) |
Dec
(6) |
| 2013 |
Jan
(2) |
Feb
|
Mar
(1) |
Apr
(14) |
May
(5) |
Jun
(15) |
Jul
|
Aug
(38) |
Sep
(44) |
Oct
(45) |
Nov
(40) |
Dec
(23) |
| 2014 |
Jan
(22) |
Feb
(63) |
Mar
(43) |
Apr
(60) |
May
(10) |
Jun
(5) |
Jul
(13) |
Aug
(57) |
Sep
(36) |
Oct
(2) |
Nov
(30) |
Dec
(27) |
| 2015 |
Jan
(5) |
Feb
(2) |
Mar
(14) |
Apr
(3) |
May
|
Jun
(3) |
Jul
(10) |
Aug
(63) |
Sep
(31) |
Oct
(26) |
Nov
(11) |
Dec
(6) |
| 2016 |
Jan
|
Feb
(11) |
Mar
|
Apr
|
May
(1) |
Jun
(16) |
Jul
|
Aug
(4) |
Sep
|
Oct
(1) |
Nov
(4) |
Dec
(1) |
| 2017 |
Jan
(2) |
Feb
|
Mar
(1) |
Apr
|
May
(1) |
Jun
(20) |
Jul
(4) |
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
| 2018 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(6) |
Nov
|
Dec
|
| 2019 |
Jan
|
Feb
|
Mar
|
Apr
(10) |
May
(10) |
Jun
(1) |
Jul
|
Aug
|
Sep
(1) |
Oct
|
Nov
|
Dec
|
| 2020 |
Jan
|
Feb
|
Mar
(3) |
Apr
(9) |
May
|
Jun
(1) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(7) |
Dec
(4) |
| 2021 |
Jan
(5) |
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: Erik V. <eri...@xs...> - 2011-05-10 15:55:15
|
> -----Oorspronkelijk bericht----- > Van: Phil Davies [mailto:de...@gm...] > If you just choose 'File -> Autosave/load' nothing happens. I had to set both > a save folder and a Local Player name in the Configuration dialogue before > this would present me with the autosave box. I imagine this is intentional > since those settings would be required but better error handling might help > new users. The intention was to display a message "You cannot activate AutoSave/Load without setting local.player.name", but I now see why that doesn't work. Thinking about that, perhaps I should always display the dialog, and add the local player name and the save directory. That would allowing input of both at that time (any known values would be presented as defaults). Erik. |
|
From: Phil D. <de...@gm...> - 2011-05-10 15:43:40
|
Aha, might be a key issue, I didn't realise that was how it was tracking what the latest file was. I was hoping I could just manually drop a new file in there from another machine and have it see that but the .last_rails needs to be updated too. Will test further with this knowledge! Phil On 10 May 2011 16:38, Erik Vos <eri...@xs...> wrote: >> -----Oorspronkelijk bericht----- >> Van: Phil Davies [mailto:de...@gm...] > >> Autoload doesn't appear to work at all, I can File -> Reload and it works > fine >> but rails isn't automatically spotting that a new file has appeared in > Dropbox, >> am I missing a setting? > > The autoload poller loop reads the file with extension .last_rails (must be > in the same save directory). That file contains the name of the last saved > file, and is updated at each autosave. If that name changes, the autoload > should be executed. > > Does that .last_rails file exist, and do the contents change? > Do you have a Rails log file with debug info? > > BTW I have only tested on the local file system, not with Dropbox so far. I > have added a command-line property to set the local user name (like > -Dlocal.player.name=Alice) so I can run multiple Rails copies for different > players in parallel. > > Erik. > > > > > ------------------------------------------------------------------------------ > Achieve unprecedented app performance and reliability > What every C/C++ and Fortran developer should know. > Learn how Intel has extended the reach of its next-generation tools > to help boost performance applications - inlcuding clusters. > http://p.sf.net/sfu/intel-dev2devmay > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Erik V. <eri...@xs...> - 2011-05-10 15:38:44
|
> -----Oorspronkelijk bericht----- > Van: Phil Davies [mailto:de...@gm...] > Autoload doesn't appear to work at all, I can File -> Reload and it works fine > but rails isn't automatically spotting that a new file has appeared in Dropbox, > am I missing a setting? The autoload poller loop reads the file with extension .last_rails (must be in the same save directory). That file contains the name of the last saved file, and is updated at each autosave. If that name changes, the autoload should be executed. Does that .last_rails file exist, and do the contents change? Do you have a Rails log file with debug info? BTW I have only tested on the local file system, not with Dropbox so far. I have added a command-line property to set the local user name (like -Dlocal.player.name=Alice) so I can run multiple Rails copies for different players in parallel. Erik. |
|
From: Scott P. <sc...@re...> - 2011-05-10 15:18:13
|
On Mon, May 9, 2011 at 9:19 PM, brett lentz <bre...@gm...> wrote: > Yes you can, and you now have. :-) > Thanks, Brett. I reworked my 18Scan writeup and posted it to the wiki: https://sourceforge.net/apps/mediawiki/rails/index.php?title=18Scan I tried to break the special rules down depending on whether it looked like they would need major or minor work to implement. |
|
From: Phil D. <de...@gm...> - 2011-05-10 13:23:14
|
Erik, Some brief feedback from testing over the last couple of days: If you just choose 'File -> Autosave/load' nothing happens. I had to set both a save folder and a Local Player name in the Configuration dialogue before this would present me with the autosave box. I imagine this is intentional since those settings would be required but better error handling might help new users. Autosave seems to work perfectly fine, since I'm still playing over normal PBEM I'm slightly mourning the loss of the 'auto copy to clipboard functionality that comes from a manual save, but I don't personally think it's a good idea to just assume if you have autosave on to grab a copy of the last moves every time, in practice I would think this would be used for more realtime gaming. Autoload doesn't appear to work at all, I can File -> Reload and it works fine but rails isn't automatically spotting that a new file has appeared in Dropbox, am I missing a setting? Phil On 4 May 2011 20:38, Erik Vos <eri...@xs...> wrote: > I have committed code to tighten the new Autosave/load feature, primarily > for Dropbox users. It now does the job in most, but not yet in all cases. > > Aspects that need more work: > > - It is sometimes hard to see who has the turn and what is the active window > or dialog. Not sure how to address that; I'm currently considering an > extra line in the Status window (above the menu) that mentions: the local > player name, the current player name, the active window, and the active > dialog name (if any). > > - The (currently fixed) popup that informs a player that it is his turn > again often does not show up; I haven't yet investigated why. > > - When a player loses the turn, most menu items and buttons are now > disabled, but not yet all of these. > > - For clarity, in particular during testing, I found it necessary to center > popup dialogs on the currently active window. This has not yet been > accomplished for all dialogs yet. > > - I know of one case where a question is asked to a different player than > the one who must answer it: in 18EU, when a minor merges with a company that > has a different president, the question whether or not the minor home base > token must be exchanged or not is put to the former minor company president > rather than to the major company president who must in fact answer it. This > is not easy to change, as it is hardcoded in the UI rather than handled by > the game engine. > It is quite possible that more such cases exist; I'd be grateful for > reports. > > I now above all need feedback from users to what extent this all works or > does not work for them. > > Erik. > > > ------------------------------------------------------------------------------ > WhatsUp Gold - Download Free Network Management Software > The most intuitive, comprehensive, and cost-effective network > management toolset available today. Delivers lowest initial > acquisition cost and overall TCO of any competing solution. > http://p.sf.net/sfu/whatsupgold-sd > _______________________________________________ > Rails-devel mailing list > Rai...@li... > https://lists.sourceforge.net/lists/listinfo/rails-devel > |
|
From: Erik V. <eri...@xs...> - 2011-05-10 10:45:02
|
> -----Oorspronkelijk bericht----- > Van: Dr....@t-... [mailto:Dr....@t-...] > Did you find the point where i went wrong so that theres no action available > to the priority player in the first Stockround yet ? Yes: you are calling finishRound() inside StartRound_1880.setPossibleActions(). That's too late: any round change must be completed *before* setPossibleActions() is called. Now your StockRound_1880.setPossibleActions() is not called at all. To fix this, you should make StartPacket.areAllSold() return true. That will trigger the StockRound at the right point. To make that possible, I have added a new stub startPacketChecks() to StartRound. You should override this method and move your code to discard the remaining minors into it. Alternatively, you could subclass buy() and handle it there. The latter would in fact be the normal procedure, but in this case I believe it makes sense to create a separate method for such checks. Erik. |
|
From: brett l. <bre...@gm...> - 2011-05-10 02:20:00
|
On Mon, May 9, 2011 at 6:35 PM, Scott Petersen <sc...@re...> wrote: > On Sun, May 8, 2011 at 11:14 AM, Erik Vos <eri...@xs...> wrote: >> >> - What about the ferry? I’m considering to copy the narrow-gauge >> tile 77 to a new preprinted tile with a blue background. > > Yes, that will look like the physical game. I also notice that tiles 80-83 > and 544-546 have the convoluted track rather than the stick track. I > checked 18EU as an example, but I don't see a difference in how the XML is > set up. > I attached a patch that takes 18Scan about as far as I can take it for the > time being. > Here are some notes about special rules for 18Scan that I have not > implemented. Perhaps they can go to the wiki--I do not have rights to edit > the wiki. Could I be granted rights? Yes you can, and you now have. :-) ---Brett. |
|
From: Scott P. <sc...@re...> - 2011-05-09 13:31:01
|
On Sun, May 8, 2011 at 1:56 PM, Dr....@t-... < Dr....@t-...> wrote: > i took the liberty to fix the map for Scott. I am currently stuck at > certain parts in 1880 anyway :) > Thanks, Martin. Are you familiar with the rules to 18Scan? Maybe there are some items which you can implement with Java code and take some of the burden off Erik. :-) |
|
From: Erik V. <eri...@xs...> - 2011-05-08 20:43:27
|
> -----Oorspronkelijk bericht----- > Van: Dr....@t-... [mailto:Dr....@t-...] > Verzonden: zondag 8 mei 2011 22:31 > Aan: Erik Vos > CC: Rails Development > Onderwerp: Re: [Rails-devel] Correction for Gamemanager > > Hi Erik, > > you are free to change what you think needs changing :) (Remember i am > the apprentice here :)) > > For 1880 its just that way you implemented it. But some other game might > need another way around ? Setting ascending to false will sort descending. It's the same as your 'high' but 'ascending' is much clearer, at least to me. > On the UI Part, why cant we reinitialise the Game Status Window the same > way the OR Window gets reinitialised ? Sure, but that doesn't mean that it's simple. I didn't say that we can't, I just wondered if it's worthwhile. In fact I tend to the opinion that we should reorder the GameStatus UI indeed, but it isn't urgent. I would probably only recreate the player columns. > And the only things that change in the altered order are the Investor/Minors, > and they get assigned the right way, and cost no money :) > > Did you find the point where i went wrong so that theres no action available > to the priority player in the first Stockround yet ? I noticed, but I have not looked into that yet. Erik. |
|
From: Erik V. <eri...@xs...> - 2011-05-08 20:34:43
|
Van: Dr....@t-... [mailto:Dr....@t-...] i am currently looking into linking the stockmarket position into the revenue calculation. And i admit i got lost in the process how Rails currently tries to calculate and setup the dividends. I "think" the process gets started in the ORUIManager and from there ends up in OperatingRound.java not without to touch a number of action classes and PublicCompany.java.. :) Yes, the revenue is currently calculated and/or manually entered in the UI. I don’t know if this will stay so, but that’s how it currently works. I’m not at all familiar with that code. It has been developed by Stefan Frey, who has not been active during the past months. Hopefully he will return. Where would you suggest to add a hook to determine the stockposition and the derived revenuebonus ? It shouldnt go into RevenueCalculator as that Class is based on the available trains... Or ? Any bonuses should be added in the revenue calculation algorithms (or added manually). I suppose you are referring to the +5, +10 etc. indicators in the Stock Chart? This can be made configurable by adding an attribute like ‘bonus=”50”’, ‘bonus=”100”’ etc. to the relevant stock chart cells in the XML, and to add a getRunBonus() getter to make it retrievable. I have no problem calling this from the UI, as it is static information. And I also see no problem making this generic, as it’s just one atrtribute and a few lines of code. Other bonuses may need special code, unless Stefan has already created standard ways to do this. I’m afraid I will have to refer to him for now. And while i am at it: Do you have any idea/clue for me how to handle the jump from an OR to the Stockround after a "train rush"/rust ? Would the PrussionFormationRound mechanismn be a possible path to follow ? Cause honestly i am still trying to find my way between the different handling ways and actions in the different Parts :) Exactly. In a GameManager subclass you should suppress the usual SR/OR sequence, running just OR’s forever. And the Prussian formation round initiation in OperatingRound_1835.newPhaseChecks() is probably a very good example for how to initiate stock rounds in 1880. Erik. Van: Dr....@t-... [mailto:Dr....@t-...] Verzonden: zondag 8 mei 2011 17:56 Aan: Erik Vos Onderwerp: Stockmarket Permanent Revenue 1880 Hi Erik, i am currently looking into linking the stockmarket position into the revenue calculation. And i admit i got lost in the process how Rails currently tries to calculate and setup the dividends. I "think" the process gets started in the ORUIManager and from there ends up in OperatingRound.java not without to touch a number of action classes and PublicCompany.java.. :) Where would you suggest to add a hook to determine the stockposition and the derived revenuebonus ? It shouldnt go into RevenueCalculator as that Class is based on the available trains... Or ? And while i am at it: Do you have any idea/clue for me how to handle the jump from an OR to the Stockround after a "train rush"/rust ? Would the PrussionFormationRound mechanismn be a possible path to follow ? Cause honestly i am still trying to find my way between the different handling ways and actions in the different Parts :) Regards, Martin |
|
From: <Dr....@t-...> - 2011-05-08 20:31:05
|
Hi Erik,
you are free to change what you think needs changing :) (Remember i am the apprentice here :))
For 1880 its just that way you implemented it. But some other game might need another way around ?
On the UI Part, why cant we reinitialise the Game Status Window the same way the OR Window gets reinitialised ?
And the only things that change in the altered order are the Investor/Minors, and they get assigned the right way, and cost no money :)
Did you find the point where i went wrong so that theres no action available to the priority player in the first Stockround yet ?
Regards,
Martin
-----Original-Nachricht-----
Subject: RE: [Rails-devel] Correction for Gamemanager
Date: Sun, 08 May 2011 22:11:41 +0200
From: "Erik Vos" <eri...@xs...>
To: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...>
Martin,
OK, it seems to work fine now. I have it all checked in.
I have taken the liberty to stay with my own version of the reordering procedure. I have replaced the unclear ‘high’ by ‘ascending’, because that’s what it turns out to mean.
My previous code proposal was wrong because I had overlooked that an anonymous class instance can only access final variables defined outside of it. That’s fixed now.
On the UI, I’m currently in doubt if it is worthwhile to change the player order. No doubt it’s possible, but it’ll take quite some work.
Let’s first check if all data in the player columns still ends up being in the right place. The cash is OK, I haven’t checked the rest yet.
Erik.
Van: Dr....@t-... [mailto:Dr....@t-...]
Verzonden: zaterdag 7 mei 2011 9:17
Aan: Rails Development
Onderwerp: [Rails-devel] Correction for Gamemanager
Hi Erik et al.
a new version of the routine to reorder the players. Had some unnecessary code.
public Player reorderPlayersByCash(boolean high) {
Player player;
if (high) {
Collections.sort (players, new Comparator<Player>() {
public int compare (Player p1, Player p2) {
return ( p1.getCash() > p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));
}
});
}
else {
Collections.sort (players, new Comparator<Player>() {
public int compare (Player p1, Player p2) {
return ( p1.getCash() < p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));
}
});
}
setCurrentPlayer(players.get(0));
for (int i=0; i<players.size(); i++) {
player = players.get(i);
player.setIndex(i);
playerNames.set(i, player.getName());
}
return players.get(0);
}
Regards,
Martin
|
|
From: Erik V. <eri...@xs...> - 2011-05-08 20:11:54
|
Martin,
OK, it seems to work fine now. I have it all checked in.
I have taken the liberty to stay with my own version of the reordering procedure. I have replaced the unclear ‘high’ by ‘ascending’, because that’s what it turns out to mean.
My previous code proposal was wrong because I had overlooked that an anonymous class instance can only access final variables defined outside of it. That’s fixed now.
On the UI, I’m currently in doubt if it is worthwhile to change the player order. No doubt it’s possible, but it’ll take quite some work.
Let’s first check if all data in the player columns still ends up being in the right place. The cash is OK, I haven’t checked the rest yet.
Erik.
Van: Dr....@t-... [mailto:Dr....@t-...]
Verzonden: zaterdag 7 mei 2011 9:17
Aan: Rails Development
Onderwerp: [Rails-devel] Correction for Gamemanager
Hi Erik et al.
a new version of the routine to reorder the players. Had some unnecessary code.
public Player reorderPlayersByCash(boolean high) {
Player player;
if (high) {
Collections.sort (players, new Comparator<Player>() {
public int compare (Player p1, Player p2) {
return ( p1.getCash() > p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));
}
});
}
else {
Collections.sort (players, new Comparator<Player>() {
public int compare (Player p1, Player p2) {
return ( p1.getCash() < p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));
}
});
}
setCurrentPlayer(players.get(0));
for (int i=0; i<players.size(); i++) {
player = players.get(i);
player.setIndex(i);
playerNames.set(i, player.getName());
}
return players.get(0);
}
Regards,
Martin
|
|
From: Erik V. <eri...@xs...> - 2011-05-08 19:57:57
|
Martin, Thanks. The last revision actually was 1550. I’m now at 1554 (commits get split because SVN is playing tricks with me –checksum mismatches and other misery. Not sure what’s wrong). Scott, The map looks fine now, and miraculously the impassable hex sides are now also correct. Probably the old coordinate system is not handled correctly yet). Erik. Van: Dr....@t-... [mailto:Dr....@t-...] Verzonden: zondag 8 mei 2011 21:22 Aan: Development list for Rails: an 18xx game Onderwerp: Re: [Rails-devel] 18Scan Map fixed -> Patch Hi Erik, the patch went against version 1547 i updated my working copy right before editing and that was the latest version avail. I'll recheck ,.. still says version 1547 for 18Scan and thats the version the file is against. Heres the new file in full glory. -----Original-Nachricht----- Subject: Re: [Rails-devel] 18Scan Map fixed -> Patch Date: Sun, 08 May 2011 21:01:27 +0200 From: "Erik Vos" <eri...@xs...> To: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...> Thanks, but the patch does not seem to be correct. I'm getting an error message: "The patch you are applying has segments that did not match". Not sure what's wrong - are you sure you have updated to the last version? I did come changes to Map.xml earlier today. Erik. > -----Oorspronkelijk bericht----- > Van: Dr....@t-... [mailto:Dr....@t-...] > Verzonden: zondag 8 mei 2011 20:56 > Aan: Rails Development > Onderwerp: [Rails-devel] 18Scan Map fixed -> Patch > > Hi Guys, > > i took the liberty to fix the map for Scott. I am currently stuck at certain parts > in 1880 anyway :) > > Regards, > Martin ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Rails-devel mailing list Rai...@li... https://lists.sourceforge.net/lists/listinfo/rails-devel |
|
From: <Dr....@t-...> - 2011-05-08 19:21:49
|
<html><head><title></title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/></head><body><p><span style="font-family: arial,helvetica,sans-serif; color: #000000;"> </span></p> <p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Hi Erik,</span></p> <p> </p> <p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">the patch went against version 1547 i updated my working copy right before editing and that was the latest version avail.</span></p> <p> </p> <p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">I'll recheck ,.. still says version 1547 for 18Scan and thats the version the file is against. </span></p> <p> </p> <p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Heres the new file in full glory.<br /></span></p> <p> </p> <p> </p> <p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">-----Original-Nachricht-----<br /> Subject: Re: [Rails-devel] 18Scan Map fixed -> Patch<br /> Date: Sun, 08 May 2011 21:01:27 +0200<br /> From: "Erik Vos" <eri...@xs...><br /> To: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...><br /> <br /> Thanks, but the patch does not seem to be correct. I'm getting an error message: "The patch you are applying has segments that did not match". Not sure what's wrong - are you sure you have updated to the last version? I did come changes to Map.xml earlier today.<br /> <br /> Erik.<br /> <br /> > -----Oorspronkelijk bericht-----<br /> > Van: Dr....@t-... [mailto:Dr....@t-...]<br /> > Verzonden: zondag 8 mei 2011 20:56<br /> > Aan: Rails Development<br /> > Onderwerp: [Rails-devel] 18Scan Map fixed -> Patch<br /> > <br /> > Hi Guys,<br /> > <br /> > i took the liberty to fix the map for Scott. I am currently stuck at certain parts<br /> > in 1880 anyway :)<br /> > <br /> > Regards,<br /> > Martin<br /> <br /> <br /> ------------------------------------------------------------------------------<br /> WhatsUp Gold - Download Free Network Management Software<br /> The most intuitive, comprehensive, and cost-effective network <br /> management toolset available today. Delivers lowest initial <br /> acquisition cost and overall TCO of any competing solution.<br /> http://p.sf.net/sfu/whatsupgold-sd<br /> _______________________________________________<br /> Rails-devel mailing list<br /> Rai...@li...<br /> https://lists.sourceforge.net/lists/listinfo/rails-devel<br /> </span></p> <p> </p></body></html> |
|
From: Erik V. <eri...@xs...> - 2011-05-08 19:01:40
|
Thanks, but the patch does not seem to be correct. I'm getting an error message: "The patch you are applying has segments that did not match". Not sure what's wrong - are you sure you have updated to the last version? I did come changes to Map.xml earlier today. Erik. > -----Oorspronkelijk bericht----- > Van: Dr....@t-... [mailto:Dr....@t-...] > Verzonden: zondag 8 mei 2011 20:56 > Aan: Rails Development > Onderwerp: [Rails-devel] 18Scan Map fixed -> Patch > > Hi Guys, > > i took the liberty to fix the map for Scott. I am currently stuck at certain parts > in 1880 anyway :) > > Regards, > Martin |
|
From: <Dr....@t-...> - 2011-05-08 18:56:36
|
Hi Guys, i took the liberty to fix the map for Scott. I am currently stuck at certain parts in 1880 anyway :) Regards, Martin |
|
From: Scott P. <sc...@re...> - 2011-05-08 17:56:00
|
On Sun, May 8, 2011 at 12:42 PM, Erik Vos <eri...@xs...> wrote: > Scott, did you look at the playtest map when you created Map.xml? > I looked at an image on BGG for ease of inputting the information. Then I spot checked it against my physical copy, but missed the coordinate change. I'll submit a patch to fix it sometime soon. |
|
From: Erik V. <eri...@xs...> - 2011-05-08 17:42:41
|
Indeed I also have a playtest version of 18Scan, which indeed also has a #363. I cannot have mixed up the tiles, because the playtests tiles are significantly smaller, but the point is that both have number #363. You really have shipped me a #363 tile! (Or probably you have handed it over to me (hidden in the 18Scan box) when we briefly met in Essen). However, I don’t mind about that – the main thing is that it’s now clear that #403 is the official number of this tile. But a look at the playtest map resolves my other question: it had the coordinates that Scott has now been using, with the letters horizontally. The shipped map has the letters vertically. Scott, did you look at the playtest map when you created Map.xml? Erik. Van: John A. Tamplin [mailto:ja...@ja...] Verzonden: zondag 8 mei 2011 19:09 Aan: Development list for Rails: an 18xx game Onderwerp: Re: [Rails-devel] 18Scan On Sun, May 8, 2011 at 12:14 PM, Erik Vos <eri...@xs...> wrote: - Tile 403 (Copenhagen yellow): that’s indeed the number of this tile in the rulebook and in the Tile Encyclopedia, but strange enough the physical tile I have bears number 363. I suppose #363 is an old and superseded number of this tile? (perhaps John Tamplin can also comment on the above two issues?) I have no idea -- as far as I know, I have never shipped anything with any number besides #403 for this tile. Perhaps you made a copy when it was print-and-play during betatesting? David generally doesn't use new numbers if the only difference is the label, but I do. -- John A. Tamplin |
|
From: John A. T. <ja...@ja...> - 2011-05-08 17:09:21
|
On Sun, May 8, 2011 at 12:14 PM, Erik Vos <eri...@xs...> wrote: > - Tile 403 (Copenhagen yellow): that’s indeed the number of this > tile in the rulebook and in the Tile Encyclopedia, but strange enough the > physical tile I have bears number 363. > > I suppose #363 is an old and superseded number of this tile? > > (perhaps John Tamplin can also comment on the above two issues?) > I have no idea -- as far as I know, I have never shipped anything with any number besides #403 for this tile. Perhaps you made a copy when it was print-and-play during betatesting? David generally doesn't use new numbers if the only difference is the label, but I do. -- John A. Tamplin |
|
From: Erik V. <eri...@xs...> - 2011-05-08 16:15:02
|
Scott,
I have added these files. The following remarks apply:
- The Stockholm preprinted tile has got number -10004.
Functionally, it duplicates the 1835 Berlin tile -806, but the latter has a
'B ' imprint.
- The Copenhagen upgrades have got (internal) numbers 1121 and
1584, as the (external) numbers 121 and 584 duplicate existing tiles.
The following issues remain:
- You have submitted a map with the letters horizontally, but my
physical map has the letters vertically, as well as the back side of my
rulebook. How come?
For instance, you have Stockholm on hex K6, whereas I have this city on hex
F11.
- Tile 403 (Copenhagen yellow): that's indeed the number of this
tile in the rulebook and in the Tile Encyclopedia, but strange enough the
physical tile I have bears number 363.
I suppose #363 is an old and superseded number of this tile?
(perhaps John Tamplin can also comment on the above two issues?)
- What about the ferry? I'm considering to copy the narrow-gauge
tile 77 to a new preprinted tile with a blue background.
- I can't comment on the impassable hex sides problem until we
have resolved the map orientation issue.
Erik.
Van: Scott Petersen [mailto:sc...@re...]
Verzonden: zaterdag 7 mei 2011 17:22
Aan: Development list for Rails: an 18xx game
Onderwerp: [Rails-devel] 18Scan
On Wed, May 4, 2011 at 3:40 PM, Erik Vos <eri...@xs...> wrote:
And on my own wish list I have more of the Hecht games, generally my
favourites, where I'm in particular looking at 1826 and 18Scan.
I attached the start of the XML files for 18Scan. There are still a lot of
parameters to add to Game.xml/CompanyManager.xml, but that will be easier
when the Tiles.xml file exists--Erik could you create one? The new special
tiles are the COP sequence and the Stockholm preprinted tile (which I'm
guessing will need to be added). I guess I don't care whether the special
tiles are implemented right now as I can generally work on the finishing the
XML without them.
There are some problems with the impassable hexsides.
Here is some text to add to Gameslist
<Game name="18Scan">
<Note>Prototype</Note>
<Description>18Scan</Description>
<Players minimum="2" maximum="4" />
</Game>
|
|
From: <Dr....@t-...> - 2011-05-07 07:17:28
|
<html><head><title></title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/></head><body><p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Hi Erik et al.</span></p>
<p> </p>
<p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">a new version of the routine to reorder the players. Had some unnecessary code.</span></p>
public Player reorderPlayersByCash(boolean high) {<br /> Player player;<br /> if (high) {<br /> Collections.sort (players, new Comparator<Player>() {<br /> public int compare (Player p1, Player p2) {<br /> return ( p1.getCash() > p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));<br /> }<br /> });<br /> }<br /> else {<br /> Collections.sort (players, new Comparator<Player>() {<br /> public int compare (Player p1, Player p2) {<br /> return ( p1.getCash() < p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));<br /> }<br /> });<br /> }<br /> setCurrentPlayer(players.get(0));<br /> for (int i=0; i<players.size(); i++) {<br /> player = players.get(i);<br /> player.setIndex(i);<br /> playerNames.set(i, player.getName());<br /><br /> }<br /> return players.get(0);<br /> }<br /> <br />
<p> </p>
<p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Regards,</span></p>
<p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Martin<br /></span></p></body></html> |
|
From: <Dr....@t-...> - 2011-05-06 20:37:22
|
<html><head><title></title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/></head><body><p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">Hi Erik, et al.<br /></span></p>
<p> </p>
<p>sorry i forgot to append two patches :( and the investor_1880 class.</p>
<p> </p>
<p>Heres the corrected version.</p>
<p> </p>
<p>The investor class is not yet used besides its defined. It should later on handle and carry the specific methods for manipulating the investor properties...</p>
<p> </p>
<p> </p>
<p>Hope you like this more :)</p>
<p> </p>
<p>/*<br /> *<br /> *@param high Boolean to determine if the playerlist will be sorted in ascending or descending order based on their cash<br /> *@return Returns the player at index position 0 that is either the player with the most or least cash depending on sort order. <br /> */</p>
<p>public Player reorderPlayersByCash(boolean high) {<br /> Player player;<br /> if (high) {<br /> Collections.sort (players, new Comparator<Player>() {<br /> public int compare (Player p1, Player p2) {<br /> return ( p1.getCash() > p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));<br /> }<br /> });<br /> }<br /> else {<br /> Collections.sort (players, new Comparator<Player>() {<br /> public int compare (Player p1, Player p2) {<br /> return ( p1.getCash() > p2.getCash() ? 1 : (p2.getCash() == p1.getCash() ? 0: -1));<br /> }<br /> });<br /> Collections.reverse (players);<br /> }<br /> setCurrentPlayer(players.get(0));<br /> for (int i=0; i<players.size(); i++) {<br /> player = players.get(i);<br /> player.setIndex (i);<br /> playerNames.set (i, player.getName());<br /><br /> }<br /> return players.get(0);<br /> }</p>
<p> </p>
<p>Problem is the display order in the UI isnt changed, thus the wrong player gets shown as being on turn... BUt the code actually assigns the right action result to the right player, but doesnt adjust the turn order in the UI.</p>
<p> </p>
<p>Regards,</p>
<p>Martin</p>
<p><br /> -----Original-Nachricht-----<br /> Subject: Re: [Rails-devel] Status update 1880<br /> Date: Fri, 06 May 2011 00:45:16 +0200<br /> From: "Erik Vos" <eri...@xs...><br /> To: <Dr....@t-...>, "'Development list for Rails: an 18xx game'" <rai...@li...><br /> <br /></p>
<p><span style="font-family: arial,helvetica,sans-serif; color: #000000;">
<div style="position: relative;">
<style><!--
/* Font Definitions */ @font-face {font-family:Wingdings; panose-1:5 0 0 0 0 0 0 0 0 0;} @font-face {font-family:Wingdings; panose-1:5 0 0 0 0 0 0 0 0 0;} @font-face {font-family:Calibri; panose-1:2 15 5 2 2 2 4 3 2 4;} @font-face {font-family:Tahoma; panose-1:2 11 6 4 3 5 4 4 2 4;} /* Style Definitions */ p.MsoNormal, li.MsoNormal, div.MsoNormal {margin:0cm; margin-bottom:.0001pt; font-size:12.0pt; font-family:"Times New Roman","serif";} a:link, span.MsoHyperlink {mso-style-priority:99; color:blue; text-decoration:underline;} a:visited, span.MsoHyperlinkFollowed {mso-style-priority:99; color:purple; text-decoration:underline;} p {mso-style-priority:99; mso-margin-top-alt:auto; margin-right:0cm; mso-margin-bottom-alt:auto; margin-left:0cm; font-size:12.0pt; font-family:"Times New Roman","serif";} p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph {mso-style-priority:34; margin-top:0cm; margin-right:0cm; margin-bottom:0cm; margin-left:36.0pt; margin-bottom:.0001pt; font-size:12.0pt; font-family:"Times New Roman","serif";} span.E-mailStijl18 {mso-style-type:personal-reply; font-family:"Calibri","sans-serif"; color:#1F497D;} .MsoChpDefault {mso-style-type:export-only; font-size:10.0pt;} @page WordSection1 {size:612.0pt 792.0pt; margin:70.85pt 70.85pt 70.85pt 70.85pt;} div.WordSection1 {page:WordSection1;} /* List Definitions */ @list l0 {mso-list-id:234901890; mso-list-type:hybrid; mso-list-template-ids:369755284 1269215662 68354051 68354053 68354049 68354051 68354053 68354049 68354051 68354053;} @list l0:level1 {mso-level-start-at:0; mso-level-number-format:bullet; mso-level-text:-; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:"Calibri","sans-serif"; mso-fareast-font-family:Calibri;} @list l0:level2 {mso-level-number-format:bullet; mso-level-text:o; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:"Courier New";} @list l0:level3 {mso-level-number-format:bullet; mso-level-text:; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:Wingdings;} @list l0:level4 {mso-level-number-format:bullet; mso-level-text:; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:Symbol;} @list l0:level5 {mso-level-number-format:bullet; mso-level-text:o; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:"Courier New";} @list l0:level6 {mso-level-number-format:bullet; mso-level-text:; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:Wingdings;} @list l0:level7 {mso-level-number-format:bullet; mso-level-text:; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:Symbol;} @list l0:level8 {mso-level-number-format:bullet; mso-level-text:o; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:"Courier New";} @list l0:level9 {mso-level-number-format:bullet; mso-level-text:; mso-level-tab-stop:none; mso-level-number-position:left; text-indent:-18.0pt; font-family:Wingdings;} ol {margin-bottom:0cm;} ul {margin-bottom:0cm;}
--></style>
<div class="WordSection1">
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;">Hi Martin,</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">It appears you have overlooked to submit some more changes:</span></font></p>
<p class="MsoListParagraph" style="text-indent: -18.0pt; mso-list: l0 level1 lfo1;"><!--[if !supportLists]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"><span style="mso-list: Ignore;">-<font face="Times New Roman" size="1"><span style="font: 7.0pt "Times New Roman";"> </span></font></span></span></font><!--[endif]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Player.setIndex() is called but didn’t exist yet,</span></font></p>
<p class="MsoListParagraph" style="text-indent: -18.0pt; mso-list: l0 level1 lfo1;"><!--[if !supportLists]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"><span style="mso-list: Ignore;">-<font face="Times New Roman" size="1"><span style="font: 7.0pt "Times New Roman";"> </span></font></span></span></font><!--[endif]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">GameManager.reorderPlayersByCash() was not added to the GameManagerI interface (redundant as that interface is),</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">(these two omissions I have fixed for you, but…)</span></font></p>
<p class="MsoListParagraph" style="text-indent: -18.0pt; mso-list: l0 level1 lfo1;"><!--[if !supportLists]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"><span style="mso-list: Ignore;">-<font face="Times New Roman" size="1"><span style="font: 7.0pt "Times New Roman";"> </span></font></span></span></font><!--[endif]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Investor_1880 appears to be a new class that you didn’t include at all. That’s where I’m stuck right now.</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Some Javadoc would have helped me to better understand the usage of reorderPlayersByCash(). Questions:</span></font></p>
<p class="MsoListParagraph" style="text-indent: -18.0pt; mso-list: l0 level1 lfo1;"><!--[if !supportLists]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"><span style="mso-list: Ignore;">-<font face="Times New Roman" size="1"><span style="font: 7.0pt "Times New Roman";"> </span></font></span></span></font><!--[endif]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Why does it return Player?</span></font></p>
<p class="MsoListParagraph" style="text-indent: -18.0pt; mso-list: l0 level1 lfo1;"><!--[if !supportLists]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"><span style="mso-list: Ignore;">-<font face="Times New Roman" size="1"><span style="font: 7.0pt "Times New Roman";"> </span></font></span></span></font><!--[endif]--><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Does the ‘high’ argument mean ‘ascending’ or ‘descending’?</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">A side issue is that you haven’t reordered the list of player names as well (which is used in the UI) – but in fact I’m not convinced that this separate player names list should exist at all; I’m considering to remove it.</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">The main thing, however, is that I don’t like your sorting code. These days there are simpler ways to do sorting. </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">For instance (untested, just a rough proposal):</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal" style="text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;"> </span></font><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;"> </span></font><strong><font face="Courier New" size="2" color="#7f0055"><span style="font-size: 10.0pt; font-family: "Courier New"; color: #7f0055; font-weight: bold;" lang="EN-GB">public</span></font></strong><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> void reorderPlayersByCash(</span></font><strong><font face="Courier New" size="2" color="#7f0055"><span style="font-size: 10.0pt; font-family: "Courier New"; color: #7f0055; font-weight: bold;" lang="EN-GB">boolean</span></font></strong><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> descending) {</span></font><font face="Courier New" size="2"><span style="font-size: 10.0pt; font-family: "Courier New";" lang="EN-GB"> </span></font></p>
<p class="MsoNormal" style="text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal" style="text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> Collections.sort (players, new Comparator<Player>() {</span></font></p>
<p class="MsoNormal" style="text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> public int compare (Player p1, Player p2) {</span></font></p>
<p class="MsoNormal" style="text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> return descending ? p1.getCash() – p2.getCash() : p2.getCash() – p1.getCash();</span></font></p>
<p class="MsoNormal" style="margin-left: 70.8pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB">}</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB">});</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB">Player player;</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB">for (int i=0; i<players.size(); i++) {</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> player = players.get(i);</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> player.setIndex (i);</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;" lang="EN-GB"> playerNames.set (i, player.getName());</span></font></p>
<p class="MsoNormal" style="margin-left: 35.4pt; text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;">}</span></font></p>
<p class="MsoNormal" style="text-indent: 35.4pt; text-autospace: none;"><font face="Courier New" size="2" color="black"><span style="font-size: 10.0pt; font-family: "Courier New"; color: black;">}</span></font><font face="Courier New" size="2"><span style="font-size: 10.0pt; font-family: "Courier New";"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">I’d appreciate if you would rework this method in such a way or similarly. Please check if I have got the ascending/descending bits right!</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB">Erik.</span></font></p>
<p class="MsoNormal"><font face="Calibri" size="2" color="#1f497d"><span style="font-size: 11.0pt; font-family: "Calibri","sans-serif"; color: #1f497d;" lang="EN-GB"> </span></font></p>
<div style="border: none; border-left: solid blue 1.5pt; padding: 0cm 0cm 0cm 4.0pt;">
<div>
<div style="border: none; border-top: solid #B5C4DF 1.0pt; padding: 3.0pt 0cm 0cm 0cm;">
<p class="MsoNormal"><strong><font face="Tahoma" size="2"><span style="font-size: 10.0pt; font-family: "Tahoma","sans-serif"; font-weight: bold;">Van:</span></font></strong><font face="Tahoma" size="2"><span style="font-size: 10.0pt; font-family: "Tahoma","sans-serif";"> Dr....@t-... [mailto:Dr....@t-...] <br /><strong><span style="font-weight: bold;">Verzonden:</span></strong> woensdag 4 mei 2011 23:56<br /><strong><span style="font-weight: bold;">Aan:</span></strong> Rails Development<br /><strong><span style="font-weight: bold;">Onderwerp:</span></strong> [Rails-devel] Status update 1880</span></font></p>
</div>
</div>
<p class="MsoNormal"><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Hi Guys,</span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">please find enclosed the Startround code for 1880 (without the bit assigning a building right to the started major corporation yet).</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">The mechanismn needs to be checked by someone else also :) i havent found an error yet, doesnt mean there isnt one of course.</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">And of course theres a problem which i cant figure out how to solve in the moment. After the starting round has ended correctly the priority player in the Stock Round that follows has no action to perform. Somene got any hint where i went wrong ?</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Todo next: Stock round code and Private Company Code handling Building rights on Company Startup and adjusting share mix in the IPO accordingly.</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">I'll add a save file for shortening the bid round. </span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">If the bid code passes the test this can be reused for other variants and might be moved to a non specific class with minor adjustments regarding the price reduction on initial passes. (This is not yet configurable but static coded for 1880).</span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">ToDo: implementing the Startspace/places logic: i.e. per Startspace there are only 4 Public companies allowed to be started with the same par price. Reuse of 1825 formationorder code is possible for the actual runorder determination lateron.</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Missing: a routine to update the Statuswindow ->playerorder if that changes.</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Feedback is appreciated :)</span></font></p>
<p><font face="Times New Roman" size="3"><span style="font-size: 12.0pt;"> </span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Regards,</span></font></p>
<p><font face="Arial" size="3" color="black"><span style="font-size: 12.0pt; font-family: "Arial","sans-serif"; color: black;">Martin</span></font></p>
</div>
</div>
</div>
</span></p></body></html> |
|
From: Erik V. <eri...@xs...> - 2011-05-06 20:04:56
|
Sorry, I said 18AL but I meant 1851. One possible application could be to regulate access to 18AL Birmingham, which springs to life in a certain game phase, but I believe that case has already been covered. If it would help, initializing Birmingham with 'runTo="no"' could reflect this city's early non-existence. Erik. Van: Erik Vos [mailto:eri...@xs...] Verzonden: donderdag 28 april 2011 20:43 Aan: 'Development list for Rails: an 18xx game' Onderwerp: Re: [Rails-devel] 1830 Reading > Van: Scott Petersen [mailto:sc...@re...] > Is runThrough a better term than driveThrough? Or maybe "drive" has a special definition in the code that I am not aware of. Yes, runThroughStation sounds a lot better to me. > Van: Chris Shaffer [mailto:chr...@gm...] > Related to this, you might want driveToStation="tokenOnly" to support 18Scan and perhaps others. In 18Scan, you are not allowed to score a red offboard city unless you have a token in it. That would be 'runToStation' then. Agreed, and, as others have pointed out, it applies to several games. > Van: John A. Tamplin [mailto:ja...@ja...] > You should also consider similar mechanisms in other games: > 18GL ferry - requires ownership of the ferry private, or pay its owner each round used > 1832/1850 coal fields - may not trace a route to or through (even for track laying) the coal fields without ownership of a coal token > Van: Scott Petersen [mailto:sc...@re...] > Yes, and the currently implemented 1830 Coalfields variant is somewhat hard to play because it assumes that all companies have coal access rights. By the late game when the big runs are kicking in, lots of companies have a route to the coalfields, so the route calculation is incorrect for those that do not have the rights. These cases are different, although parts of the underlying mechanism would probably be similar. Erik. |
|
From: Erik V. <eri...@xs...> - 2011-05-06 19:48:20
|
I have added runThrough and runTo properties to MapHex, as well as the related getters isRunThroughAllowed() and isRunToAllowed(). Possible values: "yes", "no" and "tokenOnly" (values of a new enum MapHex.Run). These new properties are intended to facilitate certain special cases in constructing routes, as the names indicate. See the below discussion. As an example, runThrough="tokenOnly" has been specified for 1830 Altoona and for the Reading home city (Harrisburg?) in the 1830 Reading variant. Note: These properties have only been defined, but are not yet used by any code. So Altoona can still be run though if untokened. These properties currently have fixed values. If needed, they could be made changeable (and undoable) pretty easily, but I don't know if there is a need. One possible application could be to regulate access to 18AL Birmingham, which springs to life in a certain game phase, but I believe that case has already been covered. If it would help, initializing Birmingham with 'runTo="no"' could reflect this city's early non-existence. Erik. Van: Erik Vos [mailto:eri...@xs...] Verzonden: donderdag 28 april 2011 20:43 Aan: 'Development list for Rails: an 18xx game' Onderwerp: Re: [Rails-devel] 1830 Reading > Van: Scott Petersen [mailto:sc...@re...] > Is runThrough a better term than driveThrough? Or maybe "drive" has a special definition in the code that I am not aware of. Yes, runThroughStation sounds a lot better to me. > Van: Chris Shaffer [mailto:chr...@gm...] > Related to this, you might want driveToStation="tokenOnly" to support 18Scan and perhaps others. In 18Scan, you are not allowed to score a red offboard city unless you have a token in it. That would be 'runToStation' then. Agreed, and, as others have pointed out, it applies to several games. > Van: John A. Tamplin [mailto:ja...@ja...] > You should also consider similar mechanisms in other games: > 18GL ferry - requires ownership of the ferry private, or pay its owner each round used > 1832/1850 coal fields - may not trace a route to or through (even for track laying) the coal fields without ownership of a coal token > Van: Scott Petersen [mailto:sc...@re...] > Yes, and the currently implemented 1830 Coalfields variant is somewhat hard to play because it assumes that all companies have coal access rights. By the late game when the big runs are kicking in, lots of companies have a route to the coalfields, so the route calculation is incorrect for those that do not have the rights. These cases are different, although parts of the underlying mechanism would probably be similar. Erik. |
|
From: Erik V. <eri...@xs...> - 2011-05-05 22:45:18
|
Hi Martin,
It appears you have overlooked to submit some more changes:
- Player.setIndex() is called but didn’t exist yet,
- GameManager.reorderPlayersByCash() was not added to the GameManagerI interface (redundant as that interface is),
(these two omissions I have fixed for you, but…)
- Investor_1880 appears to be a new class that you didn’t include at all. That’s where I’m stuck right now.
Some Javadoc would have helped me to better understand the usage of reorderPlayersByCash(). Questions:
- Why does it return Player?
- Does the ‘high’ argument mean ‘ascending’ or ‘descending’?
A side issue is that you haven’t reordered the list of player names as well (which is used in the UI) – but in fact I’m not convinced that this separate player names list should exist at all; I’m considering to remove it.
The main thing, however, is that I don’t like your sorting code. These days there are simpler ways to do sorting.
For instance (untested, just a rough proposal):
public void reorderPlayersByCash(boolean descending) {
Collections.sort (players, new Comparator<Player>() {
public int compare (Player p1, Player p2) {
return descending ? p1.getCash() – p2.getCash() : p2.getCash() – p1.getCash();
}
});
Player player;
for (int i=0; i<players.size(); i++) {
player = players.get(i);
player.setIndex (i);
playerNames.set (i, player.getName());
}
}
I’d appreciate if you would rework this method in such a way or similarly. Please check if I have got the ascending/descending bits right!
Erik.
Van: Dr....@t-... [mailto:Dr....@t-...]
Verzonden: woensdag 4 mei 2011 23:56
Aan: Rails Development
Onderwerp: [Rails-devel] Status update 1880
Hi Guys,
please find enclosed the Startround code for 1880 (without the bit assigning a building right to the started major corporation yet).
The mechanismn needs to be checked by someone else also :) i havent found an error yet, doesnt mean there isnt one of course.
And of course theres a problem which i cant figure out how to solve in the moment. After the starting round has ended correctly the priority player in the Stock Round that follows has no action to perform. Somene got any hint where i went wrong ?
Todo next: Stock round code and Private Company Code handling Building rights on Company Startup and adjusting share mix in the IPO accordingly.
I'll add a save file for shortening the bid round.
If the bid code passes the test this can be reused for other variants and might be moved to a non specific class with minor adjustments regarding the price reduction on initial passes. (This is not yet configurable but static coded for 1880).
ToDo: implementing the Startspace/places logic: i.e. per Startspace there are only 4 Public companies allowed to be started with the same par price. Reuse of 1825 formationorder code is possible for the actual runorder determination lateron.
Missing: a routine to update the Statuswindow ->playerorder if that changes.
Feedback is appreciated :)
Regards,
Martin
|
99 messages has been excluded from this view by a project administrator.
