Re: [Radmind-devel] radmind.hook doesn't run postapply actions?

[Andrew M. <adm...@um...>]

On Nov 1, 2006, at 12:52 AM, Nigel Kersten wrote:

> I was having trouble getting postapply scripts to run when logging in
> and triggering the radmind.hook loginhook, although they'd work
> happily when running ra.sh, and added a logger line to debug the
> process.
>
> # run any scripts in the post-apply directory
> if [ -d ${postapply} ]; then
>      for script in "${postapply}/*"; do

This is clearly a typo, since it prevents the shell from doing the  
expansion required to make the loop at all useful.

> Perhaps this should be done in the way that it is done in the ra.sh
> script instead?

I'd like radmind.hook eventually to be nothing more than a wrapper  
for ra.sh, so please concentrate on that script instead. I'll check  
in the quoting fix, but that won't address the issues raised by Ian.  
Because radmind.hook will eventually just wrap ra.sh, I'm not  
especially concerned about resolving those particular issues in the  
hook, but would be very happy to see a patch attempting to take care  
of those problems in ra.sh. If you take a look at ra.sh revisions  
1.23, 1.24 and 1.26, you can see we've attempted to come up with a  
workable solution, but it could obviously be improved.

andrew