Re: [RESEND] Re: Patch / Feature request - bidirectional QwtThermo

[Felix N. <fel...@eu...>]

On 11.02.2013 08:45, Uwe Rathmann wrote:
> I'm not really happy with this patch as the implementation of the new
> mode is incomplete: the alarm level is ignored and it doesn't work in
> combination with color maps. I will try to make it complete myself.

I tested it with color maps - works fine here (actually I'm using it 
with colormaps)... I might have missed some code paths though.

In any case, I'd very much prefer for someone to do this who actually 
knows the code.

> The documentation of the OriginMinMax mode is wrong as QwtThermo always
> fills from the minimum.

Well, I meant the (minimum > maximum) case...

> Concerning origin/position: I will modify the API according to
> QwtSlider. To do this for QwtThermo has simply been forgotten.

Fine be me. Thanks. :-)

> Your patch also includes a modification of the layout code ( subtracting
> the border width twice ), what seems to be wrong to me. What is the
> reason for this modification ?

Huh? Sorry, must have been a mismerge when going from stable to trunk...

Felix



Eurocopter Deutschland GmbH
Sitz der Gesellschaft/Registered Office: Donauwoerth
Registergericht/Registration Court: Amtsgericht Augsburg HRB 16508
Vorsitzender des Aufsichtsrates/Chairman of the Supervisory Board: Dr. Lutz Bertling
Geschaeftsfuehrung/Board of Management:
Dr. Wolfgang Schoder, Vorsitzender/CEO; Friedrich-Wilhelm Hormel; Ralf Barnscheidt

CONFIDENTIALITY NOTICE 

This communication and the information it contains is intended for the addressee(s) named above and for no other persons or organizations. It is confidential and may be legally privileged and protected by law. The unauthorized use, copying or disclosure of this communication or any part of it is prohibited and may be unlawful. 
If you have received this communication in error, kindly notify us by return e-mail and discard and/or delete the communication. Thank you very much. 
It is possible for e-mails to be intercepted or affected by viruses. Whilst we maintain virus checks on our e-mails, we accept no liability for viruses or other material which might be introduced with this message.