Jesir, our GUIs are just getting more and more varied, which is no bad thing, but I think we need to at least agree on what needs to go in guimain...
My opinion is that we should have as little as possible on guimain, but that there should be all the options there that people will want to change on a per-track basis. That, to my mind, means:
* Name
* Filesize / video bitrate
* Audio / subtitle languages
Now we either put them all up front, as in my GUI, or we use your latest idea and have a "show more" type button that, when you click on it, expands the GUI to show these options. I don't think we should hide them, since I don't think it makes it significantly easier to use not having to see them, and I know that a lot of people will be ripping to very different file sizes/bitrates.
I do like the idea of offering the "format" option, but should that not be in settings, as part of the codecs bit, so you can choose:
DivX MPEG
XviD MPEG
VCD
SVCD
PDA MPEG
What are everyone's thoughts on this?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If I could throw in my two cents, I currently prefer the *-tom variation of the GUI. My reasons for each:
guimain:
I think people understand working from top to bottom better than working from left to right, at least in a user interface.
guisettings:
I prefer the -tom version here because I *really* dislike the big blue bar "category" at the top. Sorry jesir, but it's really distracting. If that were gone, then I would probably lean toward jesir's version more.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Let me amend my previous comment... I would definitely choose jesir's guisettings dialog if the blue bar was gone. Again, because the dialogs flow from top to bottom, instead of requiring the user to move left to right, top to bottom. Much better flow, if you ask me.
jesir, loose the blue bar and you're golden... :-)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Not sure if this should go here or with the base.py post, but here goes:
There's an issue I have with the current settings configuration you have.
I think each track should have it's own audio/video quality settings on the main dialog. I agree, we should leave specific codec/formats in the settings dialog. But I think the addition of an audio quality (bitrate) setting on the maingui per track would be just as becoming and necessary as the video quality (bitrate) is.
So to sum up, please consider an audio bitrate on a per track basis (this means adding a dvdbase.titles['abr'] - audio bit rate - setting along side the titles['vbr'] and modifying the config file save/loading to get rid of the one-size-fits-all audio bitrate setting)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Audio bitrate used to be configurable on a title-by-title basis, but I recently changed it to be a DVD-wide setting since I don't see why somebody would want a different audio bitrate for each title. Do you think someone might?
If abr is put back in the title settings then guisettings would still need a default abr, since otherwise having to change the abr from the GUI default to your own for each title every time would be a real pain.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think somebody like me would want a per title setting, or just quick easy access to it because I might not want to click on settings and search for the way to change it. Not to mention it adds a nice parallel to the video bitrate.
We could just set it to 128 :), but let's have a default from the config somewhere...
Glad my ui is working out alright.
About chapters... Are we going to rip by chapter at all? I saw numchapters, but no information about them...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
OK, well how about we go with a per-title setting in guimain, and a default setting in guisettings?
Chapters... we can do, though it can be a fair bit of work to implement, since you need to change the ripping from "rip title 1" to "rip chapters 10-14 on title 1, then rip chapters 15-16 on title 1", etc.
I could implement it. Maybe I could just dump the CLI for a while an stick to base.py... much more fun ;)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Well, chapters would be nice (skipping credits, ripping half at higher quality, or whatever). Maybe this can be saved for version two if it's really that much work.
I'd like the feature though if you want to do it :).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I shall see... as I'm selfish and lazy it will depend on how annoying curses is (so how much more time I spend on base for relief) and how difficult it will be to implement the idea in the curses UI. I know it's easy in Qt and Gtk because I had the ability to choose individual chapters back in 0.1 to (I think) 0.3, though it didn't actually rip individual chapters ;-)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Jesir, our GUIs are just getting more and more varied, which is no bad thing, but I think we need to at least agree on what needs to go in guimain...
My opinion is that we should have as little as possible on guimain, but that there should be all the options there that people will want to change on a per-track basis. That, to my mind, means:
* Name
* Filesize / video bitrate
* Audio / subtitle languages
Now we either put them all up front, as in my GUI, or we use your latest idea and have a "show more" type button that, when you click on it, expands the GUI to show these options. I don't think we should hide them, since I don't think it makes it significantly easier to use not having to see them, and I know that a lot of people will be ripping to very different file sizes/bitrates.
I do like the idea of offering the "format" option, but should that not be in settings, as part of the codecs bit, so you can choose:
DivX MPEG
XviD MPEG
VCD
SVCD
PDA MPEG
What are everyone's thoughts on this?
If I could throw in my two cents, I currently prefer the *-tom variation of the GUI. My reasons for each:
guimain:
I think people understand working from top to bottom better than working from left to right, at least in a user interface.
guisettings:
I prefer the -tom version here because I *really* dislike the big blue bar "category" at the top. Sorry jesir, but it's really distracting. If that were gone, then I would probably lean toward jesir's version more.
Let me amend my previous comment... I would definitely choose jesir's guisettings dialog if the blue bar was gone. Again, because the dialogs flow from top to bottom, instead of requiring the user to move left to right, top to bottom. Much better flow, if you ask me.
jesir, loose the blue bar and you're golden... :-)
I've amended my guisettings so the mencoder options all go from top to bottom. I admit, it does look better this way :)
I made some changes to my settings.ui try. Namely, blue bar is gone, and some connections (signals/slots) were made.
Comments??
Not sure if this should go here or with the base.py post, but here goes:
There's an issue I have with the current settings configuration you have.
I think each track should have it's own audio/video quality settings on the main dialog. I agree, we should leave specific codec/formats in the settings dialog. But I think the addition of an audio quality (bitrate) setting on the maingui per track would be just as becoming and necessary as the video quality (bitrate) is.
See this example of what I'm working on:
http://www.ruinedsoft.com/quickrip.png
So to sum up, please consider an audio bitrate on a per track basis (this means adding a dvdbase.titles['abr'] - audio bit rate - setting along side the titles['vbr'] and modifying the config file save/loading to get rid of the one-size-fits-all audio bitrate setting)
I like the look of that GUI by the way :)
Audio bitrate used to be configurable on a title-by-title basis, but I recently changed it to be a DVD-wide setting since I don't see why somebody would want a different audio bitrate for each title. Do you think someone might?
If abr is put back in the title settings then guisettings would still need a default abr, since otherwise having to change the abr from the GUI default to your own for each title every time would be a real pain.
I think somebody like me would want a per title setting, or just quick easy access to it because I might not want to click on settings and search for the way to change it. Not to mention it adds a nice parallel to the video bitrate.
We could just set it to 128 :), but let's have a default from the config somewhere...
Glad my ui is working out alright.
About chapters... Are we going to rip by chapter at all? I saw numchapters, but no information about them...
OK, well how about we go with a per-title setting in guimain, and a default setting in guisettings?
Chapters... we can do, though it can be a fair bit of work to implement, since you need to change the ripping from "rip title 1" to "rip chapters 10-14 on title 1, then rip chapters 15-16 on title 1", etc.
I could implement it. Maybe I could just dump the CLI for a while an stick to base.py... much more fun ;)
Well, chapters would be nice (skipping credits, ripping half at higher quality, or whatever). Maybe this can be saved for version two if it's really that much work.
I'd like the feature though if you want to do it :).
I shall see... as I'm selfish and lazy it will depend on how annoying curses is (so how much more time I spend on base for relief) and how difficult it will be to implement the idea in the curses UI. I know it's easy in Qt and Gtk because I had the ability to choose individual chapters back in 0.1 to (I think) 0.3, though it didn't actually rip individual chapters ;-)