After taking a look at quickrip code and after posting two (trivial) patches I have some consoderations:
Quickrip is a nice interface but there is too much cut-n-paste in it's code. I know it works but it's not the right way to develop.
Moreover I find useless the presence of 3 different guiprogressdialogue_Xpass.ui
Quickrip only needs one of them (with one progress bar) customizable at run-time.
I'll try to make these changes in the next days and I'll post them as patches.
As I said, I like quickrip, these are just suggestions. I don't want to start a flame war.
Regards
Luca
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
That'd be cool if you could clean it up. The reason it looks so unprofessional is because I started developing it purely for my own use, and I only really made it a public release on version 0.4. Up until 0.6 I never intended to let others co-develop it with me either, so I suppose I was lazy in my coding ;) Since then, I've not had the time to clean it up, but if you could do a good job, that'd be great.
Just please thoroughly test your cleaned code before you commit ;)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
After taking a look at quickrip code and after posting two (trivial) patches I have some consoderations:
Quickrip is a nice interface but there is too much cut-n-paste in it's code. I know it works but it's not the right way to develop.
Moreover I find useless the presence of 3 different guiprogressdialogue_Xpass.ui
Quickrip only needs one of them (with one progress bar) customizable at run-time.
I'll try to make these changes in the next days and I'll post them as patches.
As I said, I like quickrip, these are just suggestions. I don't want to start a flame war.
Regards
Luca
Luca,
That'd be cool if you could clean it up. The reason it looks so unprofessional is because I started developing it purely for my own use, and I only really made it a public release on version 0.4. Up until 0.6 I never intended to let others co-develop it with me either, so I suppose I was lazy in my coding ;) Since then, I've not had the time to clean it up, but if you could do a good job, that'd be great.
Just please thoroughly test your cleaned code before you commit ;)