Re: [Quickfixj-users] Acceptor dropping logout messages

[Christoph J. <chr...@ma...>]

Hi Tim,

umm, well, yeah, would have been better to test the snapshot release back in April than waiting for 
the release. ;-)
I'll check the PR you submitted.
There probably won't be a 1.6.5 release but the next will be 1.7.0.

Cheers,
Chris.


On 02/08/17 13:09, traggatt wrote:
> QuickFIX/J Documentation:http://www.quickfixj.org/documentation/
> QuickFIX/J Support:http://www.quickfixj.org/support/
>
>
> Hi Chris,
>
> Apologies for the long delay in responding here.
>
> I tested the new 1.6.4 release and the issue is still there. After a little
> debugging, I have a new explanation for the behaviour - please see below.
>
> When a FIX acceptor is shutdown, a call is made to
> SessionConnector.logoutAllSessions(). This calls Session.logout() on all
> sessions in turn, regardless of prior status. The logout() method is
> asynchronous and merely sets a private flag in Session. The actual logout
> message is sent later when the flag is picked up by a background thread (see
> Session.next()).
>
> After the SessionConnector.logout() call completes, the SessionConnector
> should wait for all sessions to be logged out. However, due to incorrect use
> of SessionConnector.isLoggedOn(), waitForLogout() is never called.
>
> isLoggedOn() performs an AND-style operation on the results of all
> session.isLoggedOn() methods. This means that if one or more sessions are
> not logged on, we do not wait for those that are.
>
> In our configuration, we run multiple sessions which are not necessarily all
> connected at once. Thus we do not see the shutdown routine wait for the
> logout message to be sent.
>
> Testing with our application, if I override the SessionConnector class and
> switch in an OR-style operation for the isLoggedOn() call, I always see the
> logout being sent.
>
> FYI: latest 1.6.x version of SessionConnector:
> https://github.com/quickfix-j/quickfixj/blob/QFJ_1_6_x/quickfixj-core/src/main/java/quickfix/mina/SessionConnector.java
>
> Thanks
> Tim.
>
>
>
> --
> View this message in context:http://quickfix-j.364392.n2.nabble.com/Acceptor-dropping-logout-messages-tp7579837p7580084.html
> Sent from the QuickFIX/J mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org!http://sdm.link/slashdot
> _______________________________________________
> Quickfixj-users mailing list
> Qui...@li...
> https://lists.sourceforge.net/lists/listinfo/quickfixj-users

-- 
Christoph John
Development & Support
Direct: +49 241 557080-28
Mailto:Chr...@ma...
	


http://www.macd.com <http://www.macd.com/>
----------------------------------------------------------------------------------------------------
	
----------------------------------------------------------------------------------------------------
MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
Tel: +49 241 557080-0 | Fax: +49 241 557080-10
	 Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663

Geschäftsführer: George Macdonald
----------------------------------------------------------------------------------------------------
	
----------------------------------------------------------------------------------------------------

take care of the environment - print only if necessary