[Quickfix-developers] Missing .NET constructor FileLogFactory(SessionSettings *)

[Vladimir A. <Vladimir.Arnost@FFastFill.com>]

Hello,

I=20have=20found=20that=20the=20.NET=20version=20of=20FileLogFactory=20cla=
ss=20is=20missing=20a
constructor=20taking=20SessionSettings=20parameter.=20Only=20the=20String=20=
version=20is
provided.=20The=20C++=20version=20has=20both.
Furthermore,=20the=20existing=20constructor=20leaves=20m_settings=20pointe=
r
uninitialized,=20which=20is=20a=20bad=20thing=20even=20if=20this=20member=20=
is=20unused=20(the
same=20problem=20exists=20in=20the=20FileMessageStore=20constructor=20too)=
.

Here=20are=20the=20diffs:

---=20FileLog.h=092004-04-29=2015:08:20.000000000=20+0200
+++=20FileLog.h.new=092004-06-28=2018:35:14.143721500=20+0200
@@=20-86,7=20+86,9=20@@
=20public=20__gc=20class=20FileLogFactory=20:=20public=20LogFactory
=20{
=20public:
-=20=20FileLogFactory(=20String*=20path=20)=20:=20m_path(=20path=20)=20{}
+=20=20FileLogFactory(=20SessionSettings*=20settings=20)=20:=20m_path(=200=
=20),
m_settings(=20settings=20)=20{}
+
+=20=20FileLogFactory(=20String*=20path=20)=20:=20m_path(=20path=20),=20m_=
settings(=200=20)=20{}
=20
=20=20=20Log*=20create(=20SessionID*=20sessionID=20)
=20=20=20{=20QF_STACK_TRY

---=20FileMessageStore.h=092004-04-29=2015:08:20.000000000=20+0200
+++=20FileMessageStore.h.new=092004-06-28=2018:55:00.700916200=20+0200
@@=20-54,7=20+54,7=20@@
=20=20=20FileStoreFactory(=20SessionSettings*=20settings=20)
=20=20=20:=20m_path(=200=20),=20m_settings(=20settings=20)=20{}
=20
-=20=20FileStoreFactory(=20String*=20path=20)=20:=20m_path(=20path=20)=20{=
}
+=20=20FileStoreFactory(=20String*=20path=20)=20:=20m_path(=20path=20),=20=
m_settings(=200=20)=20{}
=20
=20=20=20MessageStore*=20create(=20SessionID*=20sessionID=20)
=20=20=20{=20QF_STACK_TRY


Please=20put=20these=20patches=20to=20the=20official=20source=20tree.

Thanks,
=20=20Vlad

-------------------------------------------------------------
Ing.=20Vladimir=20Arnost,=20Developer,=20FFastFill=20Europe=20Ltd.
Vaclavske=20namesti=2055,=20Prague,=20Czech=20Republic

________________________________________________________________________
This=20email=20and=20any=20files=20transmitted=20with=20it=20are=20confide=
ntial=20and
intended=20solely=20for=20the=20use=20of=20the=20individual=20or=20entity=20=
to=20whom=20they
are=20addressed.=20If=20you=20have=20received=20this=20email=20in=20error=20=
please=20notify
sec...@ff...

This=20email=20has=20been=20scanned=20for=20all=20viruses=20by=20the=20FFa=
stFill=20Email
Security=20System.
________________________________________________________________________