Menu
▾
▴
[ quesa-Bugs-902950 ] Improve view state stack performance
|
From: SourceForge.net <no...@so...> - 2007-03-15 02:20:12
|
Bugs item #902950, was opened at 2004-02-23 12:10 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=442052&aid=902950&group_id=45158 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Dair Grant (grantd) Assigned to: Nobody/Anonymous (nobody) Summary: Improve view state stack performance Initial Comment: A performance bottleneck at present is that pushing/popping the view state stack is quite expensive. This could be improved by doing some kind of lazy-updating of the stack, where values would only be pushed if they were changed since the view state was 'pushed'. ------- Additional Comments From Dair Grant 2002-04-17 09:58 ------- Additional comments from Erik Olson: > Profiling under Quesa did reveal that about one third of cpu > time was spent copying and destructing attribute sets on > stack pops. An optimization would be to have lazy > construction of the stack frame's attribute set. > > I rely on the stack to unwind hierarchical matrix transforms > and infrequent color highlights, so most of the time the > attribute set is constant. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2007-03-14 19:20 Message: Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: James W. Walker (jwwalker) Date: 2007-02-27 21:14 Message: Logged In: YES user_id=433183 Originator: NO We're no longer duplicating or destroying attribute sets when the view state stack is pushed or popped. The statement of the bug is a bit too ill-defined to state definitively that it has been "fixed", but I'm not sure we need the bug around any more. In the future, performance bugs should contain specific instructions on how to duplicate a particularly slow case. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=442052&aid=902950&group_id=45158 |
