Re: First stage of Quesa changes now complete

[Joseph J. S. <jo...@st...>]

At 6:59 PM +0000 1/26/05, Roger Holmes wrote:

>Secondly I have been running the old 'Sampler' tool on our application
>while it is refreshing the screen using the Microspot Renderer which of
>course uses Quesa.

I haven't used Sampler in a long time, but...

>6.2% in Q3Object_IsType
>...
>3.0% in E3Object_IsType, so actually doing the work is quicker than
>Q3Object_IsType  the glue routine above which checks parameters and calls us!

That is surprising.  This may be a silly question, but are you sure 
Sampler is showing you the time spent only in the parent function, 
and not the time spent in the parent function or any of its children 
(functions it calls)?

>I think in the release version we are checking out inputs too often, 
>for instance in E3Shared_Acquire we check the parameter is of type 
>shared. We then call Q3Shared_GetReference which again checks its 
>parameter is of type shared.
>It also calls E3System_Bottleneck even though we must have come into
>E3Shared_Acquire from a Q3 routine which will have already called
>E3System_Bottleneck.

That's a good point.  I would think that once we're in a E3 routine, 
we should be safe to directly call another E3 routine rather than 
going through the Q3 version.  As a general principle, we may trust 
ourselves, even if we don't trust the user.

-- 
,------------------------------------------------------------------.
|    Joseph J. Strout         Check out the Mac Web Directory:     |
|    jo...@st...           http://www.macwebdir.com/            |
`------------------------------------------------------------------'