|
From: Dair G. <da...@re...> - 2004-11-03 21:03:14
|
James W. Walker wrote: >Just so you know that I'm not optimizing without profiling: In a=20 >particular situation, picking with lots of complex objects, Shark=20 >showed that about 16% of the time was being spent in=20 >e3hash_find_node. After the optimization that I just checked in,=20 >that went down to about 6%. The perils of not posting for a while... :-) This was actually one of the changes that came up when looking at Roger's changes to the way instance data is found; the existing hash function turned out to be really quite suboptimal (use of % generates an expensive divide), and so replacing that was definitely a good idea. I actually had it changed here too, but never got round to checking it in - thanks! :-) -dair ___________________________________________________ mailto:dair+refnum.com http://www.refnum.com/ |