Re: Patch for bug #901422 (CLAMP_TO_EDGE)

[Frank C. <dev...@ch...>]

No, that'll break it...

The value will be false to start (the struct is zeroed in the function) 
and is set to true if using OpenGL 1.2+. The extension may not exist in 
an OpenGL 1.2+ implementation though, so you'll be setting it back to 
false even though it can be handled just fine at that point. The 
extension check is strictly for older OpenGL versions before the ARB 
ratified the function.

Frank.

On 29-Sep-04, at 10:59 AM, Daniele Cavallini wrote:

> Question:
> Is It better add this "else" in function "GLUtils_CheckExtensions"?
>
>  if (isOpenGLExtensionPresent( openGLExtensions, 
> GL_EXT_texture_edge_clamp" ))
>         {
>                 featureFlags->clampToEdge = kQ3True;
>         }
>         else
>                 featureFlags->clampToEdge = kQ3False;
> Daniele
>
> At 01.50 29/09/04, you wrote:
>> Here: <http://chaoticbox.com/quesa901422.zip> is a small patch that
>> checks for CLAMP_TO_EDGE and uses it when available for texture 
>> shaders
>> that have a kQ3ShaderUVBoundaryClamp setting. The original report is
>> here:
>> <http://sourceforge.net/tracker/index.php? 
>> func=detail&aid=901422&group_id=45158&atid=442052>
>>
>> On a similar note; Is there a better way to submit patches? Do you 
>> guys
>> prefer some sort of diff tool output? If so, please let me know...