Re: BUG in function "ir_texture_convert_rave_filter" ?

[James W. W. <ja...@wr...>]

Daniele Cavallini <dca...@in...> wrote:

>I think there is a bug in the function :
>
>static TQ3QualityFilter
>ir_texture_convert_rave_filter(TQ3ViewObject theView)
>
>WRONG:
>.....
>
>	switch (raveFilter) {
>		case kQATextureFilter_Fast:
>			oglFilter.magFilter = GL_NEAREST;
>			oglFilter.minFilter = GL_NEAREST;
>			break;
>......
>
>CORRECT:
>....
>switch (raveFilter) {
>		case kQATextureFilter_Fast:
>			oglFilter.magFilter = GL_LINEAR;
>			oglFilter.minFilter = GL_NEAREST;
>			break;
>.....
>What do you think?


What's your reasoning?

In the description of GL_TEXTURE_MAG_FILTER in the OpenGL Reference 
Manual, it says that GL_NEAREST is generally faster than GL_LINEAR. 
That sounds like what we want for kQATextureFilter_Fast.
-- 
   James W. Walker, ScriptPerfection Enterprises, Inc.
   <http://www.write-brain.com/>