Re: BUG in function "ir_texture_convert_rave_filter" ?

[Frank C <li...@si...>]

On 5-Aug-04, at 11:26 AM, Daniele Cavallini wrote:

> I think there is a bug in the function :
>
> static TQ3QualityFilter
> ir_texture_convert_rave_filter(TQ3ViewObject theView)
>
> WRONG:
> .....
>
> 	switch (raveFilter) {
> 		case kQATextureFilter_Fast:
> 			oglFilter.magFilter = GL_NEAREST;
> 			oglFilter.minFilter = GL_NEAREST;
> 			break;
> ......

No, that's correct... kQATextureFilter_Fast uses nearest neighbour 
interpolation when textures are scaled in either direction.

> CORRECT:
> ....
> switch (raveFilter) {
> 		case kQATextureFilter_Fast:
> 			oglFilter.magFilter = GL_LINEAR;
> 			oglFilter.minFilter = GL_NEAREST;
> 			break;
> .....

That isn't a recommended setting, and would produce odd looking results 
at best. If you want bilinear filtering that doesn't use mipmaps (i.e. 
GL_LINEAR/GL_LINEAR) set the filter to kQATextureFilter_Mid or 
kQATextureFilter_Best and use Mipmap textures with their 
"useMipmapping" flag turned off.

Frank.