Re: quesa/Development/Source/Renderers/Interactive IRGeometry.c,1.46,1.47

[Dair G. <da...@re...>]

Roger Holmes wrote:

>James' change of Q3Vector3D_Length to Q3FastVector3D_Length before
>comparing with 1.0 (with a tolerance) made me wonder why we need to do
>the square root. Why not call Q3FastVector2D_LengthSquared instead?

That's normally a good trick to use (compare squares rather than actual
lengths), but this code is only hit in a debug build anyway - so it's
probably clearer when you're stepping through to just get the actual
length.


>By the way, I think the name kQ3RealZero is a bit misleading. Real
>zero is zero, kQ3RealZero is just a small number. How about
>kQ3AlmostZero?

Yes, I've always thought kQ3RealZero was an odd name for something that
isn't really zero. :-)

Perhaps kQ3Epsilon, since that's really what it's used for (and maps to
=46LT_EPSILON if that's available).


-dair
___________________________________________________
mailto:dair+refnum.com       http://www.refnum.com/