Re: quesa/Development/Source/Platform/Windows E3WindowsStorage.c,1.8,1.9

[Dair G. <da...@re...>]

Jose Cruanyes wrote:

>Q3WindowsStorage takes a open file and a open file had to leave, but
>currently it closed the file Now I've made both the open and close
>methods NOPs

Might be worth sticking a comment in just above the switch statement to
say that the open/close methods are deliberately not provided for Win32
storage?

I can see us going back and saying "oops, we're missing open/close here"
at some point without realising why they were removed... :-)


This does make the Win32 storage object inconsistent with the others
though. Since the QD3D docs were contradictory, should we conditionalise
this in QUESA_BUILD_AS_BINARY_COMPATIBLE?

I.e., if QUESA_BUILD_AS_BINARY_COMPATIBLE is 0 then we should open/close
the file as per the other storage objects: if it's 1 then we would take
this approach of assuming the app is responsible (I assume that's what
caused the change, i.e., your app passes in an open file on Win32?).


-dair
___________________________________________________
mailto:dair+refnum.com       http://www.refnum.com/