Re: Bug 895099 proposed fix

[Dair G. <da...@re...>]

James W. Walker wrote:

>If there was ever a swap back, I never saw it.

Yes, it looks like that's been setting it to NULL (rather than setting
it back to what it was) forever.


>My changes to fix the bug were in just 2 places:
>IRGeometry_Attribute_Handler to submit the shader rather than calling
>IRRenderer_Update_Shader_Surface, and E3Renderer_Method_SubmitGeometry
>to push and pop the view state.

Although this fixes the retained mode bug (but with a double-submit of
the texture), it won't fix it for an immediate mode box. What do you
think about moving the push/pop sequence into the renderer, so that we
swap out at the point we were before but now actually restore rather
than just reverting to NULL?


-dair
___________________________________________________
mailto:dair+refnum.com       http://www.refnum.com/